Ivan Žužak
852456fafe
Merge pull request #7173 from atom/ns-prompt-on-large-files
...
Show a warning prompt when opening files over 20MB
2015-06-21 18:17:59 +02:00
Michael Bolin
ad46b37cfe
In workspace-spec.coffee, updated FakeSearch to match the spec, which
...
helped uncover a bug.
2015-06-10 23:30:42 +01:00
Michael Bolin
3c44bc06f4
Revert "Revert "Introduce atom.directory-searcher service v0.1.0.""
...
This reverts commit 262d41c306
2015-06-10 23:30:25 +01:00
Max Brunsfeld
262d41c306
Revert "Introduce atom.directory-searcher service v0.1.0."
2015-06-09 11:51:30 -07:00
Michael Bolin
535c0e2f34
Fix documentation bug.
2015-06-09 15:34:10 +01:00
Michael Bolin
6b1b57c89c
Rename a variable to reflect a change in the previous commit.
2015-06-09 15:34:10 +01:00
Michael Bolin
0630bce95c
Two things:
...
* Removed the `Directory` argument to `didSearchPaths`.
Now each searcher gets its own instance of `didSearchPaths` that is parameterized by provider.
* Simplified `DefaultDirectorySearcher.search()` so it creates one `DirectorySearch`
rather than one per `Directory` passed to `search()`.
2015-06-09 15:34:10 +01:00
Michael Bolin
18ac7d0cbc
Comment excised, as recommended by @maxbrunsfeld.
2015-06-09 15:34:09 +01:00
Michael Bolin
028ac79836
Changed the behavior so that if a searcher rejects,
...
then the thenable returned by `atom.workspace.scan()` rejects.
2015-06-09 15:34:09 +01:00
Michael Bolin
7dc3d07f8a
Changed the contract of DefaultDirectorySearcher in two significant ways:
...
* `search()` takes an array of `Directory` objects rather than an individual object.
* `options.didSearchPaths` now takes the `Directory` in addition to the `count` as an argument.
2015-06-09 15:34:09 +01:00
Michael Bolin
36123faf5d
Changed DefaultDirectorySearcher to take multiple directories.
...
Still need to update `workspace.coffee` to make better use of this.
2015-06-09 15:34:09 +01:00
Michael Bolin
318498464a
Responded to all of @maxbrunsfeld's comments except for:
...
* The effect of a failed search.
* Letting `DirectorySearcher::search` take multiple directories.
I'm working on those now.
2015-06-09 15:34:09 +01:00
Michael Bolin
5fc9d9e01a
Document and test the cancel() method on the object returned by atom.workspace.scan().
2015-06-09 15:34:09 +01:00
Michael Bolin
f7e822d41f
Make delegate method names more delegate-like.
2015-06-09 15:34:09 +01:00
Michael Bolin
4eb30f3925
Switch to the delegate pattern,
...
eliminating a nasty race condition and deleting a lot of code.
2015-06-09 15:34:09 +01:00
Michael Bolin
4330c3a181
Fix some nits I found during my self-review.
2015-06-09 15:34:08 +01:00
Michael Bolin
7294e0cda4
Change DirectorySearcher to return a DirectorySearch.
2015-06-09 15:34:08 +01:00
Michael Bolin
986640f670
Respond to comments from @maxbrunsfeld and @kevinsawicki.
2015-06-09 15:34:08 +01:00
Michael Bolin
7781e34ba2
Introduce atom.directory-searcher service v0.1.0.
...
The contract for a provider for the `atom.directory-searcher` service
is defined by the spec of the `DefaultDirectorySearcher`.
This modifies `Workspace::scan()` to use the appropriate `DirectorySearcher`
for each member of `atom.project.getDirectories()` when scanning the workspace
for files that match the specified regex.
2015-06-09 15:34:08 +01:00
Nathan Sobo
5c57cb0cfe
Show a warning prompt when opening files over 20MB
...
We still have some trouble on files this large. I want to show a
progress bar, but for now this is better than freezing without any
warning at all.
2015-06-09 00:02:36 +02:00
Thomas Johansen
fbf58d0725
📝 Remove mention of WorkspaceView which no longer exists
...
Fixes #7146
2015-06-07 09:30:10 +02:00
Machiste Quintana
c5a8c8ad34
🐛 Fix application:open-license command
2015-05-22 22:05:04 -04:00
Machiste Quintana
a76205256d
Only need oldValue
2015-04-28 23:09:31 -04:00
Machiste Quintana
2bd7cc9a99
Reset font size if editor.fontSize is changed from anywhere
2015-04-28 22:58:35 -04:00
Machiste Quintana
12b59cf610
Only reset font size if font size has been changed
2015-04-28 06:27:03 -04:00
Machiste Quintana
f4b228c908
Reset font size to window's starting font size
2015-04-28 06:27:03 -04:00
Ivan Zuzak
02070165e4
Move Grim deprecation calls to correctly attribute them with packages
2015-04-22 15:40:56 +02:00
Ivan Zuzak
74a627d41b
Merge pull request #6005 from vegar/patch-1
...
Documentation: workspace.open( ) with no URI
2015-04-09 15:40:01 +02:00
Ivan Zuzak
b8fb2f4d11
Clarify that URIs don't need to be files
2015-04-09 15:38:48 +02:00
Kevin Sawicki
4160a8c239
Merge pull request #6230 from mnquintana/coffeelint-plus
...
Lint for more styleguide errors
2015-04-08 12:07:23 -07:00
Kevin Sawicki
2aaf1fffe6
Move stack trace helpers into deprecation block
2015-04-07 09:51:16 -07:00
Machiste Quintana
5d2392ea67
👕 Fix new coffeelint errors
2015-04-06 23:59:54 -04:00
Kevin Sawicki
39a7af1f24
Remove theorist require
2015-04-06 11:23:09 -07:00
Kevin Sawicki
e8e1500d11
Use new Model superclass in Workspace
2015-04-06 11:22:51 -07:00
Kevin Sawicki
7d592c8b78
includeDeprecations -> includeDeprecatedAPIs
2015-04-03 11:29:16 -07:00
Kevin Sawicki
9e90426841
Only do legacy emit when including deprecations
2015-04-03 11:29:14 -07:00
Kevin Sawicki
382974412f
Conditionally include deprecations in Workspace
2015-04-03 11:29:13 -07:00
Vegar Vikan
4cf34cc1fa
Documentation: workspace.open( ) refrasing
2015-04-01 00:21:59 +02:00
Kevin Sawicki
a9803d3c4d
Add explicit return after for loop
2015-03-19 11:48:40 -07:00
vegar
fec8ea4272
Documentation: workspace.open( ) with no URI
...
I just learned that [calling open on workspace](https://discuss.atom.io/t/how-can-we-help-you-write-packages/4268/67 ) without specifying an uri is the way to go for getting a new tab with a new document.
I can't find anything about this in either the docs or the [api documentation.](https://atom.io/docs/api/v0.187.0/Workspace#instance-open )
Should `uri` be marked optional, like the `options` params? And should it be added a line stating that no uri opens a blank editor?
(and there's an extra `a` in the title..)
2015-03-17 20:09:37 +01:00
Max Brunsfeld
224803c25f
Use the right project path for document title
2015-02-24 16:06:59 -08:00
Max Brunsfeld
cbefdd6c5e
Make Workspace::scan work w/ multiple root directories
2015-02-24 14:22:39 -08:00
Ben Ogle
4a20dc9079
Return items from the opener, rather than using open
...
This way, options like `split: ‘left’` can be used with the config
URIs.
2015-02-12 10:43:35 -08:00
Kevin Sawicki
477801ba52
Remove save error reporting from Workspace
2015-02-05 14:43:50 -08:00
Kevin Sawicki
fd1d872840
Prompt split editors to save on close
...
Previously an editor that was split into multiple panes would not
prompt to save correctly when the window was unloading.
This adds a new `windowCloseRequested` option passed through from the
beforeunload handler to the editor so that it can specially handle this
case.
Closes #5257
2015-02-04 17:14:46 -08:00
Ben Ogle
db49d4da31
Merge pull request #5157 from postcasio/da-handle-erofs
...
Handle EROFS errors when saving
2015-01-20 15:39:19 -08:00
postcasio
867f920329
Handle EROFS errors when saving
2015-01-20 09:56:00 +00:00
Scott Fleckenstein
d263205a9a
📝 Fix typo in addOpener doc
2015-01-16 18:39:54 -08:00
Ben Ogle
828b841f17
Roll two whens into one
2015-01-16 11:24:24 -08:00
Ben Ogle
11bda1b47a
Add error handling for EBUSY as well
2015-01-16 11:07:32 -08:00
