Nathan Sobo
fe7a9ed419
Fix unset keystroke handling, 🎨
2016-09-15 14:15:41 -06:00
Nathan Sobo
a6094d2ed0
Don't allow menu shortcuts that could conflict with AltGraph characters
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2016-09-15 14:08:35 -06:00
Leo Lamprecht
0ceacf5c13
OSX -> macOS
2016-06-20 11:29:10 +02:00
Cheng Zhao
1725b9bf54
Use require('electron')
2015-12-11 09:30:58 +08:00
Wliu
fec1507ff4
Require ipc-renderer where it belongs
2015-11-18 21:10:40 -05:00
Wliu
6cd480b37e
Fix Electron deprecations
2015-11-17 21:16:09 -05:00
Max Brunsfeld
9664d34750
Reset MenuManager in AtomEnvironment::reset
2015-10-08 11:56:12 -07:00
Nathan Sobo
ee270db7ac
Move document mutation to startEditorWindow
2015-10-07 15:24:53 -05:00
Nathan Sobo
35c2ccd508
Build MenuManager in Atom environment constructor
2015-10-07 15:24:52 -05:00
Nathan Sobo
447dfd8bec
If a keystroke is bound to ‘unset!’, omit it in the application menu
...
Fixes atom/atom-keymap#79
This is more general than I would like. If the keystroke is unset in
any context, we err on the side of caution and don’t add it to the
application menu for any command. Since our application menu isn’t
context aware, this should be good enough for now and solve the 80%
case. Someday we should make the application menu update / gray out
options when the focused element changes.
2015-05-28 22:59:10 +02:00
Kevin Sawicki
4160a8c239
Merge pull request #6230 from mnquintana/coffeelint-plus
...
Lint for more styleguide errors
2015-04-08 12:07:23 -07:00
Kevin Sawicki
80787ef1e2
Remove try/catch around package.json requiring
...
No other requires are ever guarded against and the package.json should
be assumed to be valid JSON.
2015-04-08 09:30:40 -07:00
Kevin Sawicki
83541c01b5
Pull out menu property from _atomMenu
2015-04-08 09:16:55 -07:00
Kevin Sawicki
4b8bb9e1d9
platformMenuPath -> platformMenu
2015-04-08 09:16:55 -07:00
Kevin Sawicki
d30b61f7c9
Load platform menu from package.json
2015-04-08 09:16:55 -07:00
Machiste Quintana
5d2392ea67
👕 Fix new coffeelint errors
2015-04-06 23:59:54 -04:00
Kevin Sawicki
ac1cc87037
Use custom document to create test elements
2015-02-09 09:35:38 -08:00
Kevin Sawicki
784cd96bd0
Use custom elements when checking menu selectors
...
Closes #5462
2015-02-09 09:22:19 -08:00
Cheng Zhao
93181d8a54
Array::find is undefined in Chrome 40
2015-01-28 14:06:14 -08:00
Nathan Sobo
010bd643c0
Rename onDidActivateAll -> onDidActivateInitialPackages
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Ben Ogle
f7f2f4497b
Add docs for cson format to menu manager
2015-01-06 16:51:15 -08:00
Nathan Sobo
1eb3d8bf99
Use ‘atom-text-editor’ custom tag name for TextEditorElement
2014-10-09 07:39:14 -07:00
Nathan Sobo
8941b97ed2
Use ‘atom-workspace’ custom tag name for WorkspaceElement
2014-10-09 07:39:14 -07:00
Kevin Sawicki
98d31a1d30
💄 Remove some lint
2014-10-02 17:54:23 -07:00
Nathan Sobo
504c4c7af6
Extract MenuHelpers from MenuManager for reuse by ContextMenuManager
2014-09-30 12:06:08 -06:00
Nathan Sobo
2f93032a37
Don’t add duplicate items to the same menu
2014-09-29 11:11:36 -06:00
Nathan Sobo
81a7f65832
📝 Update docs
2014-09-29 10:37:19 -06:00
Nathan Sobo
bbeb0b5919
Return disposables from MenuManager which can be used to remove menus
2014-09-29 10:34:50 -06:00
Ben Ogle
050ec6ca64
MenuManager is extended
2014-09-16 13:42:55 -07:00
Ben Ogle
70e1d14f96
Add KeymapManager::onDidLoadBundledKeymaps
2014-09-10 17:28:47 -07:00
Ben Ogle
229277f764
Add PackageManager::onDidActivateAll()
2014-09-09 15:03:45 -07:00
Ben Ogle
a296364e53
Fixup doc strings that don’t parse correctly
...
We can’t have a huge indent on the second line of a list item. Markdown
parses it as a code block. :(
2014-08-26 10:47:36 -07:00
Kevin Sawicki
0bca0810b9
📝 Convert MenuManager docs
2014-08-25 15:08:45 -07:00
Kevin Sawicki
a2eb4d9303
Keep Packages submenu sorted
...
This ensures packages are in a predictable order regardless of whether
they are bundled or installed to ~/.atom/packages
Closes #3155
2014-08-12 18:16:00 -07:00
Kevin Sawicki
628ea72943
Check if selector matches parents of test element
...
Previously a menu for a keybinding with a .workspace selector would not
display the shortcut because the selector wasn't matching the test editor
element directly.
Now the parent elements of the test editor are checked as well.
Closes #2089
2014-05-16 11:57:04 -07:00
Kevin Sawicki
fc2830bacb
Use div for test workspace element
2014-05-16 11:53:40 -07:00
Cheng Zhao
f48241bc5e
Use new IPC API of atom-shell.
2014-04-29 15:16:27 +08:00
Corey Johnson
a407b0107a
Remove deprecated call to keystroke
2014-04-18 10:43:27 -07:00
Kevin Sawicki
b328a69f50
Check that label exists when comparing to other items
...
Previously separators would be removed when merging menus that
contained multiple separators.
Refs atom/find-and-replace#159
2014-04-09 11:39:38 -07:00
Kevin Sawicki
b173fcdd59
Default workspace classes when array is empty
2014-04-02 16:42:25 -07:00
Cheng Zhao
271b104120
🐧 Fix normalized menu item label.
2014-04-02 14:26:10 +08:00
Nathan Sobo
65564e2012
Rename atom.keymap to atom.keymaps
2014-03-31 16:28:55 -06:00
Nathan Sobo
61e9befbe7
Favor the most recent matching binding when selecting app menu shortcuts
...
We sending every binding matching the `body` selector to the browser
process, but it only selects the first. Since we scan the bindings in
chronological order, we need to unshift bindings to the front of the
array so the most recently defined bindings are loaded first.
2014-03-21 10:42:04 -06:00
Kevin Sawicki
eb58ce7736
Return false on invalid selectors
2014-02-20 11:49:13 -08:00
Kevin Sawicki
fb73240654
Guard against non-existent .workspace element
2014-02-11 17:13:37 -08:00
Kevin Sawicki
29cbea4d50
📝 optional not option
2014-02-11 16:53:36 -08:00
Kevin Sawicki
8b1b3d237d
Init pendingUpdateOperation in ctor
2014-02-11 16:53:00 -08:00
Kevin Sawicki
7d7f208fc5
Add missing keybidings to menu
...
This was caused by the test element not simulating a div element
with the .workspace class.
2014-02-11 16:48:32 -08:00
Kevin Sawicki
f24389a45b
📝 doc parameters in menu-manager.coffee
2014-02-06 16:51:39 -08:00
Kevin Sawicki
967db1f7b8
Remove more empty Private: comment blocks
2014-02-06 11:21:03 -08:00
