Ash Wilson
c578cd2bfa
.type 👉 .action
2018-04-16 14:09:55 -04:00
Ash Wilson
a0c68ec70b
👕 restore missing break
2018-04-12 14:43:13 -04:00
Ash Wilson
48a622cc74
Increment the version of the readOnly serialization key
2018-04-12 14:23:17 -04:00
Ash Wilson
0c2f458497
Boolean logic, my old enemy
2018-04-12 14:13:38 -04:00
Ash Wilson
4e9544583b
Can't use the same name for the property and method
2018-04-12 14:07:17 -04:00
Ash Wilson
1def646e09
Return the property we're actually setting
2018-04-12 13:35:30 -04:00
Ash Wilson
1545768522
Derive the readonly attribute from model.isReadOnly()
2018-04-12 13:23:12 -04:00
Ash Wilson
6ee477a329
Disable the hidden input when the model is readOnly or keyboard disabled
2018-04-12 11:50:53 -04:00
Ash Wilson
0a48c3cece
Separate TextEditor keyboard enablement from readOnly state
2018-04-12 11:50:11 -04:00
Jason Rudolph
72b664dc88
📝 Document deprecation for undo option
...
Refs #16956
2018-04-05 19:55:05 -04:00
Matthew Dapena-Tretter
dfd3ba8c14
Defer component initialization until element is requested
...
This fixes the error snapshotting Docks described in #16864 .
2018-04-02 17:10:39 -07:00
Matthew Dapena-Tretter
5af205739d
Don't trigger dock handle drag enter event unless a known item is being dragged
...
This seems a little counterintuitive. How could a dragenter event fire
if nothing's being dragged? Well, if something's dragged into the
document (i.e. from the desktop or another window), a dragenter event
will be fired even though (as far as we're concerned), nothing is being
dragged. Rather than trying to handle this class of events specially in
the dock, we simply limit our listening to when something is being
dragged. Since we have a single source of truth for this information,
this should be resilient to future changes in logic.
2018-03-30 14:11:30 -07:00
David Wilson
31e9ddad1e
Merge pull request #16864 from atom/fb-mdt-etch-docks
...
Convert Dock class to Etch
2018-03-30 11:59:08 -07:00
Max Brunsfeld
e6abfd1f31
Remove duplicate command bindings for undo and redo
...
Co-authored-by: Nathan Sobo <nathan@github.com >
2018-03-29 16:50:38 -07:00
Ash Wilson
7ffe82c1cd
Special-casing \r breaks the word regexp
2018-03-29 15:06:06 -04:00
Ash Wilson
92f6ab599f
Pass Config file path to ApplicationDelegate call
2018-03-27 08:56:29 -04:00
Ash Wilson
34a93a9e66
Pass a configFilePath along with the user settings
2018-03-27 08:55:31 -04:00
Ash Wilson
ad8392b2f5
Accept a filePath in the set-user-settings IPC call
2018-03-27 08:55:07 -04:00
Ash Wilson
1342316e73
Maintain a global Map of ConfigFile instances
2018-03-27 08:54:37 -04:00
Ash Wilson
f927651e6e
Giant-ass try/finally block
2018-03-23 16:36:35 -04:00
Ash Wilson
c16287fbdd
Track Promises for URLs that are being opened asynchronously
2018-03-23 16:26:35 -04:00
Ash Wilson
9de8131731
Ditto for Selection methods
2018-03-21 14:30:18 -04:00
Ash Wilson
ebb7647903
Mutation methods are no-ops in production. Throw in dev or spec mode
2018-03-21 14:25:50 -04:00
Ash Wilson
82575f5b07
👕
2018-03-21 12:29:52 -04:00
Ash Wilson
8fee5f8fb2
Merge remote-tracking branch 'origin/master' into aw/no-really-read-only
2018-03-21 11:55:52 -04:00
Ash Wilson
d405039581
Pass {bypassReadOnly} to selection.cut()
2018-03-21 11:53:36 -04:00
Ash Wilson
71d12f3f2c
Guard Selection methods against read-only TextEditor modification
2018-03-21 11:53:20 -04:00
Ash Wilson
56a3f1bc41
Fill in missing ensureWritable() calls caught by the specs
2018-03-21 09:29:36 -04:00
t9md
b35cfaed20
Pass selectionsMarkerLayer on transact, undo and redo
...
To restore selections of change initiated editor on undo/redo.
2018-03-21 14:25:59 +09:00
Ash Wilson
1f866bd592
Add options.bypassReadOnly on methods that modify the underlying Buffer
2018-03-20 16:38:15 -04:00
Ash Wilson
427460552d
Don't register modifying commands for readonly TextEditors
2018-03-20 10:19:56 -04:00
Ash Wilson
08ca84e587
📝 Convert code samples to js
2018-03-20 09:37:47 -04:00
Antonio Scandurra
d5c74c7e7c
Merge pull request #16943 from atom/as-fix-subpixel-aa-when-soft-wrap-is-on
...
Clip cursor width when soft-wrap is on and cursor is at the end of a line
2018-03-20 10:01:43 +01:00
Landon Abney
e546190b1e
🐛 Fix documentation for the Config class
...
The parser that generates the documenation requires the comment for the
documentation to be immediately preceeding the class definition. As part
of the decaffeination process in #16593 a variable declaration was
placed between the class definition and it's documentaiton, causing the
parser to think there was none... and excluding it from the final
result.
Fixes #16955 .
2018-03-15 23:52:49 -07:00
Ash Wilson
ce1c15cbc5
Recognize .tsx source as Typescript
2018-03-13 08:24:02 -04:00
Antonio Scandurra
26837d65b4
Clip cursor width when soft-wrap is on and cursor is at the end of line
...
This prevents the parent tile from disabling sub-pixel anti-aliasing.
For some reason, adding `overflow: hidden` to the cursor container
element doesn't solve the issue, so we're adding this workaround
instead.
2018-03-13 12:04:35 +01:00
Antonio Scandurra
98f2fdecfe
Merge pull request #16926 from atom/fix-typo
...
Remove extra hyphen in option description
2018-03-12 18:25:29 +01:00
Lee Dohm
1c6b431bf8
Remove extra hyphen in option description
2018-03-10 09:15:47 -08:00
Philip Weiss
d7eff0ec55
Merge branch 'master' into fb-pw-simple-project-config
2018-03-09 14:06:14 -08:00
Philip Weiss
e14ffb9420
set default path inside of project.replace
2018-03-09 14:04:21 -08:00
Max Brunsfeld
a9fa57139a
Fix regression where config file was loaded in specs
2018-03-09 11:15:50 -08:00
Antonio Scandurra
e2c89b29c8
Merge pull request #16428 from ernesto28/resize-pane
...
Resize pane
2018-03-09 08:38:44 +01:00
Philip Weiss
9282f07d07
return correct contents when no config present
2018-03-08 22:00:51 -08:00
Philip Weiss
a31795e1f3
fix linting issues
2018-03-08 21:53:50 -08:00
Philip Weiss
9d3c91b150
fix more nits
2018-03-08 21:49:18 -08:00
Wliu
2e19cf4a7c
📝 [ci skip]
2018-03-07 15:32:40 -05:00
Matthew Dapena-Tretter
7315cf8159
Defer loading of PaneContainerElement to fix snapshotting
2018-03-06 15:45:29 -08:00
Matthew Dapena-Tretter
871da3e2e1
Remove JSX
2018-03-06 15:45:29 -08:00
Matthew Dapena-Tretter
113453a219
Convert Dock to an etch component
2018-03-06 15:45:29 -08:00
Philip Weiss
b4f9faba42
fix nits
2018-03-06 14:55:51 -08:00
