Kirill Nikitin
917b223c6c
merge conflict
2014-05-16 11:45:43 +04:00
Corey Johnson
25f5717ccf
Merge pull request #1971 from abe33/feature_proper_multiselections_copy_paste
...
Implements multiple selections clipboard paste
2014-05-12 11:10:37 -07:00
Kirill Nikitin
111b5d1fbe
💄 Deprecate backspaceToBeginningOf{Word,Line}
...
Rename functions `backspaceToBeginningOfWord` to `deleteToBeginningOfWord` and
`backspaceToBeginningOfLine to `deleteToBeginningOfLine`.
Rename commands `editor:backspace-to-beginning-of-word` to
`delete-to-beginning-of-word` and `editor:backspace-to-beginning-of-line` to
`editor:delete-to-beginning-of-line`.
Fix #1791
2014-05-12 02:50:20 +04:00
Nathan Sobo
dbd271f70a
Don't obscure last character of long lines with vertical scrollbar
...
This entailed quite a few changes to dial in scrollbars. The scrollbars
are now adjusted in size to account for the width of the opposite
scrollbar. If the width or height are not explicitly constrained and we
are scrollable in the opposite direction that is constrained, we account
for the width of the opposite scrollbar in assigning a natural height
or width based on the content.
2014-05-09 11:33:04 -06:00
Nathan Sobo
7b4bc16531
Fix specs that broke when accounting for horizontal scrollbar height
2014-05-09 11:33:03 -06:00
Nathan Sobo
e6df30e94c
Respect horizontal scrollbar when rendering the vertical, and vice versa
...
We set overflow to hidden in the opposite scroll direction only if we
can't actually scroll in that direction, causing the white square where
neither scrollbar overlaps to appear at the lower right corner.
2014-05-09 11:33:03 -06:00
abe33
75eb0182e9
💄 Use skinny arrow instead
2014-05-09 00:03:40 +02:00
Corey Johnson
a649d75ab8
Merge remote-tracking branch 'origin/master' into cj-tabs-be-weird
...
Conflicts:
package.json
2014-05-08 14:36:50 -07:00
Lee Dohm
9b49c2f987
📝 Some simple documentation fixes
2014-05-07 22:38:51 -07:00
probablycorey
6bb260140b
Don't use comment lines to determine soft/hard tabs.
...
Closes atom/language-php#24
Closes #1733
2014-05-07 12:18:05 -07:00
Pascal Borreli
7070ed8ae4
Fixed typos
2014-05-07 08:52:58 +01:00
abe33
4b7d982eb4
💄 Fix typo in pasteText method comments
2014-05-06 23:26:13 +02:00
abe33
fbabc6f455
Implements multiple selections clipboard paste
...
Includes:
- Passing the selection index in the `Editor::mutateSelectedText`
method callback
- Storing all the selections content on many calls of
`Selection::copy` with `maintainClipboard = true` in a metadata
`selections` array
- Handling clipboard with a `selections` metadata in
the`Editor::pasteText` method
2014-05-06 23:19:39 +02:00
Kevin Sawicki
27b02a7981
Add initialColumn options to Workspace::open
...
This options works similarly to the existing initialLine option
2014-04-30 16:07:26 -07:00
Corey Johnson
fa4b3c8dea
Merge pull request #1903 from atom/cj-add-deprecation-warning-to-specs
...
Remove all deprecated calls from core
2014-04-24 15:36:53 -07:00
Nathan Sobo
ad8bd98c9a
Don't overwrite the file-scoped path variable
2014-04-24 10:13:01 -06:00
Corey Johnson
c03dec2783
Merge remote-tracking branch 'origin/master' into cj-add-deprecation-warning-to-specs
2014-04-23 16:51:14 -07:00
Corey Johnson
42e91defb9
Rename getEofPosition to getEndPosition
2014-04-23 16:06:32 -07:00
Nathan Sobo
7fe0f5b445
Make parameter names explicit in delegators
2014-04-23 09:56:49 -06:00
Corey Johnson
a15bb260c0
Update call to TextBuffer::rangeForRow
2014-04-22 17:52:07 -07:00
Corey Johnson
6b833043db
Removed references to the isReversed option
2014-04-22 17:51:44 -07:00
Nathan Sobo
752aa9a8e9
Handle editor:page-up/down commands
2014-04-22 17:10:23 -06:00
Nathan Sobo
e4639281f8
Handle 'editor:scroll-to-cursor' command
...
Add Editor::scrollToCursorPosition in the model layer
2014-04-22 17:10:23 -06:00
Nathan Sobo
f53d489abb
Add DisplayBuffer::scrollToScreen/BufferPosition
...
Also add delegators in Editor and ReactEditorView
2014-04-22 17:10:23 -06:00
Nathan Sobo
f59a8f1e68
Return function arg's result from Editor::batchUpdates
2014-04-22 17:09:45 -06:00
Nathan Sobo
a0ff6f5325
Handle 'autoscroll' option in model when setting selected buffer range
2014-04-22 17:09:45 -06:00
Nathan Sobo
19a5269a5f
Remove metaprogrammed method delegators
2014-04-22 17:09:45 -06:00
Nathan Sobo
3a42346e5e
Pause cursor blink as part of the overall editor update
...
This ensures we don't perform two updates of the cursors component when
cursors move as part of a larger change, such as typing text.
2014-04-22 17:09:44 -06:00
Nathan Sobo
033db8997b
Batch updates when moving cursors
...
This ensures that updates associated with autoscroll and cursor movement
get combined.
2014-04-22 17:09:43 -06:00
Nathan Sobo
ddc677fb30
Batch multiple view updates with Editor::batchUpdates
2014-04-22 17:09:43 -06:00
Nathan Sobo
48d90e3dfc
Funnel cursor and selection updates through EditorComponent
2014-04-22 17:09:43 -06:00
Nathan Sobo
2517765821
Rename 'core.useNewEditor' to 'core.useReactEditor' and default to false
2014-04-22 17:09:41 -06:00
Nathan Sobo
4b9871fa13
Enable advanced scroll management only when editor is used by react view
...
This preserves the original behavior of the editor model with respect
to scroll position and autoscroll unless it's being used by the react
component, which flips the ::manageScrollPosition flag to true.
2014-04-22 17:09:41 -06:00
Nathan Sobo
9a3f8022ad
Add shims to get bracket matcher working
2014-04-22 17:09:40 -06:00
David Graham & Nathan Sobo
6997adece9
Associate TokenizedLines with an ::indentLevel
...
This can be used to render the appropriate number of indent guide spans
for empty lines.
2014-04-22 17:09:39 -06:00
Nathan Sobo
81233a696b
Set default horizontalScrollMargin
2014-04-22 17:09:38 -06:00
Nathan Sobo
171631d20f
Autoscroll cursors horizontally at the model layer
...
Still need to respect the horizontal scroll position in the editor view
2014-04-22 17:09:38 -06:00
Nathan Sobo
5c9a5cdc85
Emit 'cursors-moved' from editor when one or more cursors move
2014-04-22 17:09:37 -06:00
Nathan Sobo
af9355e4e6
Add Editor::getSelectedScreenRanges
2014-04-22 17:09:37 -06:00
Nathan Sobo
3a433f734c
Move the cursor on single click
2014-04-22 17:09:36 -06:00
Nathan Sobo
bad2cebd6e
Add Editor::setSelectedScreenRange
2014-04-22 17:09:04 -06:00
Nathan Sobo
e472d7b038
Add autoscrolling with react editor view
...
Its implemented in the model to restrict touching of the DOM.
2014-04-22 17:09:04 -06:00
Nathan Sobo
08bd03b706
Opt in to editor view only when core.useNewEditor is true
2014-04-22 17:09:04 -06:00
Nathan Sobo
5a8ca1ae66
Move screen-related properties to DisplayBuffer
...
Scroll positions, height, width, line height. We force update when one
of these observed properties changes.
2014-04-22 17:09:03 -06:00
Nathan Sobo
53cc5c9856
Base cursor x position on char widths stored in DisplayBuffer
...
Whenever new lines are added to the screen, we measure and store any
unseen scope/character combinations in the DisplayBuffer.
2014-04-22 17:09:03 -06:00
Nathan Sobo
48e2302ccb
Handle almost all editor commands in EditorComponent
2014-04-22 17:09:03 -06:00
Nathan Sobo
c4fdb54650
Update editor component when a visible selection is removed
2014-04-22 17:09:03 -06:00
Nathan Sobo
cc8ba2d679
Update the rendered lines when the screen lines change
2014-04-22 17:09:01 -06:00
Corey Johnson
1583271e2f
Use setTextInRange instead of change
2014-04-18 15:50:30 -07:00
Kevin Sawicki
0c01de350d
📝 Shorten and tweak comment
2014-04-17 18:23:40 -07:00