Ben Ogle
274ae6cd57
Use buffer.getPath not @getPath in project
...
😬
2015-01-14 16:15:53 -08:00
Ben Ogle
7d3fe78eed
Remove Pane require from workspace view specs
2015-01-14 16:15:53 -08:00
Ben Ogle
3dc908c5ff
Use eventType from pathwatcher's watch errors in messages
2015-01-14 16:15:53 -08:00
Ben Ogle
683203a9a1
Attempt to fix theme manager specs
...
They work for me!
2015-01-14 16:15:53 -08:00
Ben Ogle
3ec3c2b69d
Fix theme manager specs
2015-01-14 16:15:53 -08:00
Ben Ogle
1bc2248fc2
Fix config specs
2015-01-14 16:15:53 -08:00
Ben Ogle
4be793f465
Post notifications when the user’s sheet cannot be loaded / parsed
2015-01-14 16:15:53 -08:00
Ben Ogle
3454249b58
Allow ENOENT errors in project.open
2015-01-14 16:15:52 -08:00
Ben Ogle
cbd42ac20c
Don’t need the pane in workspace.open
2015-01-14 16:15:52 -08:00
Ben Ogle
b8efbedee1
Create a warning notification when buffer has a watch error
2015-01-14 16:15:52 -08:00
Ben Ogle
8435826e8a
Remove linter errors
2015-01-14 16:15:52 -08:00
Ben Ogle
16468eb65d
Move workspace specs to workspace.
2015-01-14 16:15:52 -08:00
Ben Ogle
d5e04e883e
Use the error.code and path in the error
2015-01-14 16:15:52 -08:00
Ben Ogle
c20d3a8182
Throw an error when the error is unhandled
2015-01-14 16:15:51 -08:00
Ben Ogle
ca1f66d197
Post a notification when the user cannot access a file
2015-01-14 16:15:51 -08:00
Ben Ogle
4138b95146
Remove unnecessary < chars. wtf
2015-01-14 16:15:51 -08:00
Ben Ogle
11d4222c9f
Handle error when opening a file that doesn’t exist
2015-01-14 16:15:51 -08:00
Ben Ogle
bc454f14e0
Add a warning notification for oversize file open
2015-01-14 16:15:51 -08:00
Nathan Sobo
e60a9e45f7
Display package name correctly for ::getUri deprecation warnings
...
We capture the package name during the call to ::addOpener and use it
if any open items have the deprecated ::getUri method.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-14 14:23:17 -07:00
Max Brunsfeld
0d5a707ffb
Fix folding with splits
...
Fixes #4099
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-01-14 09:43:20 -08:00
Kevin Sawicki
e693254913
Prevent form submits from changing the window URL
...
Refs atom/settings-view#341
2015-01-13 16:01:24 -08:00
Nathan Sobo
49cd3eb5da
Clear window.setTimeout mock before each spec
...
This fixes a failure in the keymap spec where we assert that setTimeout
hasn’t been called.
2015-01-13 10:17:48 -07:00
Nathan Sobo
7f8ab72f53
Capitalize initialisms
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 22:00:24 -08:00
Kevin Sawicki
640f8920fb
Fix bounds checking of alpha
2015-01-12 17:34:43 -08:00
Kevin Sawicki
44939a12a0
Validate color properties when set
2015-01-12 17:34:43 -08:00
Kevin Sawicki
b8822b32db
Only coerce strings and plain objects
2015-01-12 17:34:43 -08:00
Kevin Sawicki
8c39818670
Don't blow up when asking for schema at non-existent path
2015-01-12 17:34:43 -08:00
Kevin Sawicki
5a2c208804
Add specs with invalid objects
2015-01-12 17:34:43 -08:00
Kevin Sawicki
fc899f54cf
Add specs for setting with an object
2015-01-12 17:34:42 -08:00
Kevin Sawicki
b923b57bcc
Add specs for hsl and hsla colors
2015-01-12 17:34:42 -08:00
Kevin Sawicki
319ec244e1
Add spec for invalid values
2015-01-12 17:34:42 -08:00
Kevin Sawicki
1267a1e14e
Add spec for default color value
2015-01-12 17:34:42 -08:00
Kevin Sawicki
0411f1584c
Add color schema type
2015-01-12 17:34:42 -08:00
Nathan Sobo
dd80226c23
Revert "Handle addition/removal of ‘gutter-hidden’ attribute"
...
This reverts commit 6926236268 .
There seems to be some bug or timing issue that prevents the
attachedCallback from being called in all cases when the
attributeChangedCallback is defined. We can figure this out at
a later time.
2015-01-12 17:39:07 -07:00
Nathan Sobo
6926236268
Handle addition/removal of ‘gutter-hidden’ attribute
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Nathan Sobo
43f57347d7
Add ‘gutter-hidden’ attribute to TextEditorElement
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Nathan Sobo
c0b78db159
💄
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Nathan Sobo
002918049d
🐎 Cache gutterVisible state in React component
...
This avoids a config read on every render.
2015-01-12 16:21:31 -07:00
Nathan Sobo
f00b0b7f7a
Add TextEditor::set/isGutterVisible
...
Controls gutter visibility on individual editors.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Max Brunsfeld
174b7072b7
Add specs for Task events
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-01-09 16:59:13 -08:00
Lee Dohm
acb19c1fe1
Log scopes to notification instead of console
...
Fixes #4969
2015-01-09 16:33:48 -08:00
Nathan Sobo
d26c19a0ec
Deprecate Project::resolve
...
It’s not something that will make sense once we add the ability to have
multiple directories in a project. This adds a new private method on
Project, ::resolvePath, with the original implementation for convenience
until we actually implement multi-folder projects.
2015-01-09 15:03:07 -08:00
Max Brunsfeld
f9bde050b4
Handle TextEditorElement::focus() while parent is being attached
...
Fixes atom/autocomplete#61
2015-01-09 15:00:35 -08:00
Nathan Sobo
19bf64f3cd
Revert "Deprecate Project::resolve"
...
This reverts commit 3c5bd9f10a .
2015-01-09 13:58:01 -08:00
Nathan Sobo
3c5bd9f10a
Deprecate Project::resolve
...
It’s not something that will make sense once we add the ability to have
multiple directories in a project.
2015-01-09 13:40:35 -08:00
Nathan Sobo
0a5b4f9b33
Make “style sheet” two words in package.json metadata
...
Rename `stylesheets` -> `styleSheets`
Rename `stylesheetsMain` -> `mainStyleSheet`
2015-01-09 09:04:04 -08:00
Nathan Sobo
932d3755ce
Rename stylesheets/ directory in fixture packages
2015-01-09 08:56:12 -08:00
Nathan Sobo
37ba67728b
Fix core deprecations
2015-01-09 08:24:48 -08:00
Nathan Sobo
7f9d06f55b
Move TextEditor::pixelPositionForScreen/BufferPosition to view layer
...
It doesn’t make sense to talk about pixels at the model layer long-term,
even though we currently store view dimension information in the model
so we don’t have to read from the DOM for optimization purposes. This
information is only available if the view is attached, however, making
these methods a liability on the model layer.
2015-01-09 08:22:45 -08:00
Nathan Sobo
4ab33890fc
Add PackageManager::onDidLoad/UnloadPackage
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00