Nathan Sobo
9aae2bc4e7
Fix breakage caused by method rename
2012-05-16 14:12:05 -06:00
Nathan Sobo
92395a9cfb
Merge branch 'master' of github.com:github/atom
...
Conflicts:
src/app/editor.coffee
2012-05-16 14:07:44 -06:00
Nathan Sobo
2d8ba3b1ee
Use translate3d to scroll lines / gutter in attempt to improve repaint.
...
Also: Add custom scrollTop method to editor that manages all the custom optimizations we are doing around scrolling.
2012-05-16 13:47:59 -06:00
Corey Johnson
2c508f5a31
Fix tests
...
Certain tests resize the editor and expect the number of lines to adjust, this forces the test to meet that expectation.
2012-05-16 11:30:25 -07:00
Corey Johnson
3614ad6e76
Update lines when the font size changes
2012-05-16 10:58:19 -07:00
Corey Johnson
399fc71b3c
Make Atom SpacePen view's default to empty object (where needed)
2012-05-16 10:35:50 -07:00
Corey Johnson
484b55800a
Call updateLines when lines are removed from buffer
2012-05-15 14:27:22 -07:00
Corey Johnson
54a3823606
Buffer change events update the @lastRenderedScreenRow
2012-05-15 12:29:59 -07:00
Corey Johnson
6b3664a040
Vertical scrollbar height is updated when switching buffers
2012-05-15 10:02:56 -07:00
Corey Johnson & Nathan Sobo
78155de740
Un-F
2012-05-14 16:55:35 -06:00
Corey Johnson & Nathan Sobo
abc230eee3
Fix bug: file finder correctly focuses editor after opening a file.
2012-05-14 16:35:03 -06:00
Corey Johnson & Nathan Sobo
9079bcb103
Meta-a selects everything
2012-05-14 16:18:37 -06:00
Corey Johnson & Nathan Sobo
513e15e369
Make editor tall so that all line numbers are rendered for this test
2012-05-14 15:42:51 -06:00
Corey Johnson
b35a2502c6
Gutter line numbers are rendered similarly to the scroll view's lines
2012-05-14 12:32:53 -07:00
Corey Johnson
5e4aef95d0
Only visible lines numbers are rendered by the gutter
2012-05-14 09:53:58 -07:00
Nathan Sobo
f47abdead9
Merge branch 'render-visible'
2012-05-11 17:52:23 -06:00
Nathan Sobo
0c89db37a5
Editor scroll position is correctly restored on refresh.
...
When we attach the editor we need to scroll it to the correct position before rendering lines. But to scroll it to the right position, the lines container and the scrollbar need to be assigned a height that allows them to scroll. So now we call `prepareForVerticalScrolling` on attach, then set the scroll position based on the edit session and render the visible lines.
2012-05-11 17:51:47 -06:00
Corey Johnson & Nathan Sobo
af65bd785c
fix test failures
2012-05-11 16:06:42 -07:00
Corey Johnson & Nathan Sobo
d51b229d56
When the editor buffer changes and the path is not visible in the TreeView, It selects the closes ancestor entry of that file.
2012-05-11 15:44:18 -07:00
Corey Johnson & Nathan Sobo
2f86a3a6e5
TreeView starts with root being selected
2012-05-11 14:31:48 -07:00
Nathan Sobo
96d92be230
Rename Editor.scrollbar to verticalScrollbar for clarity
2012-05-11 13:45:57 -06:00
Nathan Sobo
b64e9ae10f
Rename Editor.scroller to Editor.scrollView to distinguish it from the vertical scrollbar.
...
Also, base edit session scroll top on the scrollbar instead of the scrollView.
2012-05-11 13:42:57 -06:00
Corey Johnson & Nathan Sobo
38582a22d3
These tests shall pass
2012-05-11 11:25:27 -07:00
Corey Johnson & Nathan Sobo
9427c82084
WIP: Getting specs passing with new stand-in vertical scrollbar
2012-05-11 11:52:03 -06:00
Corey Johnson & Nathan Sobo
02da32d372
Update visible lines when scrolling up
2012-05-10 16:11:05 -06:00
Corey Johnson & Nathan Sobo
43ac7edf0f
Scrolling to bottom renders correct lines
...
When we scroll more than a single screen's worth of lines, the new first visible screen row ends up exceeding the previous last rendered screen row, so we need to use the maximum of the two when deciding which new rows to render.
2012-05-10 15:15:34 -06:00
Corey Johnson & Nathan Sobo
c5d2616155
WIP: Removing lines that are no longer visible
2012-05-10 12:08:58 -07:00
Corey Johnson & Nathan Sobo
22548141d7
Editor updates lines when it is resized
2012-05-10 11:14:03 -07:00
Corey Johnson & Nathan Sobo
f6e9d99865
Editor only does not pre-build lines, it only builds them when they are visible on the screen
2012-05-10 10:40:16 -07:00
Corey Johnson & Nathan Sobo
6eda0d345b
💄
2012-05-10 08:58:38 -07:00
Nathan Sobo
1e2d333a15
WIP: working on only rendering on-screen lines. still half-baked.
2012-05-10 09:27:04 -06:00
Corey Johnson & Nathan Sobo
5ae40a3cb8
Editor only renders lines when it is attached to the DOM
2012-05-09 19:19:54 -06:00
Nathan Sobo
5b7ea95a11
Meta+ and meta- change the editor font size
2012-05-09 10:57:25 -06:00
Nathan Sobo
f2f44b9ab6
Can match key patterns with the '-' character
...
Add a parser to parse keystroke patterns instead of splitting on '-' with a regex
2012-05-09 10:56:31 -06:00
Nathan Sobo
8b1ac28b89
Editor font sizes can be adjusted with RootView.proto.setFontSize
2012-05-09 08:34:08 -06:00
Nathan Sobo
71d80470ca
Remove console.log
2012-05-09 08:33:34 -06:00
Nathan Sobo
6dda27e771
Go ahead and build a RootView in the editor spec
2012-05-08 20:20:56 -06:00
Nathan Sobo
dc4529887a
File finder detaches itself when it loses focus
2012-05-08 20:07:49 -06:00
Corey Johnson & Nathan Sobo
4665321b37
Project.getFilePaths does not traverse into ignored directories
2012-05-08 17:59:38 -07:00
Corey Johnson & Nathan Sobo
289193787e
Add fs.traverseTree
2012-05-08 17:45:29 -07:00
Corey Johnson
d35efb6241
When FileFinder is canceled, it refocuses previously focused element
2012-05-08 15:35:01 -07:00
Corey Johnson
bc3b982514
Rename fileFinder.editor to fileFinder.miniEditor
2012-05-08 15:09:19 -07:00
Nathan Sobo
897f505e4f
Meta-/ (tree-view:toggle) attaches / detaches the TreeView
2012-05-08 15:35:03 -06:00
Nathan Sobo
79315b0ef6
Merge branch 'master' of github.com:github/atom
...
Conflicts:
static/command-panel.css
2012-05-08 15:11:27 -06:00
Nathan Sobo
d181cdedbd
Handle errors when attempting to add a file from the TreeView
2012-05-08 15:08:15 -06:00
Corey Johnson
77baa7be09
Extract command panel as an extension
2012-05-08 13:49:06 -07:00
Nathan Sobo
a59c96d3a9
Flash red and show an error message when there's an error on moving a file
2012-05-08 14:18:21 -06:00
Corey Johnson
cb45675f14
Remove @path var from project
2012-05-08 13:02:14 -07:00
Corey Johnson
545671a641
fs.isFile(path) returns false if given path does not exist
2012-05-08 13:02:14 -07:00
Nathan Sobo
b528196d1b
Refactor AddDialog and MoveDialog into a single Dialog class
2012-05-08 13:16:52 -06:00
