Antonio Scandurra
751f5920b4
🎨
2015-09-17 10:50:18 +02:00
Antonio Scandurra
c6948b36dc
Clear pool after updating
2015-09-17 10:38:40 +02:00
Antonio Scandurra
8b52538213
Pool highlight elements
2015-09-17 10:35:20 +02:00
Max Brunsfeld
f79b3abe3f
Avoid incorrect character replacement when initially typing in text-editor
...
It seems that chrome now automatically selects all text in an input element
when its containing shadow root gains focus, as if it had been reached by
typing tab. Setting the input's tabindex to -1 prevents this behavior.
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-09-16 13:41:16 -07:00
Antonio Scandurra
bae4d7d336
🔥
2015-09-16 17:59:04 +02:00
Antonio Scandurra
2542a8d603
Integrate LinesYardstick with TextEditorComponent
2015-09-16 12:32:26 +02:00
Antonio Scandurra
2dd944f3ee
Trigger ::onWillMeasure before measuring anything
2015-09-16 12:07:57 +02:00
Antonio Scandurra
2750a384ac
💚 Fix TextEditorPresenter specs
...
...so that they play nicely with LinesYardstick
2015-09-16 11:33:51 +02:00
Antonio Scandurra
29846d0a51
Add LinesYardstick
...
...and create a MockLineNodesProvider for testing purposes
2015-09-15 18:41:41 +02:00
Antonio Scandurra
398fb1f62d
🔥 Avoid mounting the container in ctor
...
...as it will be mounted anyways when updateSync gets called
2015-09-15 17:50:21 +02:00
Antonio Scandurra
346c7d9b37
Defer state building in TextEditorPresenter
2015-09-15 17:44:31 +02:00
Antonio Scandurra
1cdc7ae5a0
Decouple horizontal dimensions computation from vertical ones
...
The former needs measurement and, therefore, depends on the latter.
2015-09-15 17:30:47 +02:00
Antonio Scandurra
578b157da0
Differentiate between gutter and lines tiles
...
...and fix specs as well. 💚
2015-09-15 17:22:22 +02:00
Antonio Scandurra
a6c13d097a
Render the longest screen row without painting it
2015-09-15 16:53:55 +02:00
Antonio Scandurra
8e06e06899
Compute the state for the longest line on screen
2015-09-15 16:32:42 +02:00
Antonio Scandurra
4c5101a7e1
🎨 Refactor ::updateTilesState to a composed method
2015-09-15 15:44:06 +02:00
Antonio Scandurra
f8868ffcf2
Clear dataset elements for pooled objects
2015-09-15 12:23:53 +02:00
Antonio Scandurra
ad83a03440
Merge branch 'master' into as-recycle-nodes
...
# Conflicts:
# src/line-numbers-tile-component.coffee
# src/lines-tile-component.coffee
2015-09-15 11:50:54 +02:00
Antonio Scandurra
c7d4871453
Merge pull request #8730 from atom/as-faster-style-recalculation
...
Faster Style Recalculations
2015-09-15 11:25:10 +02:00
Antonio Scandurra
daf4316974
Clear the pool when font or lineHeight change
2015-09-15 10:59:32 +02:00
Antonio Scandurra
f86c9b2331
Let TextEditorComponent manage DOMElementPool
2015-09-15 10:58:24 +02:00
Antonio Scandurra
c8c69a99b9
Release free nodes after destroying TextEditor
2015-09-15 10:36:47 +02:00
Antonio Scandurra
ce4281821d
Replace insertAdjacentText with textContent
2015-09-14 20:31:21 +02:00
Antonio Scandurra
663de4c8d6
Use textContent instead of innerText
2015-09-14 20:28:09 +02:00
Antonio Scandurra
f0bc6ca23a
🎨 Some renaming
2015-09-14 20:27:25 +02:00
Antonio Scandurra
e9bf04b50b
Guard against some edge cases
2015-09-14 20:21:37 +02:00
Antonio Scandurra
4349b152d5
🎨
2015-09-14 18:22:31 +02:00
Antonio Scandurra
f52e000bec
🔥 Remove unused code
2015-09-14 18:14:12 +02:00
Antonio Scandurra
536a5f4395
🐎 Save an allocation while removing nodes
2015-09-14 17:44:57 +02:00
Antonio Scandurra
6b2e7a6765
🎨
2015-09-14 17:36:45 +02:00
Antonio Scandurra
93ed0853a2
Recycle gutter nodes
2015-09-14 17:25:30 +02:00
Antonio Scandurra
ece15b2a24
Recycle tile nodes (and descendants)
2015-09-14 14:48:30 +02:00
Antonio Scandurra
ccb8623a88
🎨 Extract a buildElement helper function
2015-09-14 12:01:33 +02:00
Antonio Scandurra
9af7795a7e
Avoid skipping null bytes
...
Now that we build DOM nodes via `document.createElement`, there's no need to
skip null byte characters (nor to avoid to pair them) because the browser will
keep them in the document (unlike `innerHTML`).
2015-09-14 11:45:29 +02:00
Antonio Scandurra
a44f7116a2
Start building nodes via document.createElement
2015-09-14 11:34:13 +02:00
Antonio Scandurra
de0b61393c
Minimize allocations
2015-09-14 10:57:59 +02:00
Nathan Sobo
c0a4987e66
🎨
2015-09-10 10:16:38 -07:00
Nathan Sobo
eaeed3c892
🙈 Actually push scopeName
2015-09-10 10:16:38 -07:00
Nathan Sobo
c1d4f3f1a0
🎨 Only pop from scopeStarts if top of stack matches ending scope
2015-09-10 10:16:38 -07:00
Indrek Ardel
bb11d13fe3
Fix typo
2015-09-10 10:16:37 -07:00
Indrek Ardel
e1b984820d
Pop scope from the top of scopeStarts directly
2015-09-10 10:16:37 -07:00
Antonio Scandurra
9a431a5c97
💚
2015-09-10 18:06:18 +02:00
Lee Dohm
cd1134bd3e
Merge pull request #8672 from fedorov/clarify-addOpener-usage
...
Add a clarification about the usage of addOpener
2015-09-10 07:59:07 -07:00
Antonio Scandurra
326a035835
🐎 Decrease tile size to make finer grained updates
2015-09-10 16:19:33 +02:00
Max Brunsfeld
f56dde9c91
Setup browser-process exception handler before requiring anything
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-09-09 11:57:54 -07:00
Antonio Scandurra
493df95294
Merge branch 'master' into as-faster-style-recalculation
2015-09-09 20:53:58 +02:00
Antonio Scandurra
6c69f430f3
🔥 Remove z-index
2015-09-09 16:12:09 +02:00
Antonio Scandurra
47fb48b514
🐛 Correct boolean logic
2015-09-09 14:29:57 +02:00
Antonio Scandurra
246476f759
🎨
2015-09-09 14:26:47 +02:00
Antonio Scandurra
fe039a0f3c
💚
2015-09-09 13:31:34 +02:00
