Jess Lin
af629f8416
[Gutter] Remove check for null decorationState in CustomGutterComponent
2015-04-22 07:28:59 -07:00
Jess Lin
85188ced03
[Gutter] Move 'lineNumberGutter' state to nest under 'gutters' in the presenter state
2015-04-22 07:28:59 -07:00
Jess Lin
79b460a0ca
[Gutter] Add ::getDomNode method to all 'components'
2015-04-22 07:28:59 -07:00
Jess Lin
5dfa6b3e1e
[Gutter] Remove test-only CSS
2015-04-22 07:28:59 -07:00
Jess Lin
8c4d092767
[Gutter] TextEditorPresenter tests for custom gutter decorations
2015-04-22 07:28:59 -07:00
Jess Lin
93d7b47b79
[Gutter][refactor] Simplify TextEditorPresenter::updateCustomGutterDecorationState (Pass 2)
2015-04-22 07:28:58 -07:00
Jess Lin
14e5d38354
[Gutter] TextEditorPresenter: Consolidate common gutter state under @state.gutters
2015-04-22 07:28:58 -07:00
Jess Lin
d54e48699b
[Gutter] Don't bother updating custom gutter decorations if editor is mini
2015-04-22 07:28:58 -07:00
Jess Lin
f62a27cfef
[Gutter][DOM Persistence] Clear the decorations of a gutter node if it is not visible
2015-04-22 07:28:58 -07:00
Jess Lin
d78dfd86bf
[Gutter][refactor] Simplify TextEditorPresenter::updateCustomGutterDecorationState
2015-04-22 07:28:58 -07:00
Jess Lin
34856d94f5
[Gutter][DOM Persistence] Keep a gutter in the DOM if it is merely hidden (not destroyed)
2015-04-22 07:28:58 -07:00
Jess Lin
0d7f89467f
[Gutter][DOM Persistence] Add ::hideNode and ::showNode to GutterComponent classes
2015-04-22 07:28:58 -07:00
Jess Lin
66f1f33861
[Gutter][View Registry] Make LineNumber- and Custom- GutterComponent get their view from the ViewRegistry
2015-04-22 07:28:58 -07:00
Jess Lin
6319c9722a
[Gutter][View Registry] Add Gutter view providers to the ViewRegistry
2015-04-22 07:28:58 -07:00
Jess Lin
f3d2597bda
[Gutter][View Registry] Make the Presenter pass sorted Gutter models instead of sorted derived state
2015-04-22 07:28:58 -07:00
Jess Lin
d2914bc73c
[Gutter] Make the GutterContainerComponent able to create custom gutters
2015-04-22 07:28:58 -07:00
Jess Lin
e2e737369a
[Gutter] Factor out method to set common gutter component properties
2015-04-22 07:28:58 -07:00
Jess Lin
7f1b0588f9
[Gutter] Create CustomGutterComponent
2015-04-22 07:28:58 -07:00
Jess Lin
d734ffe545
[Gutter] Make TextEditorPresenter recognize Decorations for custom gutters
2015-04-22 07:28:58 -07:00
Jess Lin
8d6745d8a9
[Gutter] Replace GutterComponent with GutterContainerComponent in TextEditorComponent
2015-04-22 07:28:57 -07:00
Jess Lin
ce1d64f550
[Gutter] Create GutterContainerComponent
2015-04-22 07:28:57 -07:00
Jess Lin
754b38f410
[Gutter] Add ::getDomNode to LineNumberGutterComponent
2015-04-22 07:28:57 -07:00
Jess Lin
28f70c912e
[Gutter] Add ::getName to LineNumberGutterComponent
2015-04-22 07:28:57 -07:00
Jess Lin
b4ffa04e4c
[Gutter] Rename GutterComponent to LineNumberGutterComponent
2015-04-22 07:28:57 -07:00
Jess Lin
a96a790bda
[Gutter] Remove unused param 'presenter' from GutterComponent constructor
2015-04-22 07:28:57 -07:00
Jess Lin
d03e9e16b9
[Gutter] Make TextEditorPresenter aware of custom gutters (no decorations yet)
2015-04-22 07:28:57 -07:00
Jess Lin
7582e98f4c
[Gutter] TextEditorPresenter: rename @state.gutter -> @state.lineNumberGutter
2015-04-22 07:28:57 -07:00
Jess Lin
ecdf324e62
[Gutter] TextEditorPresenter: rename updateGutterState -> updateLineNumberGutterState
2015-04-22 07:28:57 -07:00
Jess Lin
cc89f972dc
[Gutter][style] Add parentheses to some method calls for readability
2015-04-22 07:28:57 -07:00
Jess Lin
ee7625249f
[Gutter] Create event subscription methods for gutter changes
2015-04-22 07:28:57 -07:00
Jess Lin
b361e1719c
[Gutter] Add decorateMarker method to Gutter model
2015-04-22 07:28:57 -07:00
Jess Lin
58d6712b0e
[Gutter] Augment Decoration to discern the line-number gutter from custom gutters
2015-04-22 07:28:57 -07:00
Jess Lin
eb321a64c1
[Gutter] Create a line-numbers Gutter on each TextEditor
2015-04-22 07:28:56 -07:00
Jess Lin
20d3c07bf5
[Gutter] Add add/get Gutter methods to TextEditor
2015-04-22 07:28:56 -07:00
Jess Lin
fccc9ebee4
[Gutter] Rename current references to 'Gutter' -> 'LineNumberGutter'
2015-04-22 07:28:56 -07:00
Jess Lin
a6efa104db
[Gutter] Don't allow the 'line-number' gutter to be destroyed
2015-04-22 07:28:56 -07:00
Jess Lin
94a0bf3f90
[Gutter] Create Gutter and GutterContainer w/ API to hide/show
2015-04-22 07:28:56 -07:00
Ivan Zuzak
02070165e4
Move Grim deprecation calls to correctly attribute them with packages
2015-04-22 15:40:56 +02:00
Michael Bolin
bf9999d07a
core:select-up/down should work in mini editor as well as main editor.
...
Fixes #6445 .
2015-04-21 12:50:20 -07:00
bolinfest
9721e1306f
Merge pull request #6446 from atom/bf-bump-babel-5.1.11
...
⬆️ babel-core@5.1.11
2015-04-21 11:31:53 -07:00
Nathan Sobo
76a919f8b4
Perform document updates in same frame when requested from reads
...
A common pattern is to put something on the DOM, measure it, then update
the DOM again based on that measurement. This change ensures that any
updates requested as a result of reading from the DOM get scheduled for
the end of the current frame. If you want to read *again* after these
follow-on updates, you will need to wait for the next frame. But at
least this way we ensure instant feedback with minimal thrashing
(1 reflow) when we have no choice but to read the DOM before updating.
/cc @benogle
2015-04-20 22:01:36 -06:00
Michael Bolin
88b6db8ac7
Bump babel-core from 4.0.2 to 5.1.11.
...
Notable new features from the [https://github.com/babel/babel/blob/master/CHANGELOG.md ](changelog):
* Add [trailing function comma proposal](https://github.com/jeffmo/es-trailing-function-commas ).
* Decorators based on [@wycat's stage 1 proposal](https://github.com/wycats ).
There is a number of bug fixes and performance improvements, as well.
2015-04-20 15:48:45 -07:00
Nathan Sobo
d1c44dcb54
Never load config settings from disk when a save is pending
...
Fixes #5771
We load the user’s settings from disk when we detect a change to their
config.cson file. However, if there’s a save pending, doing this will
end up blowing away the values we intend to save.
2015-04-20 12:12:05 -06:00
vvakame
d02a67f5bb
📝 improves document consistency
2015-04-19 11:39:19 +09:00
Kevin Sawicki
edbcf4023e
Add back accidentally deleted resolve call
2015-04-16 14:57:11 -07:00
Kevin Sawicki
f1d90570b6
Check grammars/settings paths before reading
...
asar seems to create and throw errors synchronously when these
do not exist and fs.readdir is called.
2015-04-16 14:57:11 -07:00
Max Brunsfeld
356bb7ce0f
Don't rethrow exceptions from reading state files
...
They block startup.
2015-04-15 16:53:45 -07:00
Kevin Sawicki
2c5655b7d2
Remove unused requires
2015-04-15 15:55:31 -07:00
Kevin Sawicki
e6a49c4531
Remove unused resource path
2015-04-15 15:55:31 -07:00
Kevin Sawicki
8e5323d154
apm is back in app folder
2015-04-15 15:55:30 -07:00
