Michelle Tilley
9c6a87199e
Merge branch 'mkt-core-uri-handlers' of github.com:atom/atom into mkt-core-uri-handlers
2017-10-19 14:19:32 -07:00
Michelle Tilley
158622ce48
Convert array of windows in AtomApplication to a WindowStack
2017-10-19 14:19:24 -07:00
Michelle Tilley
2901a484c2
👕
2017-10-18 17:34:24 -07:00
Michelle Tilley
a11efa7376
Add core URI handlers
2017-10-18 16:00:37 -07:00
Antonio Scandurra
280253fdfa
Merge pull request #15916 from atom/as-jr-stop-dragging-when-interacting-with-keyboard
...
Stop dragging only when user interacts with keyboard
2017-10-18 11:38:52 +02:00
Michelle Tilley
d6a3a60469
Merge pull request #11399 from atom/mkt-url-based-command-dispatch
...
Package URL handlers - mapping atom:// URIs to package functions
2017-10-17 16:29:27 -07:00
Michelle Tilley
5bbf0b6ade
🎨 package activation
2017-10-17 15:37:49 -07:00
Michelle Tilley
8b989ffc4e
More url -> URI
2017-10-17 15:29:27 -07:00
Michelle Tilley
9b5f95a14d
openWithAtomUrl -> openPackageUriHandler
2017-10-17 15:26:29 -07:00
Michelle Tilley
5e43084cd3
url -> URI
2017-10-17 15:23:10 -07:00
Michelle Tilley
e02337265a
Reset history when destroying UrlHandlerRegistry
2017-10-17 14:42:11 -07:00
Michelle Tilley
2504118d8b
⌨️ fix typo
2017-10-17 14:42:00 -07:00
Michelle Tilley
2b70f57405
🎨 return undefined
2017-10-17 14:41:50 -07:00
Michelle Tilley
7aa79bc3a1
Unregister package URL handlers when deactivating
2017-10-17 12:59:21 -07:00
anon
894f5471e6
textChange(CoreSettings): remove redundancy
2017-10-18 22:09:11 +02:00
Michelle Tilley
5e96429c9e
Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch
2017-10-17 11:18:02 -07:00
Antonio Scandurra
65af9e953b
Stop dragging only when user interacts with keyboard
...
Previously, we used to prevent the user from dragging the selection
further when the buffer was about to change. This was problematic
because any change in the buffer, even one that was performed
"automatically" by a package, would cancel the dragging action and
result in a confusing experience for the user.
On the other hand, we want to prevent users from accidentally selecting
text when they perform an edit (see #15217 , #15405 ).
This commit addresses both concerns by canceling the dragging as soon as
the user interacts with the keyboard, instead of canceling the dragging
when the buffer is about to change.
One downside of this approach is that it changes the behavior of
pressing a keystroke that does not result in a buffer change, e.g.
Shift, Arrow Keys, etc.
Signed-off-by: Jason Rudolph <jasonrudolph@github.com >
2017-10-17 18:50:20 +02:00
Jason Rudolph
274b809b12
Merge pull request #15898 from atom/decaf-project
...
Decaffeinate `src/project.coffee`
2017-10-16 21:23:14 -04:00
Jason Rudolph
a4ea46c57e
Rename local variable
...
/xref: https://github.com/atom/atom/pull/15898#discussion_r144850427
2017-10-16 11:04:56 -04:00
Jason Rudolph
5ec9d0f134
🐛 Fix bug disposing watchers in Project::addPath
...
`this.rootDirectories` is an Array of Directory objects. `path` is a
String. Therefore, `this.rootDirectories.includes(path)` will always
evaluate to `false`. We instead need to look for an entry in
`this.rootDirectories` where the Directory object's path is equal to the
given path.
2017-10-15 10:00:14 -04:00
Jason Rudolph
5937b95b49
Fix loop contructs that got borked by decaffeinate
2017-10-15 10:00:02 -04:00
Jason Rudolph
790e202549
🎨
2017-10-15 10:00:02 -04:00
Jason Rudolph
8df4cfbe58
🎨
2017-10-15 10:00:02 -04:00
Jason Rudolph
48625584e4
🎨 Use shorter variations of null checks
2017-10-15 10:00:02 -04:00
Jason Rudolph
b2571e8976
Avoid inline assignments
2017-10-15 10:00:02 -04:00
Jason Rudolph
99aaafed1b
DS103: Rewrite code to no longer use __guard__
2017-10-15 10:00:02 -04:00
Jason Rudolph
94a552149d
Remove unnecessary use of Array.from
2017-10-15 10:00:01 -04:00
Jason Rudolph
c1b0afe969
Remove unnecessary code created because of implicit returns
2017-10-15 10:00:01 -04:00
Justin Ratner
0c35c26805
fix infinite overlay resizing loop
2017-10-14 19:05:54 -06:00
Jason Rudolph
8f40af16a9
🎨
2017-10-14 17:07:09 -04:00
Jason Rudolph
dd6359b507
Remove Babel/TypeScript constructor workaround
2017-10-14 12:47:19 -04:00
Jason Rudolph
cab8824aae
👔 Fix linter violations
2017-10-14 12:47:00 -04:00
Jason Rudolph
25b7ddb328
☠️ ☕ Decaffeinate src/project.coffee
...
Apply results of running:
```
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes'
$ standard --fix src/project.js
```
2017-10-14 11:58:47 -04:00
Justin Ratner
ae65b49b9b
fix lint errors
2017-10-12 23:46:53 -06:00
Justin Ratner
763297df82
decaffeinate decoration.coffee
2017-10-12 21:26:52 -06:00
Antonio Scandurra
7853e3cd8c
Don't throw when destroying block decorations inside marker change event
2017-10-11 09:42:53 +02:00
Jason Rudolph
dec47761f9
Merge pull request #15838 from atom/jr-decaf-grammar-registry
...
Decaffeinate `GrammarRegistry`
2017-10-10 07:14:03 -04:00
Max Brunsfeld
87d38c0a4d
Return a Point from cursor word methods
...
Fixes #15847
2017-10-09 12:23:55 -07:00
Jason Rudolph
7463925e94
Merge pull request #15834 from atom/jr-decaf-gutter-container
...
Decaffeinate `GutterContainer`
2017-10-07 15:12:38 -04:00
Jason Rudolph
a00f619643
☠ ☕ Decaffeinate src/grammar-registry.coffee
2017-10-07 08:30:44 -04:00
Nathan Sobo
6209c9072f
Merge pull request #15833 from atom/as-always-clear-composition-checkpoints
...
Always revert to composition checkpoint, even if input is disabled
2017-10-06 14:55:40 -06:00
Jason Rudolph
f79708a74a
Merge pull request #15823 from atom/jr-decaf-gutter
...
Decaffeinate `Gutter`
2017-10-06 09:35:11 -04:00
Jason Rudolph
440316b45c
☠ ☕ Decaffeinate src/gutter-container.coffee
2017-10-06 09:23:34 -04:00
Antonio Scandurra
683cdeac27
Always revert to composition checkpoint, even if input is disabled
...
Previously, if the user opened the IME menu while input was disabled, we
would create a composition checkpoint without reverting to it after the
composition ended. When enabling input again, the first keystroke would
cause any buffer change that occurred between the IME composition and
the keystroke to be reverted.
With this commit we will always revert and delete the composition
checkpoint as soon as the composition ends, regardless of whether the
input is enabled or not.
2017-10-06 13:34:16 +02:00
Nathan Sobo
835efd3d68
Clear the dimensions cache after updating the soft wrap column
...
Updating the soft wrap column could cause us to compute different values
for derived dimensions, so any dimensions that were cached *in the
process* of updating the soft wrap column need to be cleared.
2017-10-05 15:47:59 -06:00
Antonio Scandurra
f640e9339d
Make comment more succinct
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-10-05 18:54:26 +02:00
Jason Rudolph
785ade897e
☠ ☕ Decaffeinate src/gutter.coffee
2017-10-05 09:55:40 -04:00
Antonio Scandurra
8759f9dac7
Clear dimensions cache when approximate screen line count changes
2017-10-05 13:51:23 +02:00
Michelle Tilley
eb4357ce87
Add tests for packages with URI handlers
2017-10-03 13:20:48 -07:00
Michelle Tilley
4b67353f85
Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch
2017-10-03 13:16:02 -07:00
