Commit Graph

16794 Commits

Author SHA1 Message Date
Ash Wilson
9de8131731 Ditto for Selection methods 2018-03-21 14:30:18 -04:00
Ash Wilson
ebb7647903 Mutation methods are no-ops in production. Throw in dev or spec mode 2018-03-21 14:25:50 -04:00
Ash Wilson
82575f5b07 👕 2018-03-21 12:29:52 -04:00
Ash Wilson
8fee5f8fb2 Merge remote-tracking branch 'origin/master' into aw/no-really-read-only 2018-03-21 11:55:52 -04:00
Ash Wilson
d405039581 Pass {bypassReadOnly} to selection.cut() 2018-03-21 11:53:36 -04:00
Ash Wilson
71d12f3f2c Guard Selection methods against read-only TextEditor modification 2018-03-21 11:53:20 -04:00
Ash Wilson
56a3f1bc41 Fill in missing ensureWritable() calls caught by the specs 2018-03-21 09:29:36 -04:00
t9md
b35cfaed20 Pass selectionsMarkerLayer on transact, undo and redo
To restore selections of change initiated editor on undo/redo.
2018-03-21 14:25:59 +09:00
Ash Wilson
1f866bd592 Add options.bypassReadOnly on methods that modify the underlying Buffer 2018-03-20 16:38:15 -04:00
Ash Wilson
427460552d Don't register modifying commands for readonly TextEditors 2018-03-20 10:19:56 -04:00
Ash Wilson
08ca84e587 📝 Convert code samples to js 2018-03-20 09:37:47 -04:00
Antonio Scandurra
d5c74c7e7c Merge pull request #16943 from atom/as-fix-subpixel-aa-when-soft-wrap-is-on
Clip cursor width when soft-wrap is on and cursor is at the end of a line
2018-03-20 10:01:43 +01:00
Landon Abney
e546190b1e 🐛 Fix documentation for the Config class
The parser that generates the documenation requires the comment for the
documentation to be immediately preceeding the class definition. As part
of the decaffeination process in #16593 a variable declaration was
placed between the class definition and it's documentaiton, causing the
parser to think there was none... and excluding it from the final
result.

Fixes #16955.
2018-03-15 23:52:49 -07:00
Ash Wilson
ce1c15cbc5 Recognize .tsx source as Typescript 2018-03-13 08:24:02 -04:00
Antonio Scandurra
26837d65b4 Clip cursor width when soft-wrap is on and cursor is at the end of line
This prevents the parent tile from disabling sub-pixel anti-aliasing.
For some reason, adding `overflow: hidden` to the cursor container
element doesn't solve the issue, so we're adding this workaround
instead.
2018-03-13 12:04:35 +01:00
Antonio Scandurra
98f2fdecfe Merge pull request #16926 from atom/fix-typo
Remove extra hyphen in option description
2018-03-12 18:25:29 +01:00
Lee Dohm
1c6b431bf8 Remove extra hyphen in option description 2018-03-10 09:15:47 -08:00
Philip Weiss
d7eff0ec55 Merge branch 'master' into fb-pw-simple-project-config 2018-03-09 14:06:14 -08:00
Philip Weiss
e14ffb9420 set default path inside of project.replace 2018-03-09 14:04:21 -08:00
Max Brunsfeld
a9fa57139a Fix regression where config file was loaded in specs 2018-03-09 11:15:50 -08:00
Antonio Scandurra
e2c89b29c8 Merge pull request #16428 from ernesto28/resize-pane
Resize pane
2018-03-09 08:38:44 +01:00
Philip Weiss
9282f07d07 return correct contents when no config present 2018-03-08 22:00:51 -08:00
Philip Weiss
a31795e1f3 fix linting issues 2018-03-08 21:53:50 -08:00
Philip Weiss
9d3c91b150 fix more nits 2018-03-08 21:49:18 -08:00
Wliu
2e19cf4a7c 📝 [ci skip] 2018-03-07 15:32:40 -05:00
Philip Weiss
b4f9faba42 fix nits 2018-03-06 14:55:51 -08:00
Philip Weiss
9b6b842a03 Merge branch 'fb-pw-simple-project-config' of github.com:atom/atom into fb-pw-simple-project-config 2018-03-06 13:34:02 -08:00
Philip Weiss
aa925c2a4c remove atomproject format restriction 2018-03-06 13:33:54 -08:00
Philip Weiss
6024a5f5cf Fix linting error in config.js 2018-03-06 11:49:41 -08:00
Philip Weiss
062dfdea80 address PR comments 2018-03-06 11:06:22 -08:00
Linus Eriksson
113b771e63 Merge pull request #16886 from atom/b3-fix-shaking-editor
Fix shaking editor when typing
2018-03-06 11:28:41 +01:00
Matthew Dapena-Tretter
e3a464eadf Merge pull request #16863 from atom/fb-mdt-fix-dock-dragndrop
Fix dock dragging and dropping
2018-03-05 14:45:28 -08:00
Linus Eriksson
de54e55878 Fix shaking editor when typing
When using DPI scaling the scroll position could be set to a position
that
was not possible causing a scroll event to scroll back. This was causing
the editor to shake when editing. This PR fixes
this by rounding scrollTop and scrollLeft to a physical pixel instead of
rounding using Math.round

Co-authored-by: Antonio Scandurra <as-cii@github.com>
2018-03-05 17:37:30 +01:00
Mihail Bodrov
6e59852456 Use native isArray, endsWith 2018-03-03 19:18:35 +03:00
Max Brunsfeld
40c608d015 Merge pull request #16668 from Connormiha/optimize-kill-process
Optimize process kill by pid
2018-03-02 16:39:46 -08:00
Philip Weiss
f111eaa543 remove console log 2018-03-01 21:02:48 -08:00
Philip Weiss
faf0d78f3e remove console log 2018-03-01 21:00:24 -08:00
Philip Weiss
04081ba0e5 fix linting issues 2018-03-01 20:12:25 -08:00
Philip Weiss
fd970c35b4 remove getallforpriority 2018-03-01 19:49:15 -08:00
Philip Weiss
232f821c35 remove getProjectSettings 2018-03-01 19:45:40 -08:00
Philip Weiss
7ce5b000e4 address more of max's comments 2018-03-01 19:35:59 -08:00
Philip Weiss
d5aaf9117a update with max's suggestions 2018-03-01 19:09:22 -08:00
Matthew Dapena-Tretter
6f194c7811 Make sure there's a single source of truth for dock hover state
Previously, the workspace's idea of the hovered dock and the docks'
themselves could be out of sync.
2018-03-01 14:56:52 -08:00
Philip Weiss
9d95fd613e Merge branch 'fb-pw-simple-project-config' of github.com:atom/atom into fb-pw-simple-project-config 2018-03-01 13:28:25 -08:00
Philip Weiss
9fb756feeb save entire settings object, rather than just the filename 2018-03-01 13:28:16 -08:00
Matthew Dapena-Tretter
c69c82d05a Fix dock dragging and dropping
This fixes #16769, which described an issue whereby trying to drop into
a closed dock would cause the dock to repeatedly open and close.

I tried to describe in comments why this was happening and how we can
make sure to avoid it.

The solution adds another DOM measurement which I'm not too thrilled
about but I profiled and it didn't seem to be an issue.
2018-02-28 18:14:13 -08:00
Ash Wilson
fc8e12fadb Merge pull request #16859 from jerry88kim/add-await-remove-unnecessary-param
Add 'await' keyword at async function call and remove unnecessary parameter
2018-02-28 10:29:28 -05:00
Ash Wilson
001aada5ac Merge pull request #16851 from atom/aw-filter-event-paths
Test .oldPath and .path on rename events
2018-02-28 08:19:40 -05:00
youngjoo88kim
9d55753ccb Add 'await' keyword at async function call and remove unnecessary parameter 2018-02-28 18:48:12 +09:00
Ash Wilson
72c30d7e78 Thanks, linter 2018-02-27 21:40:30 -05:00