github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-12 23:55:10 -05:00
Code Issues Packages Projects Releases Wiki Activity
36,371 Commits 140 Branches 571 Tags
9d8ae2aa82d175a819f95e0dc3f38e5ec4eaf6ef
Commit Graph

387 Commits

Author SHA1 Message Date
Ash Wilson
d3671f7055 Require --add to open locations in existing windows 2019-01-04 11:06:17 -05:00
Ash Wilson
f1de652bac ... Right. Joanna can't handle spread properties in objects 2019-01-04 09:06:19 -05:00
Ash Wilson
15594dd8c2 AtomApplication launch behavior shuffle 2019-01-03 16:41:17 -05:00
Ash Wilson
e570f72d86 Remove path normalization responsibilities from AtomWindow 2019-01-03 16:40:35 -05:00
Ash Wilson
e31a142a92 Remove unused initialPaths 2019-01-03 11:28:49 -05:00
Jordan Eldredge
878629dd0a Avoid sending async updates on config update 
In
7a5d727e22
the 'set-user-settings' callback was changed so that it nolonger
returned the promise created by `ConfigFile.update()`. This meant that
the logic in
[`ApplicateDelegate.onDidChangeUserSetting()`](https://github.com/atom/atom/blob/5f0231b/src/application-delegate.js#L193-L206) which uses
`.pendingSettingUpdateCount` to avoid triggering in response to calls to
ApplicationDelegate.setUserSettings` was no longer effective.

I noticed this when updating settings via the setting view. If you type
at just the right (wrong?) cadence, you'll notice that your input can
get updated with stale values.

Something like this:

```
You type            "a"      "b"            "c"
config.set          "a"      "ab"           "ac"
config.observe                        "a"         "ab"    "ac"
Input value         "a"      "ab"     "a"   "ac"  "ab"    "ac"
```

It's possible that is the same as https://github.com/atom/settings-view/issues/1062

After this change typing in settings input seems to behave as expected.
 2018-12-05 14:34:30 -08:00
David Wilson
b35778b686 Catch exceptions for bad package.json when looking for Atom repo in pwd 2018-09-15 06:30:49 -07:00
Stepan Hruda
069d3ec91a Merge pull request #17873 from atom/fb-sh-close-on-unload 
During quit, close unloaded windows
 2018-08-27 20:32:26 -04:00
Stepan Hruda
12c4e596b9 During quit, close unloaded windows 
Released under CC0.
 2018-08-27 19:06:36 -04:00
Max Brunsfeld
d875a0db89 Don't require compile cache in main process 2018-08-24 12:01:09 -07:00
Max Brunsfeld
ce18e1b7d6 Convert remaining coffee-script code in main process code to javascript 2018-08-24 12:01:09 -07:00
Max Brunsfeld
467415af19 Merge branch 'master' into wl-rm-safe-clipboard 2018-08-24 11:57:36 -07:00
David Wilson
9aa50b9cd4 Merge pull request #17903 from atom/dw-fix-dev-resource-path 
Always provide a devResourcePath in load settings
 2018-08-22 16:38:28 -07:00
David Wilson
c1f58e7971 Recognize short form argument -r of --resource-path in main.js 2018-08-22 12:42:15 -07:00
David Wilson
f31471707d Remove resourcePath and devResourcePath assignment from parseCommandLine 2018-08-22 12:41:36 -07:00
David Wilson
bb1f7b0a2f Always provide a devResourcePath in load settings 2018-08-22 11:48:50 -07:00
Ash Wilson
dbb3947250 Pass the environment to the window if one is present 2018-08-22 13:22:08 -04:00
Ash Wilson
e1015103c8 Use Object.assign() instead of spread so we don't confuse Joanna 2018-08-22 13:21:44 -04:00
Ash Wilson
528346040c Pass additional options to the test runner window 2018-08-22 10:28:41 -04:00
David Wilson
2d65535147 Don't normalize undefined devResourcePath on Windows 2018-08-21 14:20:42 -07:00
David Wilson
ba12a1e2fc Simplify dev resource path detection 2018-08-21 11:57:18 -07:00
David Wilson
ad4553cbba Merge pull request #17686 from atom/dw-repo-local-core-packages 
Enable repo-local core packages in the 'packages' folder
 2018-08-21 10:08:39 -07:00
David Wilson
8cd788e00f 👕 2018-08-21 06:50:37 -07:00
David Wilson
7b50f72ac2 Call getDevResourcePath 2018-08-21 06:43:28 -07:00
David Wilson
94f972e0bf Teach --dev to detect Atom repo in process.cwd() 2018-08-21 06:40:25 -07:00
David Wilson
b84592ba10 Allow nightly releases to auto-update 
This change removes a bad version check which prevented nightly releases 
to be considered for auto-update checks.  The fix is to only skip 
auto-updates when using a build with a version containing `-dev`.

Fixes #17885
 2018-08-20 15:40:14 -07:00
David Wilson
6753b929cb Don't depend on ATOM_DEV_RESOURCE_PATH for local core package path 2018-08-07 16:09:34 -07:00
David Wilson
86b8ead239 👕 2018-08-07 16:09:34 -07:00
David Wilson
77960f1d42 Enable repo-local core packages in the 'packages' folder 2018-08-07 15:57:43 -07:00
Matthew Dapena-Tretter
272566dfad Don't take destructive action on esc 2018-08-03 13:19:40 -07:00
Federico Bruni
6856c63421 Doc: explain how to open a file at a certain line and column 2018-06-23 18:01:20 +02:00
David Wilson
ba9616506f Merge pull request #17464 from atom/extended-color-profile-bits 
Extend the color profile PR (#17380)
 2018-06-04 14:22:25 -07:00
David Wilson
fceb6b0063 Merge pull request #17380 from atom/fix-color-problems-using-electron-2.0 
Restore color rendering following Electron 2.0 update
 2018-06-04 12:40:50 -07:00
Jason Rudolph
c3d38ed360 Support configuring color profile via settings UI 2018-06-01 16:32:31 -04:00
Jason Rudolph
f9ba602c6c Gracefully handle missing config file 
https://circleci.com/gh/atom/atom/7630
 2018-06-01 16:21:04 -04:00
Jason Rudolph
b67f8ac2ce 👕 2018-06-01 15:04:46 -04:00
Jason Rudolph
6985fb0ff3 Use Atom's standard config file to set custom color profile 2018-06-01 14:26:33 -04:00
Jason Rudolph
c71de84962 Look for .electron-switches in ATOM_HOME 2018-06-01 11:02:00 -04:00
Jason Rudolph
82ba358aa9 Read user's custom Electron switches from config file 2018-06-01 09:50:16 -04:00
npezza93
0938ea1a3d Fix deprecated hidden-inset title bar style 
As of https://github.com/electron/electron/pull/11975 the hidden-inset
titleBarStyle has been removed so the custom-inset title bar option
renders a normal title bar which is not desired.
 2018-05-24 10:40:01 -04:00
Jason Rudolph
d65a0971f9 Fix #17356 
Refs:
https://github.com/electron/electron/issues/10732#issuecomment-390321086
 2018-05-18 17:29:49 -04:00
Max Brunsfeld
12a54fb04f Use callback when calling mkdirp in recovery service 2018-05-01 11:48:47 -07:00
Byron Igoe
305bf9b4cb Await async mkdirp 2018-05-01 11:48:47 -07:00
Byron Igoe
f17add20c1 Cleaned up 2018-05-01 11:48:47 -07:00
Byron Igoe
a885d8a030 Fixes https://github.com/atom/atom/issues/17013 by creating the recovery directory 2018-05-01 11:48:47 -07:00
Max Brunsfeld
3f8b463b15 Move auto update initialization back to AtomApplication.initialize 
This fixes some CI problems introduced in #17216
 2018-05-01 11:01:18 -07:00
Max Brunsfeld
1ad9715e9d Wait to initialize auto update manager until config is loaded 2018-04-25 09:33:53 -07:00
Max Brunsfeld
85d745cbec Remove 'project' command line flag 
From what I can tell, this flag never worked correctly. Instead of
opening the paths specified in the project file, the directory
containing the project file itself would always be opened.
 2018-04-25 07:45:58 -07:00
Max Brunsfeld
7a5d727e22 Avoid writing to config file while quitting 2018-04-18 10:46:38 -07:00
Ash Wilson
ad8392b2f5 Accept a filePath in the set-user-settings IPC call 2018-03-27 08:55:07 -04:00