Antonio Scandurra
9ef3ecf378
Handle off-screen measurements properly
2015-12-02 18:34:57 +01:00
joshaber
c9813d8025
Ensure the repo is destroyed properly after testing.
2015-12-02 11:40:16 -05:00
joshaber
db7a3063e9
Call destroy on the synchronous repo.
2015-12-02 11:22:40 -05:00
Antonio Scandurra
5228471bc5
Write failing spec for measuring invisible elements
2015-12-02 17:04:33 +01:00
Antonio Scandurra
e10fdc234b
🐛 Coordinate conversion is hard
2015-12-02 16:26:10 +01:00
Antonio Scandurra
5bcdcbeef6
🎨
2015-12-02 16:13:44 +01:00
Antonio Scandurra
f30e4ccc9d
Use the new LineTopIndex in TextEditorPresenter
2015-12-02 16:01:55 +01:00
Antonio Scandurra
1e07b8df05
Handle position between rows correctly
2015-12-02 09:13:06 +01:00
joshaber
ca2fc8dbb0
Make sure we're testing the right thing.
2015-12-01 17:39:58 -05:00
joshaber
4559936af1
More const'ing.
2015-12-01 16:45:02 -05:00
joshaber
f290596542
Remove some lint.
2015-12-01 13:36:48 -05:00
Antonio Scandurra
e0b1cabb21
Implement a linear structure for block decoration coordinates
...
We still cannot handle `::rowForTopPixelPosition` when the passed top position
is in the middle of two rows and there's also a block decoration. We'll get
there eventually.
Also, the specs in this commit should serve as a good test suite for the future
logarithmic data structure.
2015-12-01 19:33:37 +01:00
joshaber
64d4716003
Use modern imports.
2015-12-01 12:47:11 -05:00
joshaber
9765cb55ea
Merge branch 'master' into dh-async-repo
2015-12-01 10:16:48 -05:00
Antonio Scandurra
d24290357a
Implement block decorations in the components land
2015-12-01 13:36:23 +01:00
Antonio Scandurra
47b16c513c
Make sure cursors are updated with respect to block decorations
2015-12-01 09:48:11 +01:00
Max Brunsfeld
3827b19da4
Merge pull request #9687 from atom/mb-deprecate-load-time-package-code
...
Provide package.json fields so we can defer requiring packages' main modules
2015-11-30 15:53:37 -08:00
Nathan Sobo
f139992585
Avoid infinite recursion in Error.prepareStackTrace
...
Previously, prepareStackTraceWithStackAssignment could end up calling
itself when third-party code assigned Error.prepareStackTrace back
to its original value. Now, we short-circuit this process if the
rawStack property has already been assigned.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-11-30 10:51:21 -08:00
Max Brunsfeld
a36fc301f9
Merge branch 'master' into mb-deprecate-load-time-package-code
2015-11-30 10:51:14 -08:00
Max Brunsfeld
228e67838c
Suppress false coffeelint error
2015-11-30 10:51:03 -08:00
Max Brunsfeld
d058814957
Merge remote-tracking branch 'origin/master' into mb-deprecate-load-time-package-code
...
Conflicts:
package.json
2015-11-30 10:20:31 -08:00
joshaber
3a06953820
Merge branch 'master' into dh-async-repo
2015-11-30 11:44:20 -05:00
Antonio Scandurra
526a97562e
Include block decorations as a separate object on presenter's state
2015-11-30 15:05:15 +01:00
Antonio Scandurra
8a54a2c15b
Use a boolean in each line state object
2015-11-30 14:44:58 +01:00
Antonio Scandurra
539a5b0ae7
🐎 Do as little pixel conversion as possible
...
We desperately need a tree-based data structure. 😢
2015-11-30 14:34:16 +01:00
Antonio Scandurra
b998e7f2d9
🐎 Incremental updates for block decorations
2015-11-30 14:03:45 +01:00
Antonio Scandurra
0159d5c31e
🎨
2015-11-27 16:58:08 +01:00
Antonio Scandurra
6ad21307cc
Provide blockDecorationsHeight for each line number
2015-11-27 16:27:01 +01:00
Antonio Scandurra
6365c86992
Include blockDecorations inside each line's state
2015-11-27 14:32:01 +01:00
Antonio Scandurra
e1e06580c1
Move position conversion in LinesYardstick
2015-11-27 12:47:47 +01:00
Antonio Scandurra
0b5638f749
Make sure tile positions are computed correctly
2015-11-27 10:47:25 +01:00
Antonio Scandurra
a9cb1bda8d
Use ::positionForRow in ::updateTilesState
...
The algorithm is still super sloooow 🐌 , but we'll fix that in a later
commit.
2015-11-27 10:16:38 +01:00
Antonio Scandurra
02651b7a58
🎨 Rename to ::setBlockDecorationDimensions
2015-11-26 16:10:08 +01:00
Antonio Scandurra
96863eef1c
Ensure content scrollHeight takes block decorations into account
...
Seems like all these properties in the presenter's state share a common
contract, which we should probably extract. It could also mean there's an
underlying design problem, because we are testing two dimensions of the same
behavior in a single spec.
2015-11-26 15:44:59 +01:00
Antonio Scandurra
30da4bdb0c
Ensure gutter scroll height takes block decorations into account
2015-11-26 15:43:34 +01:00
Antonio Scandurra
89d9a2ce83
🎨 Create block decorations in TextEditor
...
This is just an experiment, although I like that we can hide some information
(irrelevant to the user) behind a clean API.
2015-11-26 15:40:08 +01:00
Antonio Scandurra
c8254566ef
Change verticalScrollbar's height according to block decorations
2015-11-26 15:34:45 +01:00
Antonio Scandurra
5dfd765bcf
Do not override user-defined keymaps when reloading packages
2015-11-26 10:39:47 +01:00
Wliu
71574d785c
Merge remote-tracking branch 'master' into wl-electron-35
...
# Conflicts:
# package.json
# src/application-delegate.coffee
2015-11-25 18:44:40 -05:00
Nathan Sobo
8978691831
Merge pull request #9773 from atom/mb-ns-prepare-stack-trace-fixes
...
Allow Error.prepareStackTrace to be temporarily reassigned
2015-11-24 11:59:53 -07:00
Antonio Scandurra
c061b27076
✅
2015-11-24 17:36:44 +01:00
Antonio Scandurra
9376738918
Make spec async because of Promise-based API
2015-11-24 12:28:31 +01:00
Max Brunsfeld
327cf6997b
Remember which packages use atom APIs at main module load time
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 17:35:38 -08:00
Max Brunsfeld
24938c0361
Defer loading view providers until activation or deserializer use
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 16:28:08 -08:00
Max Brunsfeld
d6e5ea8564
Defer requiring packages' main modules if they use new package.json fields
2015-11-23 16:05:32 -08:00
Max Brunsfeld
2d29fd6e79
Load config schemas from packages' package.json files
2015-11-23 15:53:26 -08:00
Max Brunsfeld
4bc46db355
Still assign error's raw stack when prepareStackTrace is overridden
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 15:30:11 -08:00
Max Brunsfeld
4616b426b0
Allow Error.prepareStackTrace to be temporarily reassigned
...
Fixes https://github.com/atom/atom/issues/9660
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 15:22:15 -08:00
Douwe Maan
b11d0c2585
Use em-dash in window title and exclude app name on OS X
2015-11-21 14:09:00 +01:00
Max Brunsfeld
30b3cb249e
Merge pull request #9636 from DouweM/unique-title
...
Use unique text editor title in window and tab titles
2015-11-20 16:55:38 -08:00
