Antonio Scandurra
a314deeff9
Unfocus test
2017-06-12 11:27:58 +02:00
Antonio Scandurra
9a0709e95e
Don't try to measure lines that don't exist
...
By the time that the animation frame is delivered, the requested
autoscroll
position could not exist anymore. This could cause the editor component
to measure a non-existent line and, as a result, throw an exception.
With this commit we will always ignore measurements for screen lines
that do not exist.
2017-06-09 18:40:24 +02:00
Antonio Scandurra
6d1f8ea88c
Render line number gutter without numbers when showLineNumbers is false
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-06-01 16:29:04 +02:00
Nathan Sobo
2372227b00
Fix specs on macOS when "Show scroll bars" option isn't "always"
2017-06-01 12:01:11 +02:00
Wliu
16be073c91
Merge branch 'master' into wl-build-on-node-7
2017-05-30 15:40:02 -04:00
Ian Olsen
d5089936bd
Merge pull request #14420 from atom/fb-mdt-dock-items-dont-cause-restore-state-prompt
...
Don't show restore dialog for non-editor dock items
2017-05-24 08:43:35 -07:00
Ian Olsen
ddcf5460ed
Merge pull request #14427 from atom/fb-hw-url-fix2
...
Fix the atom:// URL handler for real (with tests this time)
2017-05-24 08:41:43 -07:00
Jason Rudolph
efa440f705
Merge pull request #14460 from atom/jr-activate-next-or-previous-pane-in-dock
...
Fix ability to activate next/previous pane in a dock
2017-05-22 10:03:26 -04:00
Jason Rudolph
3020a61e34
Test activating next/previous pane at the workspace level
2017-05-19 10:49:51 -04:00
Jason Rudolph
8079b51839
Remove unnecessary test setup
...
H/T @nathansobo
2017-05-19 09:33:06 -04:00
Antonio Scandurra
d158e44374
Merge branch 'master' into tj-upgrade-electron
2017-05-19 11:05:15 +02:00
Max Brunsfeld
e99545ee41
Fix exception when starting to drag text
2017-05-18 10:13:48 -07:00
Jason Rudolph
d599b52d36
✅ Add failing tests for #14442
2017-05-17 15:26:42 -04:00
hansonw
e8cd4bf431
Fix the atom:// URL handler for real (with tests this time)
2017-05-16 11:51:54 -07:00
Antonio Scandurra
d44876f3bc
Merge branch 'master' into tj-upgrade-electron
2017-05-16 14:39:47 +02:00
Antonio Scandurra
3b3505d969
Always allow to destroy free-form folds from the gutter
2017-05-16 14:36:50 +02:00
Antonio Scandurra
ad6202cadb
Show foldable icon on the last screen row belonging to a buffer row
2017-05-16 14:26:57 +02:00
Antonio Scandurra
4c5127ca2f
Update foldable icon when a row's foldability changes
2017-05-16 14:05:11 +02:00
Matthew Dapena-Tretter
80ced1140c
Don't show restore dialog for non-editor dock items
...
The Nuclide file tree was causing this dialog to be shown every time.
With this commit, we exclude non-editor dock items from the "dirty"
check.
2017-05-15 16:13:29 -07:00
Lee Dohm
1559c8a047
Merge pull request #12946 from jamsinclair/11848-fix-moving-line-without-line-ending
...
Fixes #11848 Moving line up without line ending
2017-05-13 15:00:46 -07:00
Antonio Scandurra
96533998e2
Fix editor element tests on Windows
2017-05-12 16:51:05 +02:00
Antonio Scandurra
0d4e2b3556
Fix editor component tests on Windows
2017-05-12 13:04:03 +02:00
Antonio Scandurra
186bcd70a5
Fix running packages preloading tests in interactive mode
...
This change also makes the test more useful, as it verifies that reading
metadata from package.json's `packagesCache` works correctly.
2017-05-12 10:11:58 +02:00
Nathan Sobo
e62d1b91b7
Unspy Date.now when jasmine.useRealClock is called
2017-05-11 21:33:50 -06:00
Nathan Sobo
ffd154ec34
Fix lint errors
2017-05-11 21:29:36 -06:00
Nathan Sobo
5a9582ed64
Silence error output in test
2017-05-11 21:10:20 -06:00
Nathan Sobo
b7218e5aa4
Fix atom.setSize spec when window is full screen
2017-05-11 21:06:15 -06:00
Nathan Sobo
6c6d38a3f0
Destroy environment to silence leaked editor warning
2017-05-11 21:02:28 -06:00
Nathan Sobo
8743298c4c
Avoid polluting test with click events on the test runner
...
We now pass an isolated document into the AtomEnvironment instance under
test to avoid accidentally handling clicks on the test runner itself.
2017-05-11 17:59:40 -06:00
Nathan Sobo
2e2b35c32c
Avoid problems related to calling startEditorWindow in tests
2017-05-11 17:44:16 -06:00
Max Brunsfeld
07c2a8e8d6
Merge pull request #14339 from atom/mb-dont-change-focus-when-hiding-unfocused-dock
...
Don't change focus when hiding an unfocused dock
2017-05-11 16:28:27 -07:00
Nathan Sobo
d584bd6adb
Eliminate reliance on local storage in HistoryManager
...
It's causing test failures locally and enough time has passed that most
user data should be transitioned to indexed DB by now.
2017-05-11 16:58:54 -06:00
Nathan Sobo
f8ecf929a8
Disable github package in smoke test – it takes too long to compile
2017-05-11 16:46:02 -06:00
Nathan Sobo
80f033114c
Mock Date.now in spec helper in addition to _.now
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2017-05-11 15:20:53 -06:00
Wliu
7c2510eb9c
Merge branch 'master' into wl-build-on-node-7
2017-05-11 12:06:26 -04:00
Antonio Scandurra
729ae0ea51
Merge branch 'master' into tj-upgrade-electron
...
# Conflicts:
# script/package.json
# src/task.coffee
2017-05-11 18:05:12 +02:00
Antonio Scandurra
32f03c8a22
Delete unused code
2017-05-11 11:07:21 +02:00
Antonio Scandurra
39a5705e39
Re-enable a test that was previously failing
2017-05-11 11:06:35 +02:00
Nathan Sobo
048a548462
Fix specs
2017-05-10 14:18:15 -06:00
Antonio Scandurra
e89552ea75
Ignore mismatched tags between lines in TokenizedBufferIterator
...
Previously the DisplayLayer would have issues when closing tags that had
not been previously opened, requiring us to guard against mismatched
scopes at the frontier of asynchronous tokenization (see 5cfe9716nathan@github.com >
2017-05-10 17:54:14 +02:00
Nathan Sobo
4eecf8d1a6
Don't change number of tiles based on block decorations
...
This means we may render more tiles than necessary when we have block
decorations, but it prevents changing the number of rendered tiles
during scrolling with certain combinations of line height and editor
height. If it ever becomes a problem we can get smarter about
subtracting the height of the visible block decorations from the editor
height, but for now this gives us more reliable performance for the
common case.
2017-05-09 15:09:14 -06:00
Antonio Scandurra
be2aaa0b22
Use explicit state to recycle tiles instead of modulo scheme
...
This avoids updating tiles unnecessarily when changing the number of
rendered tiles.
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-09 17:46:29 +02:00
Max Brunsfeld
1c8847cb4f
🐎 Ensure rendered tile count is stable when scrolling
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-08 15:50:16 -07:00
Nathan Sobo
f76e850aa5
Fix rendering artifacts when resizing with soft wraps
...
Previously, we were accidentally depending on the state of the display
layer when forcing it to update its index. This caused us to not index
enough content to cover the visibile area, which meant we weren't
querying enough lines to fill the screen in some situations.
2017-05-08 10:58:33 -06:00
Bryant Ung
f464bb3579
Merge pull request #13947 from anatoli26/master
...
Make an option to always restore the last session
2017-05-08 09:33:23 -07:00
Antonio Scandurra
df4116d4aa
Fix clicking past the content height
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-05 19:55:14 +02:00
Antonio Scandurra
15f25a745a
Update width of content when approximate longest screen row changes
2017-05-05 11:29:57 -06:00
Antonio Scandurra
2855e01289
Don't create empty nodes when a text decoration ends next to a text tag
...
This was causing problems in measurements because in that code path we
assume that text nodes are never empty. This commit also adds a test
verifying this invariant when a text decoration ending right after a
text tag is added.
2017-05-05 11:22:01 +02:00
Antonio Scandurra
f7b79b477a
Update class list even when the editor is not attached
2017-05-05 09:30:08 +02:00
Antonio Scandurra
c541d3941c
Fix remaining test failures in core
2017-05-05 09:30:08 +02:00
