github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-19 02:44:29 -05:00
Code Issues Packages Projects Releases Wiki Activity
25,613 Commits 140 Branches 571 Tags
a3e1b34e954c2379c1bc0078f18c68451a85fa49
Commit Graph

270 Commits

Author SHA1 Message Date
Nathan Sobo
88d80b1c97 Assign config in Atom environment constructor 2015-10-07 15:24:51 -05:00
Max Brunsfeld
d55398b77b Use key-path-helpers module instead of underscore-plus 2015-09-28 17:27:15 -07:00
Thomas Johansen
4914c15289 🔥 Remove Config deprecations 2015-09-22 10:37:05 -06:00
Jeremy Ramin
9a0d657d52 Adds deepDefaults to config 
Took at the deepExtend in the atom/underscore-plus repo and modified it
to become a deepDefaults method. Using this instead to see if it fixes
the failing specs.
 2015-08-22 23:03:19 -07:00
Jeremy Ramin
85800f6d00 Fix method typo 2015-08-22 21:16:32 -07:00
Jeremy Ebneyamin
f2c9688b43 Fix config.get for schemas containing objects 
The config.get method would not return the default values for the
properties in objects. Now with _.deepExtends, the default values are
the base while any new values overwrite the defaults. This way all
default values appear, including those nested in an object. This fixes
atom/settings-view#386 and fixes atom/settings-view#518.
 2015-08-22 19:44:17 -07:00
Lee Dohm
bb0dc68e40 📝 Add docs for Markdown formatting of config descriptions 
Related to atom/settings-view#635
 2015-08-19 07:48:15 -07:00
Max Brunsfeld
5f620fb739 Config::getSchema - use null to represent inaccessible key path 2015-08-12 16:52:25 -07:00
Max Brunsfeld
fbd684926e Config - Support additionalProperties field of object schemas 2015-07-30 18:28:41 -07:00
Max Brunsfeld
84f72c880a Config - don't allow setting key-paths inside of strings, arrays, etc 2015-07-30 18:28:06 -07:00
Ivan Zuzak
2d7691c19a Fix config.set scope selector example 2015-07-13 06:51:01 -07:00
Kevin Sawicki
66620f8510 Add TODO comment 2015-06-01 13:32:38 -07:00
Kevin Sawicki
703eaac7ca Keep around atom.config.unobserve no-op 2015-06-01 13:32:03 -07:00
Nathan Sobo
e723b26eb0 Add maximumLength schema enforcer for strings 2015-06-01 18:45:38 +02:00
Nathan Sobo
d1c44dcb54 Never load config settings from disk when a save is pending 
Fixes #5771

We load the user’s settings from disk when we detect a change to their
config.cson file. However, if there’s a save pending, doing this will
end up blowing away the values we intend to save.
 2015-04-20 12:12:05 -06:00
Kevin Sawicki
4160a8c239 Merge pull request #6230 from mnquintana/coffeelint-plus 
Lint for more styleguide errors
 2015-04-08 12:07:23 -07:00
Kevin Sawicki
baae0c0ac6 Only include emissary Emitter in deprecation mode 2015-04-07 14:40:27 -07:00
Machiste Quintana
2bb2022b5b 👕 2015-04-07 00:05:19 -04:00
Machiste Quintana
5d2392ea67 👕 Fix new coffeelint errors 2015-04-06 23:59:54 -04:00
Kevin Sawicki
7d592c8b78 includeDeprecations -> includeDeprecatedAPIs 2015-04-03 11:29:16 -07:00
Kevin Sawicki
bb53548ba0 Only check deprecation flag for callNow usage 2015-04-03 11:29:14 -07:00
Kevin Sawicki
dd72bbe0ef Conditionally include deprecations in Config 2015-04-03 11:29:14 -07:00
Kevin Sawicki
590a4b0fd5 Add explicit return after for loop 2015-03-19 11:48:40 -07:00
Scott Chacon
b3325d64b0 update internal docs links 2015-03-11 15:11:46 -07:00
Kevin Sawicki
30419027a8 Show notification on config save failures 2015-02-05 15:34:17 -08:00
Lee Dohm
23b8b15261 📝 Fix broken json-schema.org link 2015-02-02 17:22:29 -08:00
Ben Ogle
9cb67a6def 📝 Fix doc reference in config 2015-01-30 16:52:19 -08:00
Ben Ogle
d3f29c4580 🎨 Fix wording 2015-01-29 17:54:41 -08:00
Ben Ogle
cd812e7a65 Transact on resetting the settings when a schema changes 2015-01-29 17:54:41 -08:00
Ben Ogle
4e6e636b8b 🎨 Reorder args to be consistent with other methods 2015-01-29 17:54:41 -08:00
Ben Ogle
083bafdb33 Handle unschema’d items in objects. 
This is required for packages that still use configDefaults
 2015-01-29 17:54:41 -08:00
Ben Ogle
adbe151c5d Fix up the linter error 2015-01-29 17:54:41 -08:00
Ben Ogle
b9b2b4bca2 Adhere to the schemas when loading the user’s config 2015-01-29 17:54:41 -08:00
Ben Ogle
79094ee889 Reset all user config values when the schema changes. 2015-01-29 17:54:40 -08:00
Kevin Sawicki
84be87324e Always deepClone since it supports colors now 2015-01-22 14:41:55 -08:00
Kevin Sawicki
63335f6b60 Return Color object when in cloned objects 
This adds a custom deepClone that clones any Color objects
correctly.
 2015-01-22 10:48:07 -08:00
Max Brunsfeld
96d4c1c41b Save config when deprerecated Config::set signature is used 2015-01-16 12:24:32 -08:00
Max Brunsfeld
0a59d13d56 Fix Config::unset with no scope-selector 
Closes #5095
 2015-01-16 10:23:12 -08:00
Ben Ogle
4ba7182bbf 💄 Inline fileName cause it's used once 2015-01-14 16:15:53 -08:00
Ben Ogle
6211f7330f Use path name in config error messsages 2015-01-14 16:15:53 -08:00
Ben Ogle
62eac3f8a5 Fix error string when there is a user config error 2015-01-14 16:15:53 -08:00
Ben Ogle
4b8e98af0c Display a better message when there are config watch errors on startup 2015-01-14 16:15:52 -08:00
Kevin Sawicki
9d3e9d19e1 📝 Link to Color 2015-01-12 17:34:44 -08:00
Kevin Sawicki
432c31c4dc 💄 2015-01-12 17:34:44 -08:00
Kevin Sawicki
44939a12a0 Validate color properties when set 2015-01-12 17:34:43 -08:00
Kevin Sawicki
574c56713c Add Color class with string helpers 2015-01-12 17:34:43 -08:00
Kevin Sawicki
b8822b32db Only coerce strings and plain objects 2015-01-12 17:34:43 -08:00
Kevin Sawicki
8c39818670 Don't blow up when asking for schema at non-existent path 2015-01-12 17:34:43 -08:00
Kevin Sawicki
c480080dd2 Add fallback values when NaN is parsed 2015-01-12 17:34:42 -08:00
Kevin Sawicki
ec96c5f1fc 📝 Add color docs 2015-01-12 17:34:42 -08:00