Commit Graph

16734 Commits

Author SHA1 Message Date
Antonio Scandurra
e2c89b29c8 Merge pull request #16428 from ernesto28/resize-pane
Resize pane
2018-03-09 08:38:44 +01:00
Wliu
2e19cf4a7c 📝 [ci skip] 2018-03-07 15:32:40 -05:00
Linus Eriksson
113b771e63 Merge pull request #16886 from atom/b3-fix-shaking-editor
Fix shaking editor when typing
2018-03-06 11:28:41 +01:00
Matthew Dapena-Tretter
e3a464eadf Merge pull request #16863 from atom/fb-mdt-fix-dock-dragndrop
Fix dock dragging and dropping
2018-03-05 14:45:28 -08:00
Linus Eriksson
de54e55878 Fix shaking editor when typing
When using DPI scaling the scroll position could be set to a position
that
was not possible causing a scroll event to scroll back. This was causing
the editor to shake when editing. This PR fixes
this by rounding scrollTop and scrollLeft to a physical pixel instead of
rounding using Math.round

Co-authored-by: Antonio Scandurra <as-cii@github.com>
2018-03-05 17:37:30 +01:00
Mihail Bodrov
6e59852456 Use native isArray, endsWith 2018-03-03 19:18:35 +03:00
Max Brunsfeld
40c608d015 Merge pull request #16668 from Connormiha/optimize-kill-process
Optimize process kill by pid
2018-03-02 16:39:46 -08:00
Matthew Dapena-Tretter
6f194c7811 Make sure there's a single source of truth for dock hover state
Previously, the workspace's idea of the hovered dock and the docks'
themselves could be out of sync.
2018-03-01 14:56:52 -08:00
Matthew Dapena-Tretter
c69c82d05a Fix dock dragging and dropping
This fixes #16769, which described an issue whereby trying to drop into
a closed dock would cause the dock to repeatedly open and close.

I tried to describe in comments why this was happening and how we can
make sure to avoid it.

The solution adds another DOM measurement which I'm not too thrilled
about but I profiled and it didn't seem to be an issue.
2018-02-28 18:14:13 -08:00
Ash Wilson
fc8e12fadb Merge pull request #16859 from jerry88kim/add-await-remove-unnecessary-param
Add 'await' keyword at async function call and remove unnecessary parameter
2018-02-28 10:29:28 -05:00
Ash Wilson
001aada5ac Merge pull request #16851 from atom/aw-filter-event-paths
Test .oldPath and .path on rename events
2018-02-28 08:19:40 -05:00
youngjoo88kim
9d55753ccb Add 'await' keyword at async function call and remove unnecessary parameter 2018-02-28 18:48:12 +09:00
Ash Wilson
72c30d7e78 Thanks, linter 2018-02-27 21:40:30 -05:00
Ash Wilson
1dab06c4da Remove redundant filtered declaration 2018-02-27 21:06:37 -05:00
Ash Wilson
b9117c14be Avoid calling fs.realpath on editors without a path 2018-02-27 17:22:30 -05:00
Ash Wilson
4c8f1fe3ad There's no modifyEvent there 2018-02-27 17:16:08 -05:00
Ash Wilson
f7f6564b7d Test .oldPath and .path on rename events 2018-02-27 17:14:41 -05:00
Matthew Dapena-Tretter
880148259f Convert PaneContainerElement and PaneElement to JS 2018-02-23 14:39:57 -08:00
Landon Abney
138115f2a8 🐛 Handle empty username
If Atom is launched in a shell that is missing the `USER`/`USERNAME`
environment variable it locks up due to an unhandled error from
`crypto.update`. This switches to using Node.js's built in
`os.userInfo()` method to retrieve the current user name,
allowing Atom to complete initialization in this scenario.

Fixes #16821.
2018-02-22 13:18:56 -08:00
Jordan Eldredge
fa9c8d1ace Merge pull request #16661 from captbaritone/context-menu-order-master
Enable packages to control order of context menu items
2018-02-22 09:36:43 -08:00
Will Binns-Smith
b42972fa84 Add custom properties to atom-workspace to track editor properties (#16731)
* Add custom properties to atom-workspace

These track the editor's current font size, font family, and line
height.

* Move editor styles to text-editor; add monospace fallback

* Add default font family

So that there will always be a valid value.

* Fix specs
2018-02-21 19:02:14 -08:00
Max Brunsfeld
2100f90cf4 Provide a default scope descriptor if language mode doesn't provide them 2018-02-21 14:55:58 -08:00
Max Brunsfeld
e638100158 Merge pull request #16810 from atom/mb-dont-write-config-when-quitting
Don't try to write config file while quitting
2018-02-21 10:44:56 -08:00
Max Brunsfeld
a0e231dea3 Merge pull request #16809 from atom/mb-fix-color-config
Serialize settings as JSON when sending them to the main process
2018-02-21 10:39:07 -08:00
Max Brunsfeld
ea8165a1ca Make TreeSitterLanguageMode.scopeDescriptorForPosition accept arrays
Fixes #16808
2018-02-21 10:16:50 -08:00
Max Brunsfeld
fb85656d8f Don't try to write config file while quitting 2018-02-21 09:29:02 -08:00
Max Brunsfeld
6b9e87ecd6 Serialize settings as JSON when sending them to the main process 2018-02-21 09:18:15 -08:00
Max Brunsfeld
1cdb804824 Tweak config APIs for dealing w/ legacy scope aliases 2018-02-20 11:07:45 -08:00
Max Brunsfeld
2575cf6b1a Fix path duplication after decaffeinating main process code 2018-02-16 13:41:17 -08:00
Nathan Sobo
e334f0419f Merge pull request #16753 from billyjanitsch/revert-15487
Stop scaling up small scroll wheel events
2018-02-16 11:58:33 -08:00
Max Brunsfeld
cd997e3d77 Simplify TreeSitterHighlightIterator.moveToSuccessor 2018-02-16 09:40:57 -08:00
Wliu
82d5974616 Merge pull request #16748 from UziTech/patch-6
return value of sync confirm function
2018-02-16 10:06:27 -05:00
Wliu
69af0141a1 🐛 params -> options 2018-02-15 18:35:50 -05:00
Nathan Sobo
f647109474 Merge pull request #15831 from atom/b3-failing-seed
Handle edits that scroll up due to hiding the horizontal scrollbar
2018-02-15 14:32:20 -08:00
Linus Eriksson
8cfcdf8c00 Revert always return false 2018-02-15 23:12:35 +01:00
Linus Eriksson
63326e969a Unfocus test and always return false to see if this fails on circle 2018-02-15 22:53:29 +01:00
Max Brunsfeld
adbd540029 Only return overridden language ids in .getGrammarOverride 2018-02-15 12:29:48 -08:00
Linus Eriksson
3059d14bd7 Merge remote-tracking branch 'origin/master' into b3-failing-seed 2018-02-15 19:49:58 +01:00
Billy Janitsch
a433e974eb Stop scaling up small scroll wheel events 2018-02-15 10:42:57 -08:00
Max Brunsfeld
e3135f1938 Continue to normalize any non-URL path command line arg
Also, remove duplicate file stat'ing in AtomWindow
2018-02-15 10:40:31 -08:00
Tony Brix
daac2c4ee1 return value of sync confirm function 2018-02-14 21:49:45 -06:00
Max Brunsfeld
98070275b5 Normalize command line paths with windows drive letters 2018-02-14 17:22:36 -08:00
Max Brunsfeld
eb596ff7e5 Merge pull request #16744 from atom/mb-shim-private-language-mode-apis
Shim two private APIs on TreeSitterLanguageMode
2018-02-14 15:02:09 -08:00
Max Brunsfeld
b51f13cc90 Shim two private APIs on TreeSitterLanguageMode 2018-02-14 14:23:35 -08:00
Landon Abney
53c0f5f4a0 🐛 Prefer package name from metadata
When loading a package prefer the name specified in the package metadata
instead of the name of the folder that the package's files reside in.

Fixes #16703.
2018-02-14 12:02:17 -08:00
Max Brunsfeld
30e1233b11 Fix loadGrammar callback argument order
Fixes #16733
2018-02-14 10:01:47 -08:00
Max Brunsfeld
2ef0bc5ba6 Merge pull request #16738 from atom/mb-tree-sitter-crlf-handling
Fix difference in CRLF line ending handling between tree-sitter and text-buffer
2018-02-14 09:37:21 -08:00
Max Brunsfeld
3e7e8aecce Handle positions between CR and LF characters in TreeSitterTextBufferInput.seek 2018-02-14 07:49:02 -08:00
Ash Wilson
cb783fd15c Use @atom/watcher with a core.fileSystemWatcher setting 2018-02-14 09:29:28 -05:00
Max Brunsfeld
c47ed5ea06 Merge pull request #16701 from atom/fb-pw-configurable-loadSettings
add `configurable: true` to browserwindow.loadSettingsJSON
2018-02-08 23:07:56 +01:00