Nathan Sobo
eee31c3e8c
Don’t use component property for TextEditorView::mini shim
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 17:56:47 -07:00
Nathan Sobo
dd80226c23
Revert "Handle addition/removal of ‘gutter-hidden’ attribute"
...
This reverts commit 6926236268 .
There seems to be some bug or timing issue that prevents the
attachedCallback from being called in all cases when the
attributeChangedCallback is defined. We can figure this out at
a later time.
2015-01-12 17:39:07 -07:00
Nathan Sobo
6926236268
Handle addition/removal of ‘gutter-hidden’ attribute
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Nathan Sobo
43f57347d7
Add ‘gutter-hidden’ attribute to TextEditorElement
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Nathan Sobo
002918049d
🐎 Cache gutterVisible state in React component
...
This avoids a config read on every render.
2015-01-12 16:21:31 -07:00
Nathan Sobo
f00b0b7f7a
Add TextEditor::set/isGutterVisible
...
Controls gutter visibility on individual editors.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Max Brunsfeld
ee73d2cf2a
📝 fix ::onDidChangeActivePaneItem docs
...
Refs #4946
2015-01-12 08:24:44 -08:00
Ben Ogle
48e6cd533d
Add wasDisplayed to Notification
2015-01-09 17:35:26 -08:00
Max Brunsfeld
ee7587e024
Update task docs
2015-01-09 16:59:13 -08:00
Max Brunsfeld
fb0769783f
Don't use Emitter::off in Task
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-01-09 16:59:13 -08:00
Lee Dohm
ef97197681
Use list.map instead of _.map list
2015-01-09 16:42:16 -08:00
Lee Dohm
acb19c1fe1
Log scopes to notification instead of console
...
Fixes #4969
2015-01-09 16:33:48 -08:00
Max Brunsfeld
02a6ed554d
Make ContextMenuManager::showForEvent private
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-01-09 15:47:30 -08:00
Max Brunsfeld
dde5e6123c
Make Cursor::updateVisibility private
2015-01-09 15:41:08 -08:00
Nathan Sobo
d26c19a0ec
Deprecate Project::resolve
...
It’s not something that will make sense once we add the ability to have
multiple directories in a project. This adds a new private method on
Project, ::resolvePath, with the original implementation for convenience
until we actually implement multi-folder projects.
2015-01-09 15:03:07 -08:00
Max Brunsfeld
f9bde050b4
Handle TextEditorElement::focus() while parent is being attached
...
Fixes atom/autocomplete#61
2015-01-09 15:00:35 -08:00
Nathan Sobo
19bf64f3cd
Revert "Deprecate Project::resolve"
...
This reverts commit 3c5bd9f10a .
2015-01-09 13:58:01 -08:00
Nathan Sobo
3c5bd9f10a
Deprecate Project::resolve
...
It’s not something that will make sense once we add the ability to have
multiple directories in a project.
2015-01-09 13:40:35 -08:00
Ben Ogle
a47782ddd8
Fix context menu docs Closes #4963
2015-01-09 13:28:57 -08:00
Nathan Sobo
0a5b4f9b33
Make “style sheet” two words in package.json metadata
...
Rename `stylesheets` -> `styleSheets`
Rename `stylesheetsMain` -> `mainStyleSheet`
2015-01-09 09:04:04 -08:00
Nathan Sobo
c078f64293
Rename package stylesheets/ directory to styles/
2015-01-09 08:42:15 -08:00
Nathan Sobo
7f9d06f55b
Move TextEditor::pixelPositionForScreen/BufferPosition to view layer
...
It doesn’t make sense to talk about pixels at the model layer long-term,
even though we currently store view dimension information in the model
so we don’t have to read from the DOM for optimization purposes. This
information is only available if the view is attached, however, making
these methods a liability on the model layer.
2015-01-09 08:22:45 -08:00
Nathan Sobo
c3efed0a2c
Update deprecation messages
2015-01-08 18:21:07 -08:00
Nathan Sobo
a945725a2f
Add shims for tests that manually dispatch deprecated events
2015-01-08 17:51:11 -08:00
Nathan Sobo
723b4d2787
Fix undefined Grim references
2015-01-08 17:51:11 -08:00
Nathan Sobo
4ab33890fc
Add PackageManager::onDidLoad/UnloadPackage
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
7acf3d4d6b
Add PackageManager::onDidDeactivatePackage
2015-01-08 17:51:11 -08:00
Nathan Sobo
a6c9244c77
Add PackageManager::onDidActivatePackage
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
18ac0091a8
Don’t call onDidActivateInitialPackages listeners until the right time
...
We wait until all packages without activation commands actually
activate.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
010bd643c0
Rename onDidActivateAll -> onDidActivateInitialPackages
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
15fa19efa3
Rename onDidLoadAll -> onDidLoadInitialPackages
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
30513cfde0
Rename ThemeManager methods for clarity/consistency
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:09 -08:00
Nathan Sobo
d999b4eca0
Deprecate ThemeManager::setEnabledThemes
...
Suggest direct config write instead.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:48:32 -08:00
Nathan Sobo
caf613e7c8
Associate packageName metadata with scoped-properties/ deprecation
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:41:50 -08:00
Kevin Sawicki
453a44dde3
Use special compile cache when sudo-ing as root
2015-01-08 10:18:54 -08:00
dominic
c806fcf9e7
📝 Fix PackageManager::onDidLoadAll description
2015-01-08 09:42:49 +00:00
Kevin Sawicki
081fc0e1ae
Use icon from resources directory
2015-01-07 16:22:11 -08:00
Kevin Sawicki
2cb13e1a66
Remove lint warning
2015-01-07 14:33:18 -08:00
Kevin Sawicki
97e0ddf15d
Null out mainPath on resolve errors
...
The scope of this variable is outside the loop so this prevent
cache corruption based on using the mainPath value from previous
module.
Refs atom/atom-space-pen-views#5
2015-01-07 10:53:33 -08:00
Kevin Sawicki
fb3cc5554c
Catch errors spawning squirrel
...
Closes #4895
2015-01-07 10:24:19 -08:00
Kevin Sawicki
6fe7eb086f
Gracefully handle empty keymaps and menus
...
Closes atom/settings-view#310
2015-01-07 09:18:57 -08:00
Nathan Sobo
f77f48102c
Merge pull request #4879 from atom/ns-style-priorities
...
Use 'priority' to correctly order style sheets rather than 'group'
2015-01-07 09:51:55 -07:00
Nathan Sobo
7dd67caf57
Remove ‘group’ parameter to addStyleSheet in favor of ‘priority’
2015-01-07 09:51:42 -07:00
Hiroki Sato
571d146ec0
Fix removing the dragover event listener
2015-01-07 22:49:25 +09:00
Kevin Sawicki
a606fc516b
💄
2015-01-06 20:26:45 -08:00
Nathan Sobo
2c1f8ce733
Set the style element priority based on the group
...
This ensures that elements are always in the desired order regardless
of the order the groups are added.
2015-01-06 19:41:57 -07:00
Nathan Sobo
62adc98b17
Use ‘user’ group for user style sheet instead of ‘userTheme’
2015-01-06 19:33:39 -07:00
Nathan Sobo
94e12ee886
Handle priority in when inserting style elements in style manager
2015-01-06 19:33:14 -07:00
Nathan Sobo
4c74b07b22
Order style elements by priority
2015-01-06 19:14:54 -07:00
Ben Ogle
3b5bb1501c
💄
2015-01-06 17:09:59 -08:00