Commit Graph

6930 Commits

Author SHA1 Message Date
Nathan Sobo
85ab86df10 Merge branch 'master' into ns-use-display-layers 2016-04-05 16:40:41 -06:00
Antonio Scandurra
bef7539e34 Refactor DisplayBuffer to DecorationManager
This commit moves all the remaining concerns not related to decorations
out of `DisplayBuffer` and into `TextEditor`. This means the
`DisplayBuffer` is now free to be renamed to `DecorationManager`.
2016-04-05 18:43:08 +02:00
Antonio Scandurra
712b1f1f88 Fix LanguageMode specs
Also, avoid creating folds twice for the same position when calling
`foldAll`.
2016-04-05 14:19:59 +02:00
Antonio Scandurra
544b75c7b0 🔥 💚 Fix TokenizedBuffer specs 2016-04-05 12:19:45 +02:00
Antonio Scandurra
80b956e996 💚 Fix TextDecorationLayer API specs in TokenizedBuffer 2016-04-05 11:39:06 +02:00
Antonio Scandurra
e6cfb8d587 Use a zero-width nbsp as our fold character 2016-04-05 11:34:14 +02:00
Antonio Scandurra
a083a754a5 💚 Fix TextEditorPresenter specs 2016-04-05 11:12:51 +02:00
Antonio Scandurra
108513f994 Fix LinesYardstick specs to use the new tagCode-based scope structure
Also, remove specs testing RTL behavior. They don’t work as of today,
and I think we need a better approach to handle them, that doesn’t
solely rely on the DOM, but actually takes into account that e.g. (0, 0)
is the rightmost character on a right-to-left string.
2016-04-05 10:47:25 +02:00
Nathan Sobo
402a335eef Fix accented character menu spec 2016-04-04 19:50:39 -06:00
Nathan Sobo
a99ee14ac0 Make accented character menu detection work with left/right arrow keys 2016-04-04 17:47:36 -06:00
Nathan Sobo
bbef4c67c3 Get the TextEditorComponent specs green 2016-04-04 11:21:41 -06:00
Antonio Scandurra
fd960e9a37 Merge branch 'master' into ns-use-display-layers 2016-04-04 15:25:50 +02:00
Michelle Tilley
8575b38c7b Pending pane items shouldn't be made permanent before being replaced
Previously, when a Pane would replace a pending item with
another pending item, it would emit
`onItemDidTerminatePendingState` for that item, which was
not true because the item was actually being destroyed.
2016-04-02 17:48:24 -07:00
Antonio Scandurra
c735b3fe74 Merge pull request #11314 from atom/as-handle-update-error
Handle auto-updater errors
2016-04-01 09:09:37 +02:00
Antonio Scandurra
fa469121d8 Ensure getErrorMessage() works properly 2016-04-01 09:09:25 +02:00
Antonio Scandurra
51d71b4b55 Merge pull request #11325 from atom/as-fix-emojis
Fix emoji rendering on OSX
2016-03-31 17:45:58 +02:00
Antonio Scandurra
47bbd8b4bb Ensure we test for emojis only on Darwin 2016-03-31 17:45:32 +02:00
Antonio Scandurra
d89d34f4ef 💚 2016-03-31 13:02:52 +02:00
Antonio Scandurra
3fb2749583 Merge pull request #11324 from atom/as-jordanbtucker-config-save-state
Add restorePreviousWindowsOnStart setting
2016-03-31 11:56:43 +02:00
Antonio Scandurra
cd41b1a0ca Improve assertion
This allows us to test that the configuration can be changed outside of Atom.
2016-03-31 10:40:57 +02:00
Antonio Scandurra
4d4ee6bf3b Add applicationDelegate.getAutoUpdateManagerErrorMessage()
Sometimes, the error event gets emitted before the renderer process has
the chance to subscribe. Therefore, we expose an
`autoUpdateManager.getErrorMessage()` in the browser process, so that we
don’t lose that information.
2016-03-31 10:16:11 +02:00
Machisté N. Quintana
36be446060 Merge pull request #6631 from atom/mq-move-selected-columns
Add commands to move selections left and right by one column
2016-03-30 22:30:19 -07:00
joshaber
3b162717b4 Merge branch 'master' into serialize-async-git 2016-03-30 16:40:01 -04:00
joshaber
f19d3a2bce Unfocus. 2016-03-30 11:59:35 -04:00
joshaber
e701fcc292 Rename work queue to resource pool. 2016-03-30 11:47:05 -04:00
joshaber
f028c779b1 Treat it more like a pool. 2016-03-30 11:44:24 -04:00
Antonio Scandurra
2d5e697016 Add AutoUpdateManager.prototype.onUpdateError 2016-03-30 15:05:57 +02:00
joshaber
f1516f7de4 First pass at using the work queue. 2016-03-29 23:54:39 -04:00
joshaber
36121e3bf8 First pass at the git work queue. 2016-03-29 22:59:24 -04:00
Nathan Sobo
265aa2f6c8 Warn rather than failing if we detect leaked pathwatcher subscriptions 2016-03-29 16:46:57 -06:00
Antonio Scandurra
ea01981a85 Merge pull request #11286 from atom/as-fix-pane-axis-element-subscriptions
Correctly (un)subscribe to model events on PaneAxisElement attach/detach
2016-03-29 09:46:10 +02:00
Machiste Quintana
3b222dbee8 Don't merge selections if at start or end of line 2016-03-28 23:26:28 -07:00
Machiste Quintana
e932e3db05 Merge branch 'master' into mq-move-selected-columns 2016-03-28 22:16:31 -07:00
Antonio Scandurra
8adf47b1c2 Allow element to work without attaching it to DOM 2016-03-28 16:40:39 +02:00
Antonio Scandurra
ae277c685f Merge branch 'master' into as-fallback-to-storage-folder 2016-03-28 15:50:14 +02:00
Antonio Scandurra
b5f866b6fc Correctly (un)subscribe to model events on PaneAxisElement attach/detach 2016-03-28 14:49:26 +02:00
Antonio Scandurra
f9fb93f214 🎨 2016-03-25 16:37:01 +01:00
Antonio Scandurra
c609f6c967 Destroy DisplayLayer upon DisplayBuffer destruction 2016-03-25 10:53:02 +01:00
Antonio Scandurra
0a634a5870 💚 Fix more tests using tokenizedLineForScreenRow 2016-03-25 10:49:32 +01:00
Antonio Scandurra
27aad42644 Handle tab length retokenization in DisplayLayer
We still want to keep the tab length in TokenizedBuffer, because we need
it to understand if a certain buffer row is foldable or not (due to the
indent level)
2016-03-25 10:33:12 +01:00
Antonio Scandurra
e6cb5c8e89 🐛 Guard against unexisting screen rows 2016-03-24 15:57:24 +01:00
Antonio Scandurra
87489d4b0b Fix TextEditor cutToEndOfLine() test
…which was failing due to the different soft-wrapping rules.
2016-03-24 14:15:06 +01:00
Antonio Scandurra
4136e27d44 Fix TextEditor backspace() and delete() specs 2016-03-24 13:58:58 +01:00
Antonio Scandurra
cbb911cde8 💚 2016-03-23 13:44:17 +01:00
Antonio Scandurra
c2242e46c2 Read state from StorageFolder when it can’t be found in StateStore 2016-03-23 10:31:26 +01:00
Antonio Scandurra
3d9835bbbd 💚 WIP: Continue fixing TextEditor specs 2016-03-22 16:05:38 +01:00
Antonio Scandurra
326f2c6a9e Add TextEditor.prototype.tokensForScreenRow for testing purposes 2016-03-22 14:49:42 +01:00
Antonio Scandurra
227670a407 Merge branch 'master' into ns-use-display-layers 2016-03-22 12:01:07 +01:00
Antonio Scandurra
34f9ad8710 Add top/bottom ruler before/after a block decoration 2016-03-22 11:20:55 +01:00
Michelle Tilley
449abd7364 Revert "Revert "Add spec for inserting white-space-only lines""
This reverts commit fd17457c17.
2016-03-21 16:27:41 -07:00