github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-01 18:25:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
28,423 Commits 140 Branches 571 Tags
afdd8d2b6dce2de309ceafb02dfd5dc20c4f89fb
Commit Graph

28423 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nathan Sobo
a99ee14ac0 Make accented character menu detection work with left/right arrow keys 2016-04-04 17:47:36 -06:00
Isaac Salier-Hellendag
2a7344091d Avoid setting hidden input value on textInput 
Atom currently sets the `value` of the input on every `textInput` event, in an effort to appropriately handle changes made via the OSX diacritic menu (for accents, umlauts, etc).

The drawback of this is approach is that updating the value of the input will trigger layout and a subsequent layer tree update.

To resolve this, here is my proposal:

  - Track a flag for `keypress` events. When the diacritic menu is used, there are two `textInput` events, with no `keypress` in between. Therefore, when no `keypress` has occurred just prior to a `textInput`, the editor model can select the previous character to be replaced by the new accented character.
  - Track a flag for `compositionstart` events. When a user is in IME mode, the diacritic menu cannot be used, so the editor can skip the backward selection.

Test Plan:

Tested in a plaintext file.

  - Type Latin characters, verify proper character insertion.
  - Press and hold <kbd>a</kbd>. Diacritic menu appears. Select an option using the keyboard or mouse. Verify that the `a` is replaced by an accented `a`, with no extra characters.
  - Type test strings in Katakana, 2-Set Korean, Telex (Vietnamese), Simplified Pinyin. Verify that characters are inserted correctly while composing, and after committing strings.
 2016-04-04 13:33:43 -07:00
Damien Guard
5c8669a4e8 Merge pull request #11246 from damieng/dg-windows-build-improve 
Improve the Windows build process
 2016-04-04 15:23:21 -04:00
Nathan Sobo
bbef4c67c3 Get the TextEditorComponent specs green 2016-04-04 11:21:41 -06:00
Antonio Scandurra
fd960e9a37 Merge branch 'master' into ns-use-display-layers 2016-04-04 15:25:50 +02:00
Michelle Tilley
8575b38c7b Pending pane items shouldn't be made permanent before being replaced 
Previously, when a Pane would replace a pending item with
another pending item, it would emit
`onItemDidTerminatePendingState` for that item, which was
not true because the item was actually being destroyed.
 2016-04-02 17:48:24 -07:00
Wliu
f1cf66ba32 ⬆️ language-csharp@0.12.1 2016-04-02 10:42:55 -04:00
Wliu
5b8315e37c Merge pull request #11351 from atom/fk_update_language-perl 
⬆️ language-perl@0.33.0
 2016-04-02 10:20:59 -04:00
Florian Kinder
3d8ce38e6b ⬆️ language-perl@0.33.0 2016-04-02 15:37:59 +02:00
Wliu
0330e33667 ⬆️ language-c@0.51.3 2016-04-01 21:56:56 -04:00
Antonio Scandurra
4d52479ce3 Merge pull request #11345 from atom/as-fix-pinch-to-zoom 
Disable zoom every time a display gets added or removed
 2016-04-01 18:21:46 +02:00
Antonio Scandurra
793f5f9692 Disable zoom every time a display gets added or removed 2016-04-01 16:04:01 +02:00
Wliu
2c05b9bf68 Merge pull request #11339 from coliff/patch-4 
HTTPS a couple of links
 2016-04-01 09:28:18 -04:00
Antonio Scandurra
5464883c1e Merge pull request #11341 from atom/as-fix-auto-updater-events 
Use application-level events to control updates in the browser process
 2016-04-01 14:14:52 +02:00
Antonio Scandurra
158d019371 Use application-level events to control updates in the browser process 2016-04-01 10:56:30 +02:00
simurai
9b4e451333 ⬆️ solarized-dark/light-syntax@v1.0.2 2016-04-01 17:27:14 +09:00
Antonio Scandurra
2b05995b1c ⬆️ about 2016-04-01 09:12:01 +02:00
Antonio Scandurra
c735b3fe74 Merge pull request #11314 from atom/as-handle-update-error 
Handle auto-updater errors
 2016-04-01 09:09:37 +02:00
Antonio Scandurra
fa469121d8 Ensure getErrorMessage() works properly 2016-04-01 09:09:25 +02:00
Christian Oliff
bb11c4e5bd HTTPS a couple of links 
HTTPS a couple of links
 2016-04-01 15:20:00 +09:00
simurai
6f1c1fd0e0 ⬆️ one-dark/light-ui@v1.3.1 2016-04-01 11:17:57 +09:00
Nathan Sobo
34e2bf13ce Add native profiling instructions 2016-03-31 16:59:36 -06:00
Lee Dohm
a058f3721f Merge pull request #11316 from atom/ld-issue-template-os-version 
Add request for OS and version to Issue Template
 2016-03-31 10:31:15 -07:00
Antonio Scandurra
51d71b4b55 Merge pull request #11325 from atom/as-fix-emojis 
Fix emoji rendering on OSX
 2016-03-31 17:45:58 +02:00
Antonio Scandurra
47bbd8b4bb Ensure we test for emojis only on Darwin 2016-03-31 17:45:32 +02:00
Damien Guard
0f615ff4e6 Merge pull request #11329 from atom/tj-fix-nullref-callback 
Fix potential null reference callback invokation in script/clean
 2016-03-31 08:27:18 -04:00
Thomas Johansen
22acdb76f6 🐛 Fix potential null reference callback invokation 
Fixes #11328
 2016-03-31 13:24:14 +02:00
Antonio Scandurra
d89d34f4ef 💚 2016-03-31 13:02:52 +02:00
Antonio Scandurra
dea5c5560e ⬆️ bracket-matcher 2016-03-31 12:03:26 +02:00
Antonio Scandurra
3fb2749583 Merge pull request #11324 from atom/as-jordanbtucker-config-save-state 
Add restorePreviousWindowsOnStart setting
 2016-03-31 11:56:43 +02:00
Antonio Scandurra
d568c76b0b 🍎 Fix emoji rendering 2016-03-31 11:44:32 +02:00
Antonio Scandurra
296c016bf8 🐎 Don't load state when restorePreviousState is false 2016-03-31 10:41:23 +02:00
Antonio Scandurra
cd41b1a0ca Improve assertion 
This allows us to test that the configuration can be changed outside of Atom.
 2016-03-31 10:40:57 +02:00
Antonio Scandurra
4d4ee6bf3b Add applicationDelegate.getAutoUpdateManagerErrorMessage() 
Sometimes, the error event gets emitted before the renderer process has
the chance to subscribe. Therefore, we expose an
`autoUpdateManager.getErrorMessage()` in the browser process, so that we
don’t lose that information.
 2016-03-31 10:16:11 +02:00
Machisté N. Quintana
36be446060 Merge pull request #6631 from atom/mq-move-selected-columns 
Add commands to move selections left and right by one column
 2016-03-30 22:30:19 -07:00
Josh Abernathy
0a657fc053 Merge pull request #11320 from atom/bump-nodegit 
Update nodegit
 2016-03-30 20:42:45 -04:00
Josh Abernathy
a15da5fa01 Merge pull request #11315 from atom/serialize-async-git 
Serialize async git
 2016-03-30 20:42:23 -04:00
Nathan Sobo
4dd6f4acd7 ⬆️ atom-keymap 2016-03-30 16:26:56 -06:00
Nathan Sobo
81d3a23c95 ⬆️ text-buffer 2016-03-30 16:13:30 -06:00
joshaber
3b162717b4 Merge branch 'master' into serialize-async-git 2016-03-30 16:40:01 -04:00
joshaber
b3a2680fab ⬆️ nodegit@0.12.1 2016-03-30 16:33:25 -04:00
Machisté N. Quintana
3068631d19 Don't open a transaction if there's a selection at the start / end of line 2016-03-30 12:48:11 -07:00
Lee Dohm
ceaeef8675 Add request for OS and version 2016-03-30 09:36:59 -07:00
joshaber
f19d3a2bce Unfocus. 2016-03-30 11:59:35 -04:00
joshaber
f59a86b2b9 Note that we're not using this yet. 2016-03-30 11:51:49 -04:00
joshaber
dea119ef3e Less repo-centric naming. 2016-03-30 11:50:05 -04:00
joshaber
e701fcc292 Rename work queue to resource pool. 2016-03-30 11:47:05 -04:00
joshaber
f028c779b1 Treat it more like a pool. 2016-03-30 11:44:24 -04:00
joshaber
6ba2f6d4b8 Pull refresh outside the work function. 
Otherwise we deadlock lolololol
 2016-03-30 11:23:54 -04:00
joshaber
c0e9fde590 Re-organize to prevent recursive work queueing. 2016-03-30 11:17:58 -04:00