Commit Graph

8716 Commits

Author SHA1 Message Date
Ash Wilson
efeb2cdb0a stat locations in parsePathToOpen() 2019-04-18 16:11:02 -04:00
Ash Wilson
f66002e193 Create stubbed AtomWindows instead of real ones in app tests 2019-04-18 10:51:25 -04:00
Ash Wilson
87a4213b6a Rewrite AtomApplication::openPaths() logic to find existing windows 2019-04-17 15:56:49 -04:00
Ash Wilson
9b40488652 Replace tests for scenarios I observed with tests for scenarios we want 2019-04-17 15:18:29 -04:00
Ash Wilson
1fc2f9b4ba Increase beforeEach, afterEach, and emitterEventPromise timeouts
This is to temporarily work around spikes in the window launch time.
2019-04-17 15:09:44 -04:00
Ash Wilson
9af51897f0 Override and restore ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT 2019-04-17 14:09:43 -04:00
Ash Wilson
b3ab30dcf5 Abstract "wait for window to finish loading" logic 2019-04-17 14:09:19 -04:00
Ash Wilson
b591f83447 Avoid binding expectOpenEvent into the closure 2019-04-17 13:09:56 -04:00
Ash Wilson
4f8de4bb0a Comment on launch scenarios that correspond to file manager launches 2019-04-17 13:09:29 -04:00
Ash Wilson
58c6292905 Tests for the remaining command-line cases 2019-04-17 10:24:03 -04:00
Ash Wilson
fc1af26e34 Show "incorrect window" banner for mismatched results 2019-04-17 10:23:22 -04:00
Ash Wilson
2f48ad097b Boolean logic is hard okay 2019-04-17 10:23:07 -04:00
Ash Wilson
bc4a22f97a Resolve root and editor paths during spec parsing for consistency 2019-04-17 10:22:51 -04:00
Ash Wilson
a53398daf7 Allow file references by basename or short path 2019-04-16 16:00:31 -04:00
Ash Wilson
f0dc842293 Distinguish between launch and open 2019-04-16 16:00:12 -04:00
Ash Wilson
58bd9bfa33 Don't open all precondition windows twice (oops) 2019-04-16 15:59:46 -04:00
Ash Wilson
2a50d87999 Use a single application to launch all precondition windows 2019-04-16 15:59:08 -04:00
Ash Wilson
08a29df12f Omit untitled editors (at least for now) 2019-04-16 15:38:03 -04:00
Ash Wilson
8e15d9656a Log missing roots instead of extra roots twice 2019-04-16 15:37:45 -04:00
Ash Wilson
d3b5ce0b4b Use _ for an empty project root or editor path group
Co-Authored-By: Jason Rudolph <jason@jasonrudolph.com>
2019-04-16 15:37:01 -04:00
Ash Wilson
839544e0a9 Launch scenario test framework 2019-04-16 14:56:03 -04:00
Nathan Sobo
57d00b6f09 Merge pull request #18471 from Aerijo/comment-cursor-placement
Toggle comment cursor placement
2019-04-10 10:10:42 -06:00
Nathan Sobo
513a38bcea Unfocus test 🙈 2019-04-09 10:54:01 -06:00
Rafael Oleza
6b61f14c3b Wait until the editor is ready on application test 2019-04-09 16:00:47 +02:00
Rafael Oleza
dbe00f616a Fix atom-application tests
When closing a window with a file that does not exist, Atom opens a
dialog asking the users if they want to save the changes. This dialog
prevented the tests from finishing correctly.
2019-04-09 13:18:02 +02:00
Nathan Sobo
397d427568 Fix lint error 2019-04-08 17:16:50 -06:00
Nathan Sobo
6277cefa07 Clean up assertion style
I prefer to express only one assertion per line rather than &&-ing 
together multiple assertions into a condition. I also prefer to use 
equality assertions so that failure messages include more information 
about the actual and expected values.

I used nested scope blocks so we could re-define the `range` constant in 
a local scope without needing to mutate a variable across unrelated 
tests.
2019-04-08 16:57:35 -06:00
Nathan Sobo
47368136d8 Fix syntax error that caused test not to run and some problems with test 2019-04-08 16:45:34 -06:00
Nathan Sobo
218086d379 Merge branch 'master' into comment-cursor-placement 2019-04-08 16:19:25 -06:00
Max Brunsfeld
f861d89fd3 Revert "Merge pull request #19060 from atom/mb-tree-sitter-0-14"
This reverts commit 386b153878, reversing
changes made to 5a4cfeb12c.
2019-04-08 10:08:02 -07:00
Rafael Oleza
e0755959da Merge pull request #19116 from atom/test-build
Make sure that Atom does not get autoupdated when running main process tests
2019-04-08 16:01:30 +02:00
Rafael Oleza
3f11d71dc0 Make sure that Atom does not get autoupdated when running main process tests 2019-04-08 14:09:15 +02:00
Max Brunsfeld
386b153878 Merge pull request #19060 from atom/mb-tree-sitter-0-14
Update tree-sitter to v0.14.0
2019-04-07 14:26:11 -07:00
Rafael Oleza
7ad8976a00 Do not check for order of windows in test
The order is not deterministic on Windows, since it depends on focus
state
2019-04-05 17:13:53 +02:00
Rafael Oleza
df54e900d5 Add test to ensure that the piping logic works as expected 2019-04-05 17:13:53 +02:00
Rafael Oleza
f04a00ac2d Remove --socket-path CLI argument 2019-04-04 17:55:58 +02:00
Rafael Oleza
2656d4a846 Merge pull request #19058 from rafeca/fix-reopen-project
Fix reopen project when there are no open windows
2019-03-27 16:21:45 +01:00
Max Brunsfeld
71200e8edd ⬆️ tree-sitter to 0.14.0 2019-03-26 17:30:32 -07:00
Rafael Oleza
4fd800328a Do not delete global scope setting when resetting user settings 2019-03-26 19:19:59 +01:00
Rafael Oleza
9f453e64fe Fix reopen project when there are no open windows 2019-03-26 17:01:38 +01:00
Ash Wilson
e88e06e572 Whitespace I guess 2019-03-13 15:19:07 -04:00
Ash Wilson
2ced6c8d63 Symlink or copy packages from the user's real ATOM_HOME 2019-03-13 15:18:58 -04:00
Rafael Oleza
ec705399e6 Remove uneeded methods from async-spec-helpers modules 2019-03-01 12:05:21 +01:00
Rafael Oleza
67afbe6097 Stop using promisifySome 2019-03-01 12:05:21 +01:00
Rafael Oleza
a93808d1a8 Always use global it, beforeEach and afterEach methods 2019-02-28 20:39:21 +01:00
Rafael Oleza
2dd2c299b3 Keep unneeded block in TextEditor spec as it's a common pattern 2019-02-28 19:30:03 +01:00
Rafael Oleza
ccfd761a06 Fix linting issue after rebase 2019-02-28 19:30:03 +01:00
Rafael Oleza
6c46cf9243 Fix remaining linter issues 2019-02-28 19:30:03 +01:00
Rafael Oleza
cd302135f0 Fix undefined variables from specs 2019-02-28 19:30:03 +01:00
Rafael Oleza
d7d6d0838f Remove unused vars from specs 2019-02-28 19:30:03 +01:00