github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-16 01:25:13 -05:00
Code Issues Packages Projects Releases Wiki Activity
32,368 Commits 140 Branches 571 Tags
b2f20149d1500479a49dceca9ff4a12919c3dab4
Commit Graph

32368 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Max Brunsfeld
a7736b81e3 Remove code for preserving cursor position on buffer reload 
Updating the markers correctly is handled by TextBuffer. This
was actually breaking it.
 2017-06-02 09:58:57 -07:00
Jason Rudolph
5b61c0a949 🐛 Initialize active editor state correctly after reload 
Fixes the following bug:

1. Open Atom
2. Open a file
3. Observe the file's encoding in the status bar
4. Reload Atom
5. Close the file
6. Observe that the closed file's encoding is still present in the
status bar

This bug occured because the reload did not deserialize/serialze the
workspace's active text editor state. As a result, when closing the
text editor in step 5, we failed to notify observers that there is no
longer an active text editor.
 2017-06-02 08:01:42 -04:00
simurai
84d07e351c Merge pull request #14657 from atom/sm-atomicons 
Atomicons
 2017-06-02 11:47:50 +09:00
simurai
d2d3645646 Merge branch 'master' into sm-atomicons 2017-06-02 09:55:58 +09:00
Max Brunsfeld
345b9e6af4 ⬆️ text-buffer and pathwatcher (prerelease) 2017-06-01 16:11:44 -07:00
Max Brunsfeld
021f934ccd Fix Pane.close test 2017-06-01 15:48:08 -07:00
Max Brunsfeld
307d63e1ed Fix handling of aborted save in Pane.saveItem 2017-06-01 15:10:09 -07:00
Max Brunsfeld
7535a9419f Use async/await in Pane spec 2017-06-01 14:42:45 -07:00
Jason Rudolph
5dfbb65b0e 🎨 Reduce ternaries 2017-06-01 17:09:38 -04:00
Jason Rudolph
6a694f80f4 🎨 Replace instanceof check with nullness check 
xref: https://github.com/atom/atom/pull/14695#discussion_r119721719
 2017-06-01 17:04:43 -04:00
Jason Rudolph
fe550a1b03 🎨 Refactor: Introduce explaining variable 
xref: https://github.com/atom/atom/pull/14695#discussion_r119721719
 2017-06-01 17:04:17 -04:00
Ash Wilson
d16996f9c4 ⬆️ github 2017-06-01 16:34:44 -04:00
Max Brunsfeld
d50a9fac33 Merge branch 'master' into mb-use-native-text-buffer 2017-06-01 12:51:00 -07:00
Max Brunsfeld
a3240e78f8 ⬆️ pathwatcher (prerelease) 2017-06-01 12:50:21 -07:00
Jason Rudolph
14d8eccc6e 📝 Add API docs for observeActiveTextEditor(callback) 2017-06-01 15:47:31 -04:00
Jason Rudolph
5b52d8c77a 📝 Add API docs for onDidChangeActiveTextEditor(callback) 2017-06-01 15:44:37 -04:00
Jason Rudolph
09495dfc35 🔥 Remove broken Dock::getTextEditors() function 
We're updating Atom to disallow editors in docks. As a result, we need
to remove Dock::getTextEditors(). Normally, we would deprecate a method
before removing it, but this method is broken and has never worked:

  atom.workspace.getLeftDock().getTextEditors()
  (unknown) Uncaught TypeError: this.paneContainer.getTextEditors is not a function
      at Dock.getTextEditors (/Applications/Atom.app/Contents/Resources/app/src/dock.js:590:37)
      at <anonymous>:1:30

Since the method is broken, we know that nobody is relying on it.
Instead of deprecating the method, we can just remove it.
 2017-06-01 15:31:21 -04:00
Jason Rudolph
0b314ac1a9 🔥 Remove broken Dock::observeTextEditors(callback) fn 
We're updating Atom to disallow editors in docks. As a result, we need
to remove Dock::observeTextEditors(callback). Normally, we would
deprecate a method before removing it, but this method is broken and has
never worked:

  atom.workspace.getLeftDock().observeTextEditors(console.log)
  (unknown) Uncaught TypeError: this.paneContainer.getTextEditors is not a function
      at Dock.getTextEditors (/Applications/Atom.app/Contents/Resources/app/src/dock.js:590:37)
      at Dock.observeTextEditors (/Applications/Atom.app/Contents/Resources/app/src/dock.js:396:41)
      at <anonymous>:1:30
  getTextEditors @ <embedded>:29933
  observeTextEditors @ <embedded>:29739
  (anonymous) @ VM1941:1

Since the method is broken, we know that nobody is relying on it.
Instead of deprecating the method, we can just remove it.
 2017-06-01 15:26:12 -04:00
Jason Rudolph
f8ebd71200 Deprecate Dock::getActiveTextEditor() 2017-06-01 15:24:50 -04:00
Damien Guard
1d0bd5359f ⬆️ status-bar 2017-06-01 12:11:49 -07:00
Damien Guard
0f58b3f5cf ⬆️ fs-plus 2017-06-01 12:09:05 -07:00
Max Brunsfeld
16b1d7359f Convert pane spec to JS 2017-06-01 11:42:18 -07:00
Max Brunsfeld
12d0de0e03 Merge branch 'master' into mb-use-native-text-buffer 2017-06-01 11:09:09 -07:00
Max Brunsfeld
a94bf5b4bf ⬆️ tabs 2017-06-01 10:50:57 -07:00
Jason Rudolph
e569f8fc4d 📝 Fix odd grammar in API docs 2017-06-01 12:08:09 -04:00
Lee Dohm
50603ef19c Merge pull request #14697 from atom/ld-activate-item-docs 
📝 Add missing parameter documentation
 2017-06-01 08:26:20 -07:00
Antonio Scandurra
a25134e97f Recycle line number nodes 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-06-01 17:24:18 +02:00
Lee Dohm
fdd4d52fcc 📝 Add missing parameter documentation 2017-06-01 08:24:14 -07:00
Antonio Scandurra
b8d0d83b9a Recycle line nodes 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-06-01 17:24:13 +02:00
Antonio Scandurra
7b2a3075cb Merge pull request #14694 from atom/ns-as-fix-line-number-hiding 
Render line number gutter without numbers when showLineNumbers is false
 2017-06-01 17:23:18 +02:00
Antonio Scandurra
6d1f8ea88c Render line number gutter without numbers when showLineNumbers is false 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-06-01 16:29:04 +02:00
simurai
3425692b14 🎨 Rename "entity" to "type" 2017-06-01 22:51:46 +09:00
Jason Rudolph
16e1ef917b Update Workspace specs regarding editors in docks 2017-06-01 09:34:56 -04:00
Antonio Scandurra
7ef498d53c Merge pull request #14693 from atom/as-ns-fix-overlay-resize-observers 
Skip overlay resize events when we already measured at the current size
 2017-06-01 14:44:48 +02:00
Antonio Scandurra
23e26da2fb Skip overlay resize events when we already measured at the current size 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-06-01 14:44:06 +02:00
simurai
c1534d7d2d Use .icon class for atomicons 2017-06-01 20:57:57 +09:00
Nathan Sobo
2372227b00 Fix specs on macOS when "Show scroll bars" option isn't "always" 2017-06-01 12:01:11 +02:00
simurai
d9337a453a Capitalize font name 2017-06-01 17:19:45 +09:00
Antonio Scandurra
44a442c08a Merge pull request #14686 from atom/as-ns-prevent-browser-autoscroll 
Try a different approach for preventing autoscroll to off-screen input
 2017-06-01 10:17:22 +02:00
simurai
bae7b6c0de Update refined icons 
Now they should snap to whole pixels
 2017-06-01 14:22:46 +09:00
Max Brunsfeld
756f2ec679 ⬆️ text-buffer (prerelease) 2017-05-31 17:46:26 -07:00
Max Brunsfeld
dc320181fc Fix handling of .save and .saveAs rejections 
* Make Pane.close, Pane.saveActiveItem, and Pane.saveActiveItemAs async.
* Refactor the logic for prompting to save on window unload
 2017-05-31 17:46:04 -07:00
Jason Rudolph
05efc143ed Add Workspace::observeActiveTextEditor() 2017-05-31 16:17:54 -04:00
Jason Rudolph
cf50625cc6 Teach Workspace::getActiveTextEditor() to get item from center 2017-05-31 14:32:20 -04:00
Jason Rudolph
61a52d49aa Allow text editors in the workspace center, but not in docks 2017-05-31 14:06:46 -04:00
Jason Rudolph
cd24e820f5 💚 Fix linter failure 2017-05-31 13:13:09 -04:00
Max Brunsfeld
798bbfcae8 ⬆️ text-buffer (prerelease) 2017-05-31 09:41:32 -07:00
Jason Rudolph
8cae9a1365 🎨 Refactor: Extract getVisiblePanes() function 2017-05-31 12:01:10 -04:00
Jason Rudolph
0e3dfc3ba1 🎨 Refactor: Extract getVisiblePaneContainers() function 2017-05-31 11:57:57 -04:00
Jason Rudolph
fc007edddd 🎨 Refactor initialization of visiblePaneContainers 
xref: https://github.com/atom/atom/pull/14640#discussion_r119169281
 2017-05-31 11:53:05 -04:00