Commit Graph

15984 Commits

Author SHA1 Message Date
Ash Wilson
931b4e7055 👕 lint lint lint 2017-08-02 12:33:06 -04:00
Ash Wilson
318708bb42 wip 2017-08-02 09:50:57 -04:00
Ash Wilson
320664a359 Remove an export I missed 2017-08-02 09:04:33 -04:00
Ash Wilson
c7a47a9e89 Use module.exports to not break Joanna horribly 2017-08-01 16:40:54 -04:00
Ash Wilson
f005fcdca1 Use directory.getPath() as the object key 2017-08-01 15:55:39 -04:00
Ash Wilson
1285a89a4b Reset @watchersByPath on atom.project.setPaths 2017-08-01 15:55:28 -04:00
Ash Wilson
ee9ad53d91 🔥 unused variables 2017-08-01 15:55:08 -04:00
Ash Wilson
b3f327b0b3 Implement atom.project.onDidChangeFiles 2017-08-01 15:08:07 -04:00
Ash Wilson
ba11070d16 Translate nsfw events to the events we're advertising 2017-08-01 15:08:07 -04:00
Ash Wilson
afdb2f13a6 Doooooocs 2017-08-01 15:08:07 -04:00
Ash Wilson
6fdeedd4ab Introduce a helper to re-join split absolute paths regardless of platform 2017-08-01 15:08:07 -04:00
Ash Wilson
4f0b52d2ab Move the global watcher registry to a lazily initialized manager 2017-08-01 15:08:07 -04:00
Ash Wilson
7aab9925a8 Rename filesystem-manager to path-watcher 2017-08-01 15:08:06 -04:00
Ash Wilson
7aeca7fc8c 🔥 FileSystemManager 2017-08-01 15:08:06 -04:00
Ash Wilson
2d8f812f56 More documentation touchups. 2017-08-01 15:08:06 -04:00
Ash Wilson
2ae70aac08 Document RegistryTree. 2017-08-01 15:08:06 -04:00
Ash Wilson
ba7275dc4f Dump the tree structure to a string for debugging 2017-08-01 15:08:06 -04:00
Ash Wilson
d4edc6b894 Extra character for some reason? 2017-08-01 15:08:06 -04:00
Ash Wilson
0b17b35244 👕 :burn: whitespace 2017-08-01 15:08:06 -04:00
Ash Wilson
2b79295d0b (Untested) work to adapt to the registry API changes 2017-08-01 15:08:06 -04:00
Ash Wilson
0c5674a56c Split subtrees into child watchers on parent watcher removal 2017-08-01 15:08:06 -04:00
Ash Wilson
a5f217fd51 WIP work on rewatching child directories 2017-08-01 15:08:05 -04:00
Ash Wilson
c2810b626c Propagate errors to subscribers with an onDidError callback 2017-08-01 15:08:05 -04:00
Ash Wilson
f75aa1ae03 Use onWillStop() instead of onDidStop()
This will prevent new Watchers from attaching to NativeWatchers that are
in the process of stopping.
2017-08-01 15:08:05 -04:00
Ash Wilson
7ec79a00fc Set running = false before the asynchronous stop operation 2017-08-01 15:08:05 -04:00
Ash Wilson
80a9126fdb Start NativeWatchers lazily and stop them opportunistically 2017-08-01 15:08:05 -04:00
Ash Wilson
9c8ed35b26 Provide native watcher creation function to the NativeWatcherRegistry constructor 2017-08-01 15:08:05 -04:00
Ash Wilson
c8882ca92b Start and stop NativeWatchers automatically using onDidChange subs 2017-08-01 15:08:04 -04:00
Ash Wilson
4194e7f3b5 Remove stopped watcher nodes with the power of RECURSION 2017-08-01 15:08:04 -04:00
Ash Wilson
be681d1324 Use a private utility function to wait for all native watchers to stop 2017-08-01 15:08:04 -04:00
Ash Wilson
12c961c8b9 Maintain a Set of living NativeWatcher instances 2017-08-01 15:08:04 -04:00
Ash Wilson
9f518736e1 Track the current NativeWatcher assigned to a Watcher 2017-08-01 15:08:04 -04:00
Ash Wilson
8d86acf19c Don't report errors after stop 2017-08-01 15:08:03 -04:00
Ash Wilson
baf71492a2 .dispose() all subscribers on a NativeWatcher 2017-08-01 15:08:03 -04:00
Ash Wilson
21e381033c Start native watchers when attached 2017-08-01 15:08:03 -04:00
Ash Wilson
e4c48a5c8c 👕 for FileSystemManager 2017-08-01 15:08:03 -04:00
Ash Wilson
bd76773412 👕 lint lint lint 2017-08-01 15:08:03 -04:00
Ash Wilson
908e5ad1e9 FileSystemManager that hands out Watchers to subscribe to filesystem events 2017-08-01 15:08:03 -04:00
Ash Wilson
a1ccd49b8e Use a tree-backed registry to deduplicate and consolidate native watchers 2017-08-01 15:08:03 -04:00
t9md
d9828cc85e should not use bind for map's callback.
map pass item index as 2nd arg, so bind is not appropriate for the
function which take 2nd arg.
2017-07-25 03:49:18 +09:00
Wliu
372cef218c 📝
[ci skip]
2017-07-19 21:06:49 -04:00
Lee Dohm
f35ca01202 Merge pull request #14795 from atom/wl-please-test-where-i-tell-you-to
Always run tests where directed
2017-07-19 15:17:52 -07:00
Wliu
b6fb15fce3 📝
[ci skip]
2017-07-19 16:21:56 -04:00
Max Brunsfeld
48abb16edb Fix exception in screenPositionForPixelPosition when content updates are pending
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-07-18 14:31:47 -07:00
Damien Guard
715576fc8b Normalize access keys (shortcuts) on buttons in dialogs 2017-07-17 10:56:49 -07:00
Bryant Ung
c50f73e9f5 Merge pull request #15011 from mehcode/gutter-marker-layer-bug
Check if incoming element is non-null before attempting to append to it
2017-07-13 22:29:44 -07:00
Damien Guard
cf43c03e69 Merge pull request #14997 from atom/dg-fix-reload-window-with-new-paths
Ensure window:reload doesn't forget added project folders
2017-07-13 12:33:33 -07:00
Antonio Scandurra
c3f7edc104 Swap underlying editor correctly when calling setModel on editor element
Previously, when `setModel` was called, we forgot to update the pointer
to the component in the newly supplied editor. This was causing the
element to not update in response to model updates but only as a result
of focus or visibility changes. We suspect this regressed during the
rewrite of the editor rendering layer.

With this commit we will now correctly swap the element's underlying
editor by updating the component pointer on the newly supplied editor.
Also, if the element was already attached to another editor, we will
null out the component reference on it, because one instance of
`TextEditorElement` can only represent one instance of `TextEditor`.
2017-07-13 18:13:48 +02:00
Ryan Leckey
d0588cd812 Check if incoming element is non-null before attempting to append to it 2017-07-13 02:32:43 -07:00
Damien Guard
5e04edfc43 Merge pull request #14690 from atom/dg-add-keyboard-accelerators
Add keyboard accelerators to file change & window state dialogs
2017-07-12 15:04:12 -07:00