Wliu
2bf9e4b0c7
Use scope names rather than names
...
Some languages are not guaranteed to have names
2017-10-25 17:36:21 +02:00
Josh Soref
ee87ac1604
spelling: falsy
2017-09-10 15:46:39 +00:00
Wliu
8963cf4955
Only use multiline if the flag is passed in
2017-08-10 13:24:46 -04:00
Wliu
95b216f234
Add multiline spec
2017-08-09 23:15:33 -04:00
Ash Wilson
dc9fe25255
Wrap temp.cleanupSync() calls in try-catch blocks
2017-08-04 14:18:43 -04:00
Wliu
9b99c863e0
Add JSDoc to the mix
2017-07-14 00:14:04 -04:00
Max Brunsfeld
2420d12e44
Merge pull request #14435 from atom/mb-use-native-text-buffer
...
Use new native text-buffer implementation
2017-06-08 16:50:53 -07:00
Jason Rudolph
5d7e9a622f
Merge pull request #14640 from atom/jr-directional-pane-navigation-for-entire-workspace
...
Teach directional pane navigation commands to support docks
2017-06-08 19:15:33 -04:00
Max Brunsfeld
3b56ef8cbf
Merge remote-tracking branch 'origin/master' into mb-use-native-text-buffer
2017-06-06 17:12:34 -07:00
Jason Rudolph
5c5fb28da1
✅ Add test for getVisiblePaneContainers()
2017-06-05 17:44:41 -04:00
Jason Rudolph
110bd6a16e
✅ Add test for Workspace::getVisiblePanes()
2017-06-05 17:29:46 -04:00
Jason Rudolph
2347c9bdaa
Always invoke callback with current active text editor
...
This makes observeActiveTextEditor consistent with observers like
observeActivePaneItem, which always invoke the callback with the current
value, regardless of whether that value is undefined or not.
2017-06-02 15:55:00 -04:00
Jason Rudolph
44a2be7c9d
Test deserialization in terms of user-observable functionality
...
- Rework serialization/deserialization test
- Move simulateReload function so that it can be used in multiple
describe blocks
2017-06-02 15:30:53 -04:00
Jason Rudolph
5b61c0a949
🐛 Initialize active editor state correctly after reload
...
Fixes the following bug:
1. Open Atom
2. Open a file
3. Observe the file's encoding in the status bar
4. Reload Atom
5. Close the file
6. Observe that the closed file's encoding is still present in the
status bar
This bug occured because the reload did not deserialize/serialze the
workspace's active text editor state. As a result, when closing the
text editor in step 5, we failed to notify observers that there is no
longer an active text editor.
2017-06-02 08:01:42 -04:00
Jason Rudolph
16e1ef917b
Update Workspace specs regarding editors in docks
2017-06-01 09:34:56 -04:00
Max Brunsfeld
dc320181fc
Fix handling of .save and .saveAs rejections
...
* Make Pane.close, Pane.saveActiveItem, and Pane.saveActiveItemAs async.
* Refactor the logic for prompting to save on window unload
2017-05-31 17:46:04 -07:00
Jason Rudolph
05efc143ed
Add Workspace::observeActiveTextEditor()
2017-05-31 16:17:54 -04:00
Jason Rudolph
cf50625cc6
Teach Workspace::getActiveTextEditor() to get item from center
2017-05-31 14:32:20 -04:00
Max Brunsfeld
d4c05e5956
Merge branch 'master' into mb-use-native-text-buffer
2017-05-30 10:25:54 -07:00
Max Brunsfeld
eef2bf0801
Avoiding writing to fixture files in Workspace.replace tests
2017-05-20 23:35:48 -07:00
Max Brunsfeld
6c0b70f5f3
Start work on integrating new native TextBuffer version
2017-05-19 11:33:49 -07:00
Jason Rudolph
3020a61e34
Test activating next/previous pane at the workspace level
2017-05-19 10:49:51 -04:00
Nathan Sobo
048a548462
Fix specs
2017-05-10 14:18:15 -06:00
Max Brunsfeld
52195e79ff
Merge branch 'master' into fb-mdt-no-cmd-w-on-permanent-dock-items
2017-04-17 13:39:16 -07:00
Max Brunsfeld
0015e026a2
Add Workspace.paneContainerForItem method
2017-04-17 11:34:45 -07:00
Matthew Dapena-Tretter
a9d0618e88
Don't close permanent dock items
2017-04-15 13:09:08 -07:00
Max Brunsfeld
82a7a6c78a
Always search a pane container w/ the given URI in workspace.open
2017-04-12 10:23:49 -07:00
Nathan Sobo
2e066120bd
Fix workspace specs
2017-04-08 13:29:50 -06:00
Max Brunsfeld
48336fb95e
Don't use workspace's itemLocationStore in tests
2017-04-07 15:30:44 -07:00
Max Brunsfeld
63d27c5f0a
Rename Dock.isOpen to .isVisible and Dock.open to .show
2017-04-06 17:23:53 -07:00
Max Brunsfeld
233c29d998
Fix usages of Workspace.paneContainer
2017-04-06 16:37:37 -07:00
Matthew Dapena-Tretter
d133b03d7d
Remove saveFocusedPaneItem(As) methods
...
Now that dock pane items will be capable of being the workspace's
active item, there's no need to have these methods.
2017-04-06 17:26:35 -06:00
Nathan Sobo
9c28cc0fa8
Construct WorkspaceCenter's PaneContainer instance in the constructor
2017-04-06 16:57:41 -06:00
Nathan Sobo
1711d10af2
Aggregate onDidStopChangingActivePaneItem events across all containers
2017-04-06 16:35:25 -06:00
Nathan Sobo
646047f563
Maintain an active pane container on the workspace
...
This will be used by many commands that previously only interacted with
the center of the workspace.
2017-04-06 15:30:01 -06:00
Nathan Sobo
ec576b12bc
Remove PaneContainer.monitorActivePaneItem
...
Call didChangeActiveItemOnPane directly from panes and when the active
pane changes instead.
2017-04-06 13:18:18 -06:00
Nathan Sobo
5cb550b09d
Remove Pane's subclassing of Model
2017-04-06 12:06:46 -06:00
Max Brunsfeld
e40ef03008
Fix Workspace.open test for activating existing items in docks
2017-04-05 16:03:33 -07:00
Max Brunsfeld
6f0b1947ee
Use Workspace.getElement in tests
2017-04-05 15:32:00 -07:00
Max Brunsfeld
6d55371930
Add Workspace.getElement method, remove WorkspaceElement view provider
2017-04-05 15:32:00 -07:00
Nathan Sobo
6ac29939e5
Merge pull request #14125 from atom/mb-ns-open-with-item
...
Allow workspace item objects to be passed to Workspace.open
2017-04-05 12:59:03 -06:00
Matthew Dapena-Tretter
fed2372c30
Don't store default locations
...
This will probably be less confusing for developers experimenting with
changing the default location. Also, we avoid storing extra info we
don't really need.
2017-04-04 14:49:34 -07:00
Max Brunsfeld
32ff2f37d9
Merge pull request #14108 from atom/fb-mdt-remember-moved-item-positions
...
🐛 Fix observation of moved items
2017-04-04 10:20:24 -07:00
Nathan Sobo
56cefbbc63
Support passing items to Workspace.toggle and .hide
...
Also, ensure that passing an item that is not yet present in the
workspace does not interfere with resolving the location where we want
to place the item.
2017-04-04 11:18:12 -06:00
Max Brunsfeld
1552854f3b
Allow workspace item objects to be passed to Workspace.open
2017-04-04 11:18:12 -06:00
Matthew Dapena-Tretter
4ed53578ce
🐛 Fix observation of moved items
...
`PaneContainer::onDidAddPaneItem` isn't triggered on moves.
2017-03-31 16:48:49 -07:00
Matthew Dapena-Tretter
9663101671
Always add opened items to the workspace
...
This commit changes the behavior of `open()` so that the item will be
added to the workspace—even if the `activateItem` option is false.
This provides a way to open (and add) an item without activating it,
but removes the ability to open without adding. For that, we've made
the `createItemForURI()` method public 😊
2017-03-31 14:17:09 -07:00
Nathan Sobo
5557219fbc
Merge pull request #14027 from atom/fb-mdt-save-focused-pane-item
...
Add `saveFocusedPaneItem()` and call it in "core:save" command
2017-03-31 13:57:50 -06:00
Matthew Dapena-Tretter
dec52a7384
Add atom.workspace.hide()
...
This adds an method for hiding items by URI and re-implements
`toggle()` in terms of it. (tbh it's really just extracting most of
`toggle()` into a new function.)
2017-03-30 17:37:55 -07:00
Matthew Dapena-Tretter
0d12396bf3
Add saveFocusedPaneItem() and call it in "core:save" command
...
Also, do the same for "core:save-as" and `saveFocusedPaneItemAs()`.
This behavior change means that pane items in docks (#13977 ) will be
savable too.
2017-03-28 14:05:29 -07:00
