Ben Ogle
99f899dc4a
lineForScreenRow -> tokenizedLineForRow
...
The method was severely mislabeled
2014-09-03 14:42:45 -07:00
Ben Ogle
2b9b4a48ef
tokenizedLineForRow -> tokenizedLineForScreenRow
2014-09-03 14:42:45 -07:00
Ben Ogle
05bbc480b0
displayBuffer::lineForRow -> tokenizedLineForRow
2014-09-03 14:42:45 -07:00
Nathan Sobo
d753a7f38d
Merge pull request #3440 from atom/ns-exclusive-selection-intersection
...
Don’t merge adjacent non-empty selections
2014-09-03 09:24:05 -06:00
Ben Ogle
1e4fb5b4bc
nof
2014-09-02 17:44:01 -07:00
Nathan Sobo
cfd2722348
Don’t merge adjacent non-empty selections
...
This improves the behavior of #3433
2014-09-02 18:10:05 -06:00
Ben Ogle
0b34e46a1a
Merge pull request #3420 from atom/bo-update-cursor-selection-apis
...
Update cursor and selection APIs
2014-09-02 16:41:42 -07:00
Ben Ogle
dca36d1307
Reorder return values of getSelectedBufferRanges
...
The implementation does not depend on a specific order, just the test
2014-09-02 14:55:02 -07:00
Ben Ogle
a7db555030
Order the getting ranges / positions by their insertion order
2014-09-02 14:38:11 -07:00
Ben Ogle
659c05c825
Add selectToBufferPosition
2014-09-02 14:09:56 -07:00
Ben Ogle
5ea64f8b11
selectWord() -> selectWordsContainingCursors()
2014-09-02 14:03:57 -07:00
Ben Ogle
70af6198bd
selectLine -> selectLinesContainingCursors
2014-09-02 14:02:26 -07:00
Kevin Sawicki
24add494ae
Normalize project path in Project::setPath
...
This will remove consecutive slashes as well as . and ..
characters and make path comparisons accurate.
Closes atom/tree-view#191
2014-09-02 10:49:02 -07:00
Ivan Zuzak
7f14965ca8
Support selecting multiple rows with meta-click
2014-09-01 17:42:55 +02:00
Ivan Zuzak
8c36d2673b
Select row when clicking the gutter
2014-08-30 20:20:09 +02:00
Kevin Sawicki
a8a251c457
💄
2014-08-29 09:36:55 -07:00
Ben Ogle
08388d87c0
Remove getSelectionAtIndex
...
We’re going to eventually get rid of the clone in
getSelections / getCursors freeze those properties
and return them directly. Then they can operate
on the list garbage free.
2014-08-28 18:16:33 -07:00
Ben Ogle
9c53d6f014
Deprecate getCursor()
2014-08-28 18:10:18 -07:00
Ben Ogle
2fced0c1bc
Deprecate getSelection
2014-08-28 17:51:16 -07:00
Ben Ogle
271af5dd99
Add Editor::setSelectedScreenRanges()
2014-08-28 17:28:24 -07:00
Nathan Sobo
6c2bb26e77
Add Workspace::observeTextEditors and ::onDidAddTextEditor
2014-08-28 18:28:10 -06:00
Nathan Sobo
a33706ddbc
Add PaneContainer::onDidAddPaneItem and ::observePaneItems
2014-08-28 17:42:12 -06:00
Nathan Sobo
877fa40a49
Activate next pane on before invoking onDidDestroy observers
2014-08-28 17:23:49 -06:00
Nathan Sobo
cee7539e35
Add PaneContainer::observePanes and ::onDidAddPane
2014-08-28 17:22:28 -06:00
Ben Ogle
7ca5ece68a
Add methods to be symmetrical with selections
...
* getCursorsOrderedByBufferPosition
* getCursorBufferPositions
* getCursorScreenPositions
2014-08-28 16:06:44 -07:00
Nathan Sobo
b60b9f3e3a
Add Pane::observeItems
2014-08-28 16:40:54 -06:00
Ben Ogle
370ad23f7c
Remove Cursor from ::moveCursor* methods
2014-08-28 15:25:12 -07:00
Nathan Sobo
b34367ad44
💄 pane-container-spec
2014-08-28 14:42:12 -06:00
Nathan Sobo
74b2f26540
Add PaneContainer::onDidChangeActivePaneItem
2014-08-28 14:41:56 -06:00
Nathan Sobo
9487609f0c
💄 pane-container-spec
2014-08-28 14:41:56 -06:00
Nathan Sobo
1d365db9df
Use getActiveItem getter in pane-view-spec
2014-08-28 11:43:08 -06:00
Nathan Sobo
44d70aaa5b
Add Pane::onDidChangeActive()
2014-08-28 11:43:07 -06:00
Nathan Sobo
2b63f8a4ee
Add PaneContainer::onDidChangeActivePane
2014-08-28 11:43:07 -06:00
Nathan Sobo
8225f759bf
Add Pane::onWillDestroyItem()
2014-08-28 11:43:07 -06:00
Nathan Sobo
2d58d9c8b5
Add Pane::onDidActivate
2014-08-28 11:43:07 -06:00
Nathan Sobo
548018e9b2
Add spec for onDidRemoveItem observers when moving items to other panes
2014-08-28 11:43:07 -06:00
Nathan Sobo
9bd2eec4bc
Add Pane::onDidMoveItem()
2014-08-28 11:43:07 -06:00
Nathan Sobo
b8fcbe9451
Start adding event subscription methods to pane
...
This branch uses EventKit, an ultra-simple library for implementing
events. The object implementing the methods maintains its own emitter
object rather than doing a mixin like Emissary encourages. This will
make it easier for us to deprecate ::on on the object itself. Unlike
emissary, the EventKit Emitter implements a super minimalistic API that
only allows one value to be emitted and always returns a Disposable
from subscriptions.
2014-08-28 11:43:06 -06:00
Ivan Zuzak
861dff107a
💄 simplify assignment using coffeescript magic
2014-08-28 19:42:59 +02:00
Nathan Sobo
ebb02bcd37
Use public getters instead of properties in pane-spec
2014-08-28 11:42:42 -06:00
Ivan Zuzak
096255f283
Support built-in context menu items
2014-08-27 13:54:55 +02:00
Kevin Sawicki
e8cd59eaef
Waits for reloaded event from ThemeManager
...
Previously disabling a theme wouldn't wait for the full reload
to finish since and the spec would intermittently fail because
the promise was fulfilled after the spec completed and the
subscription was leaked.
2014-08-26 14:23:20 -07:00
Nathan Sobo
3371ceadf3
Add regression coverage for remeasuring characters w/ requested update
...
The problem here is that the lines in the editor no longer reflect the
lines on screen, but we're looking for line nodes corresponding to the
editor's current contents.
2014-08-25 18:16:38 -06:00
Ben Ogle
cef24a3979
Remove the react editor options
2014-08-25 12:15:34 -07:00
Ben Ogle
3d2d8c491f
rename react-editor-view -> editor-view
2014-08-25 12:07:48 -07:00
Ben Ogle
97bcdcc9b0
Rename ReactEditorView -> EditorView
2014-08-25 12:05:55 -07:00
Ben Ogle
431fab1a43
Remove the editor-view
2014-08-25 12:05:10 -07:00
Ben Ogle
f8026bb005
Require the react-editor-view where we require the editor-view
2014-08-25 12:02:38 -07:00
Ben Ogle
c3c91ae6c3
Only emit the marker-created event when the marker exists
...
This caused problems in the case of find-and-replace:select-all with
multiple editors into the same file.
* a marker is created on the TextBuffer capturing the selection
* DisplayBuffer:create-marker is fired from the first DisplayBuffer.
The marker is turned into a selection which is merged into the current
selection, deleting the marker that was created.
* DisplayBuffer::handleBufferMarkerCreated is called on the second
DisplayBuffer. The marker has been destroyed at this point, so it emits
DisplayBuffer:create-marker with undefined.
* ERROR>
Closes #3364
2014-08-25 11:42:44 -07:00
Kevin Sawicki
ecf237697b
Add react editor view spec for data grammar attrs
2014-08-25 10:22:44 -07:00
