github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-24 22:38:20 -05:00
Code Issues Packages Projects Releases Wiki Activity
25,931 Commits 140 Branches 571 Tags
c38cd48555b681067ba73eff497b115dedc90bce
Commit Graph

13137 Commits

Author SHA1 Message Date
Antonio Scandurra
c38cd48555 Bring back failure reports when running grunt run-specs 
Log output to stderr as we did before, so that grunt can, in turn, output it to
console when specs fail.

Welcome back build failures! 🎉

/cc: @nathansobo @maxbrunsfeld
 2015-10-15 09:56:13 +02:00
Antonio Scandurra
edddb6516e Remove shim to remote.process 
This doesn't seem to work as expected. I think it's just better to encourage
emitting an event like 'write-to-stdout' or using directly `remote.process`.

/cc: @nathansobo
 2015-10-15 09:55:28 +02:00
Nathan Sobo
b58b3504f4 Only load/save AtomEnvironment state if persistence is enabled 2015-10-14 22:10:51 -06:00
Nathan Sobo
dc44d11a2c Don’t load/save config if enablePersistence option is false 2015-10-14 20:05:06 -06:00
Nathan Sobo
9df40b4f4e Remove unnecessary fat arrow 2015-10-14 19:53:16 -06:00
Nathan Sobo
a6a175c4a6 Don’t hide window when reloading specs 2015-10-14 16:40:40 -06:00
Nathan Sobo
a85a8d20de Don’t register defaultTarget for keymaps in constructor after all 
We’re clearing the views on reset, so this view will end up being
different between test runs. Also, we didn’t previously always create
the workspace view in many cases, and it makes sense to apply that here.

We may want to get the default target for the keymap via a function so
we can defer view creation until one is needed.
 2015-10-14 15:57:45 -06:00
Nathan Sobo
82cbf01c5b Set useCapture to true when handling keydown events in test windows 
Prevents these events from getting intercepted by other handlers.
 2015-10-14 15:57:45 -06:00
Nathan Sobo
c1d5cdcd64 Group requires at the top of atom-environment.coffee 2015-10-14 15:57:45 -06:00
Nathan Sobo
df66ca8d73 Remove unused params 2015-10-14 15:57:45 -06:00
Max Brunsfeld
32780e2823 Merge branch 'master' into ns-alternative-test-env 
Conflicts:
	package.json
 2015-10-14 14:12:42 -07:00
Max Brunsfeld
395ffde7a1 Merge pull request #9131 from atom/mb-fix-config-unset 
Fix setting default values in config
 2015-10-14 09:51:53 -07:00
Ivan Žužak
6a0daebede Merge pull request #9096 from atom/iz-config-settings-descriptions 
Add descriptions for config settings
 2015-10-14 18:36:08 +02:00
Antonio Scandurra
f2a32eb1dc Return empty string unless configDirPath is passed 2015-10-14 18:25:25 +02:00
Ivan Zuzak
b3a7fe3fc9 Clarify how auto-detection works 2015-10-14 18:01:43 +02:00
Antonio Scandurra
6a53034a12 Move GrammarRegistry reset after Workspace 
...as some elements could still use grammars upon Workspace destruction.
 2015-10-14 17:48:47 +02:00
Antonio Scandurra
6b01811d20 Avoid stack overflow when scrolling with non-integer values 
We were mistakenly using the rounded scroll top to guard against such cases.
This fixes it by using `@realScrollTop` instead.
 2015-10-14 16:10:12 +02:00
Antonio Scandurra
789af9fc69 Use params instead of loadSettings 2015-10-14 13:01:54 +02:00
Antonio Scandurra
c5860ce6b6 🐛 Fix typo 2015-10-14 12:59:22 +02:00
Antonio Scandurra
b25d3e944b Parameterize configDirPath and move config.load in ctor 2015-10-14 12:41:36 +02:00
Antonio Scandurra
ed201d41cd 💚 Clear CommandRegistry on AtomEnvironment destruction 2015-10-14 10:11:53 +02:00
Antonio Scandurra
57f6fc5772 Observe core.autoHideMenuBar in AtomEnvironment ctor 2015-10-14 09:56:46 +02:00
Antonio Scandurra
f5f2d5dcd6 Remove remaining references to window global 2015-10-14 09:50:50 +02:00
Antonio Scandurra
0ea84ab192 Register default target for keymaps in ctor 2015-10-14 09:31:50 +02:00
Antonio Scandurra
a3190e4551 Use @window when (un)installing uncaught error handler 2015-10-14 09:18:54 +02:00
Nathan Sobo
974743d46c Attach CommandRegistry to window in constructor 2015-10-13 20:11:52 -06:00
Nathan Sobo
74d644ac73 Clear GrammarRegistry in AtomEnvironment::reset 2015-10-13 20:09:56 -06:00
Nathan Sobo
3ef6a9b63b Remove workspaceParentSelector and always attach to document body 
Tests never call startEditorWindow anyway.
 2015-10-13 19:54:29 -06:00
Nathan Sobo
903ecca1f7 Parameterize document on AtomEnvironment 2015-10-13 19:48:56 -06:00
Nathan Sobo
5941d9464a Don’t use window global in AtomEnvironment 2015-10-13 19:39:34 -06:00
Nathan Sobo
54ce749578 Remove unused local 2015-10-13 19:38:02 -06:00
Nathan Sobo
99b06e149b Remove AtomEnvironment::requireWithGlobals 2015-10-13 19:37:26 -06:00
Nathan Sobo
65ae175e72 Pass explicit window global into AtomEnvironment on construction 2015-10-13 19:35:51 -06:00
Nathan Sobo
c8407167ee Pass specific parameters to registerDefaultCommands 2015-10-13 19:20:06 -06:00
Nathan Sobo
f9a269ed99 Prompt about checking out head revision in TextEditor, not GitRepository 
This allows us not to inject confirm or ApplicationDelegate into
Project, GitRepositoryProvider, and GitRepository.
 2015-10-13 19:11:55 -06:00
Nathan Sobo
306ddf5491 Use ApplicationDelegate in CommandInstaller instead of bound confirm 2015-10-13 19:10:56 -06:00
Nathan Sobo
84aa8471b4 Pass AppDelegate to Workspace, Pane instead of bound functions 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 18:54:48 -06:00
Nathan Sobo
20e07649d4 Move confirm into ApplicationDelegate 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 18:09:35 -06:00
Nathan Sobo
3876deddf3 Merge branch 'master' into ns-alternative-test-env 2015-10-13 17:59:46 -06:00
Nathan Sobo
cc0bf23f78 Add setRepresentedDirectoryPaths to ApplicationDelegate 
Also, use it to provide the default path in showSaveDialog
 2015-10-13 17:57:48 -06:00
Nathan Sobo
432a59b8e5 Move tests from window-event-handler-spec for moved functionality 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 17:53:01 -06:00
Nathan Sobo
ed1c37cdbf Bind confirm when deserializing panes 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 17:29:41 -06:00
Nathan Sobo
919571f328 Use ApplicationDelegate in WindowEventHandler 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 17:29:41 -06:00
Nathan Sobo
f989ed65e1 Move ipc handling from WindowEventHandler to ApplicationDelegate 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 16:57:02 -06:00
Nathan Sobo
83a0cf28cd 🎨 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 15:47:45 -06:00
Nathan Sobo
e92cb86335 Introduce ApplicationDelegate to AtomEnvironment 
All external actions are performed via this delegate for test-isolation
purposes.
 2015-10-13 15:42:57 -06:00
Max Brunsfeld
10b8de6fc4 Merge pull request #8533 from ssorallen/notification-manager-options-docs 
Document all options for creating Notifications
 2015-10-13 13:56:41 -07:00
Nathan Sobo
a8ca3165a0 Remove dead code 2015-10-13 14:46:28 -06:00
Martin Rodalgaard
5b37d3e1aa 📝 Better workspace scan and replace docs 2015-10-13 20:29:24 +02:00
Max Brunsfeld
47961a8e6b Fix setting default values in config 2015-10-13 11:00:53 -07:00