Commit Graph

40 Commits

Author SHA1 Message Date
Kevin Sawicki
cb223fa03e Don't check for updates in test mode 2015-05-13 15:55:17 -07:00
Kevin Sawicki
d319d17dcd Always call showUpdateMenuItem 2015-05-13 15:35:27 -07:00
Kevin Sawicki
2195b1a38d Pass auto update manager into application menu 2015-05-13 15:33:56 -07:00
Ivan Zuzak
71fba99540 Dont split keystrokes on trailing dashes 2015-05-10 09:46:45 +02:00
Ivan Zuzak
29a4ab1396 Electron uses 'Plus' instead of '+' in accelerators 2015-05-10 09:26:46 +02:00
Machiste Quintana
5d2392ea67 👕 Fix new coffeelint errors 2015-04-06 23:59:54 -04:00
Kevin Sawicki
f728bc7aec Add explicit returns to browser process classes 2015-03-19 11:48:40 -07:00
Brendan Nee
2168a59828 Add "Checking for Update" to menu
When state is “checking”, menu should say “Checking for Update”
2015-02-18 13:50:18 -08:00
Kevin Sawicki
498631725a Store menu template even if window isn't focused
update may be called before the window gains focus to store its
template so it is updated correcltly once the window gains focus.
2014-10-29 13:06:57 -07:00
Kevin Sawicki
a8be05bb3b Clear focused window property on window closed
Closes #3806
2014-10-27 11:30:41 -07:00
Kevin Sawicki
2a09d25eb1 📝 Add template 2014-10-21 10:22:50 -07:00
Kevin Sawicki
d5508b338b Compare templates before swapping them out 2014-10-21 10:22:50 -07:00
Kevin Sawicki
86bd43bf73 Store each window's menu template
Restore it when the window gains focus
2014-10-21 10:22:50 -07:00
Kevin Sawicki
3075b74b64 Close the template
Menu.buildFromTemplate modifies it so copy before hand
so it can be reused
2014-10-21 10:22:50 -07:00
Kevin Sawicki
11d7437ecc Add setActiveTemplate helper 2014-10-21 10:22:49 -07:00
Desmond Brand
590bfa0c86 💄 Tighten lint rules
coffeelint.json had some rules set to ignore, but since #3116 was merged there
are no violations of these rules in the code anymore. Tighten up the rules to
prevent those kinds of errors from creeping back in.

Test Plan:

Lint executes without finding any errors

```
$ ./script/grunt coffeelint
Running "coffeelint:src" (coffeelint) task
>> 80 files lint free.

Running "coffeelint:build" (coffeelint) task
>> 23 files lint free.

Running "coffeelint:test" (coffeelint) task
>> 40 files lint free.
Done, without errors.
```
2014-08-15 15:34:33 -07:00
Kevin Sawicki
7c1a7f52a5 📝 Use TomDoc in src/browser/ files 2014-04-11 10:50:33 -07:00
probablycorey
4b089b62a6 Destructure item instead of calling it i 2014-04-07 17:01:11 -07:00
probablycorey
bbc6433a75 Update comment 2014-04-07 14:18:16 -07:00
probablycorey
d4ae836225 Use hidden menu items for update processes 2014-04-07 14:17:44 -07:00
probablycorey
789f29e0b5 AutoUpdateManager barely works 2014-04-07 12:25:55 -07:00
probablycorey
f5ea098417 Don't overwrite menu item's metadata field 2014-04-07 11:04:55 -07:00
Kevin Sawicki
de16ed6250 Remove special handling of Shift modifier
atom-keymap now handles this automatically when
normalizing.
2014-04-02 16:13:38 -07:00
Kevin Sawicki
373a7a6d04 Add missing focusedWindow method
This regressed when this code was moved in here in
6d50d05336 and was somehow
still triggereable since it was reported to atom@github.com
2014-03-28 15:55:04 -07:00
probablycorey
def6b67c8f Menu items hide conflicting items when made visible. 2014-03-04 12:26:50 -08:00
probablycorey
e8136853db Add 'downloading update' menu item
Fixes #1689, gets around the crashing bug when displaying a dialog
when update is found.
2014-03-04 12:26:50 -08:00
Kevin Sawicki
932a792289 Remove Private: prefix 2014-02-06 10:02:53 -08:00
probablycorey
faf523f698 Document methods 2014-02-03 14:43:02 -08:00
probablycorey
caeb70cf4a Add 'Check for Updates' menu item 2014-02-03 12:52:01 -08:00
Matt Colyer
a754ac4da0 Revert "Alias meta to cmd in keymaps"
This reverts commit f0aa408b70.
2013-11-21 13:08:12 -05:00
Matt Colyer
f0aa408b70 Alias meta to cmd in keymaps 2013-11-21 10:38:13 -05:00
Matt Colyer
55e90f8ae1 Use cmd instead of command 2013-11-19 15:29:37 -08:00
Matt Colyer
1e4504e7f3 Use command instead of meta 2013-11-19 15:16:55 -08:00
probablycorey
e90f19da97 Rename keystrokeByCommmand to keystrokesByCommmand 2013-11-14 14:26:25 -08:00
probablycorey
d71e58ec33 Use keystroke even when referring to multiKeystrokes
The use of keystroke and keystrokes was becoming confusing. When I 
started thinking of a keystroke as a set of keys that trigger a
command it became easier to think about.
2013-11-11 14:05:48 -08:00
Kevin Sawicki
ee495575a2 Use underscore-plus from browser process classes 2013-10-15 18:47:50 -07:00
Matt Colyer
942695d582 Dynamically replace Atom version in application menu 2013-10-11 11:11:10 -07:00
Matt Colyer
8682bad958 Revert "Dynamically replace Atom version in application menu"
This reverts commit 9b7bc34d44.
2013-10-11 11:10:04 -07:00
Matt Colyer
9b7bc34d44 Dynamically replace Atom version in application menu
Fixes #952
2013-10-11 10:46:26 -07:00
Matt Colyer
7875386498 Separate classes that run in the browser process 2013-10-11 08:50:08 -07:00