Commit Graph

7619 Commits

Author SHA1 Message Date
Max Brunsfeld
81819adbd7 Fix spurious pane activation when changing focus within a pane 2017-04-11 12:20:50 -07:00
Max Brunsfeld
6c1632ad76 Always focus active pane item when pane is activated
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-04-11 11:51:18 -07:00
Nathan Sobo
f4c04f5b60 Fix less spec
On AppVeyor, the patch version of less is emitting lower-case CSS color
names. This makes our test compatible with both capitalizations.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2017-04-11 12:05:43 -06:00
Max Brunsfeld
b3911053be Merge pull request #14166 from atom/mb-fix-creating-panels-with-markup
Ensure that atom-panel tags can be created via HTML
2017-04-11 10:32:06 -07:00
Max Brunsfeld
09554615d4 Fix usages of removed getModel method in tests 2017-04-11 09:15:52 -07:00
Antonio Scandurra
d564bfc983 Test config.setSchema isn't called again when activating a preloaded package 2017-04-11 09:53:03 +02:00
Antonio Scandurra
48013a9140 Fix adding bundled packages to ModuleCache and increase test coverage 2017-04-11 09:37:11 +02:00
Max Brunsfeld
ffff034076 Avoid error when Panel.destroy is called in a blur listener 2017-04-10 17:43:52 -07:00
Max Brunsfeld
1c6c38e8a8 Ensure that atom-panel tags can be created via HTML
* Remove the PanelElement custom element
* Convert Panel and its test to JavaScript
2017-04-10 16:22:51 -07:00
Max Brunsfeld
399b70662d Fix regression in hovered dock tracking due to workspace refactor
Also, backfill tests for showing, hiding and updating the dock toggle
buttons in response to mouse movements.
2017-04-10 14:15:31 -07:00
Nathan Sobo
3292e3b4df Merge pull request #14143 from atom/mb-ns-dock-ui-refinements
Refine Dock UX and API
2017-04-10 09:08:07 -06:00
Nathan Sobo
2e066120bd Fix workspace specs 2017-04-08 13:29:50 -06:00
Max Brunsfeld
48336fb95e Don't use workspace's itemLocationStore in tests 2017-04-07 15:30:44 -07:00
Max Brunsfeld
cca47d785f Handle active pane items that aren't text editors in main process test
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-04-07 14:28:51 -07:00
Max Brunsfeld
6d1cbd389a Wait until tree-view is asynchronously opened in main process test
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-04-07 14:28:25 -07:00
Max Brunsfeld
6c59486166 Silence warnings from config spec
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-04-07 13:29:51 -07:00
Max Brunsfeld
57281dd97a Merge branch 'master' into mb-ns-dock-ui-refinements 2017-04-07 13:23:19 -07:00
Max Brunsfeld
89f1710cfe Wait for paths to open in main process test
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-04-07 13:20:44 -07:00
Max Brunsfeld
63d27c5f0a Rename Dock.isOpen to .isVisible and Dock.open to .show 2017-04-06 17:23:53 -07:00
Max Brunsfeld
233c29d998 Fix usages of Workspace.paneContainer 2017-04-06 16:37:37 -07:00
Matthew Dapena-Tretter
d133b03d7d Remove saveFocusedPaneItem(As) methods
Now that dock pane items will be capable of being the workspace's
active item, there's no need to have these methods.
2017-04-06 17:26:35 -06:00
Nathan Sobo
9c28cc0fa8 Construct WorkspaceCenter's PaneContainer instance in the constructor 2017-04-06 16:57:41 -06:00
Nathan Sobo
1711d10af2 Aggregate onDidStopChangingActivePaneItem events across all containers 2017-04-06 16:35:25 -06:00
Nathan Sobo
9e1f9c0dd9 When focusing a pane, always activate its container 2017-04-06 15:47:17 -06:00
Nathan Sobo
646047f563 Maintain an active pane container on the workspace
This will be used by many commands that previously only interacted with
the center of the workspace.
2017-04-06 15:30:01 -06:00
Nathan Sobo
ec576b12bc Remove PaneContainer.monitorActivePaneItem
Call didChangeActiveItemOnPane directly from panes and when the active
pane changes instead.
2017-04-06 13:18:18 -06:00
Nathan Sobo
5cb550b09d Remove Pane's subclassing of Model 2017-04-06 12:06:46 -06:00
Michelle Tilley
6425b5e069 Merge pull request #14131 from atom/mkt-prepare-build-for-per-package-transpilation
Update build to pre-compile packages with per-package transpilation configs
2017-04-06 00:39:50 -07:00
Nathan Sobo
73f04fdaed Focus the active center pane when hiding a dock 2017-04-05 20:58:05 -06:00
Max Brunsfeld
9ecbc85be5 Remove more usages of getView, document getElement API 2017-04-05 17:02:59 -07:00
Max Brunsfeld
78d8e67609 Add Gutter.getElement, remove Gutter view provider 2017-04-05 17:01:54 -07:00
Max Brunsfeld
2ed0724fc4 Remove unnecessary calls to ViewRegistry.getView 2017-04-05 16:50:04 -07:00
Max Brunsfeld
6344f9884d Add PaneAxis.getElement, remove PaneAxis view provider 2017-04-05 16:25:53 -07:00
Max Brunsfeld
d0421a75c8 Add Panel.getElement and remove Panel view provider 2017-04-05 16:10:21 -07:00
Max Brunsfeld
e40ef03008 Fix Workspace.open test for activating existing items in docks 2017-04-05 16:03:33 -07:00
Max Brunsfeld
d1e8e359ce Add PanelContainer.getElement, remove PanelContainer view provider 2017-04-05 16:03:33 -07:00
Max Brunsfeld
6f0b1947ee Use Workspace.getElement in tests 2017-04-05 15:32:00 -07:00
Max Brunsfeld
6d55371930 Add Workspace.getElement method, remove WorkspaceElement view provider 2017-04-05 15:32:00 -07:00
Nathan Sobo
88422ee4c9 Focus the active pane of docks when they are activated 2017-04-05 15:35:47 -06:00
Nathan Sobo
334290aaa7 Resize dock to fit on double-click of resize handle 2017-04-05 12:45:29 -07:00
Max Brunsfeld
c810ac4f5b Merge pull request #14136 from atom/mb-ns-dont-auto-open-dock-when-adding-item
Open docks when activating their panes, but not when adding items
2017-04-05 12:44:21 -07:00
Max Brunsfeld
caafa41f6f Open docks when activating their panes, but not when adding items 2017-04-05 12:00:38 -07:00
Nathan Sobo
6ac29939e5 Merge pull request #14125 from atom/mb-ns-open-with-item
Allow workspace item objects to be passed to Workspace.open
2017-04-05 12:59:03 -06:00
Nathan Sobo
a74d561f3c Merge pull request #14134 from atom/fb-mdt-dont-store-default-locations
Don't store default locations
2017-04-05 10:59:01 -06:00
Max Brunsfeld
e14e31d9b5 Don't copy workspace items that don't implement .copy()
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-04-05 10:48:31 -06:00
Matthew Dapena-Tretter
fed2372c30 Don't store default locations
This will probably be less confusing for developers experimenting with
changing the default location. Also, we avoid storing extra info we
don't really need.
2017-04-04 14:49:34 -07:00
Bryant Ung
8bc325b922 Merge pull request #14063 from dietmar/linux_middle_mouse_8648
fixing middle mouse button clipboard paste on linux (atom:atom#8648)
2017-04-04 14:22:40 -07:00
Matthew Dapena-Tretter
881cbbd17f Add delete() method to StateStore
This allows us to delete single items.
2017-04-04 13:45:14 -07:00
Max Brunsfeld
32ff2f37d9 Merge pull request #14108 from atom/fb-mdt-remember-moved-item-positions
🐛 Fix observation of moved items
2017-04-04 10:20:24 -07:00
Nathan Sobo
56cefbbc63 Support passing items to Workspace.toggle and .hide
Also, ensure that passing an item that is not yet present in the
workspace does not interfere with resolving the location where we want
to place the item.
2017-04-04 11:18:12 -06:00