Commit Graph

21924 Commits

Author SHA1 Message Date
Nathan Sobo
0be4ad547a Disable 'package-that-throws-an-exception' except in spec that uses it
Loading this package logs a warning, so to minimize noise in the spec
console, it should only be loaded when `console.warn` is mocked.
2013-01-27 12:12:39 -07:00
Nathan Sobo
a83b8583f0 Perform body parsing in the worker thread (without failing specs)
Since `snippets.add` can still be called from the window thread, we need
to retain the ability to parse the body without relying on the loading
task. But this commit only loads the parser in the window if it's actually
needed, instead of always loading it when the snippets extension is
loaded. This avoids the loading performance hit while still allowing
specs to pass and letting us call `snippets.add` manually in the window
if we want to.
2013-01-27 12:07:36 -07:00
Kevin Sawicki
8fb1105051 Detach markdown preview when focus is lost 2013-01-27 11:00:34 -08:00
Kevin Sawicki
cb4f392fa6 Set tab index on root-view to 0
Previously if the tree-view was open and was focused and no
editors were open and tab was pressed the document body would
become focused which would not allow events bound to root view
to be triggerable.

This ensures that the root-view always gets focus back when
another view is tabbed away from.
2013-01-27 10:49:17 -08:00
Nathan Sobo
5bfb9feeda Revert "Move snippet body parsing to web worker"
This reverts commit 5b541ccc2b.
It caused the snippets spec to break. I'll try to achieve the same
thing without that happening.
2013-01-27 11:40:01 -07:00
Nathan Sobo
f3ab64edbc Merge pull request #178 from github/ctrl-tab
Add ctrl-tab shortcut to switch panes
2013-01-27 10:23:23 -08:00
Chris Wanstrath
186f461dd7 Add ctrl-tab shortcut to switch tabs 2013-01-26 11:42:22 -08:00
Jon Rohan
1e45dee73e Merge pull request #177 from github/box-flex-tabs
The currently highlighted tab shows more tab
2013-01-25 18:53:52 -08:00
Kevin Sawicki
1b76b05e4d Bind ctrl-C to copy path to clipboard
Refs #173
2013-01-25 17:52:05 -08:00
Kevin Sawicki
985dd284dc 💄 2013-01-25 17:37:24 -08:00
Kevin Sawicki
22aeda6f1c Add move-to-top/bottom support to select list 2013-01-25 17:31:45 -08:00
Jon Rohan
9d6853d29e By the power of box-flex, tabs 2013-01-25 16:25:33 -08:00
Kevin Sawicki
6ef32b5a9a Merge pull request #151 from github/dev
Merge dev into master
2013-01-25 16:24:09 -08:00
Kevin Sawicki
35b7ad5ee3 Add match count to path header text 2013-01-25 13:08:58 -08:00
Kevin Sawicki
e919759c58 Rename jump-to-declaration command to go-to-declaration 2013-01-25 12:55:12 -08:00
Kevin Sawicki
5524999946 Rename jump-to-line package to go-to-line 2013-01-25 12:52:10 -08:00
Kevin Sawicki
8bf82d3aa1 Don't detach unless view has parent 2013-01-25 12:46:08 -08:00
Kevin Sawicki
58dbddad53 Trigger attach before verifying confirm/cancel events 2013-01-25 12:45:20 -08:00
Kevin Sawicki
90d2e12e62 Add spec for editor:jump-to-line event 2013-01-25 12:44:13 -08:00
Kevin Sawicki
126d938aeb Use active editor from root view instead of ivar 2013-01-25 12:43:38 -08:00
Kevin Sawicki
e22c8d69f7 Add jump to line bound to meta-l
Closes #176
2013-01-25 11:22:29 -08:00
Kevin Sawicki
cb94c712cc Add gists stylesheet to package.json 2013-01-25 10:44:14 -08:00
Kevin Sawicki
54eabce9ab Switch grammar toggle to meta-L
meta-l should be reserved for jump to line
2013-01-25 10:30:38 -08:00
Kevin Sawicki
fb4623d5d3 Don't populate list until elements have been set
Closes #174
2013-01-25 10:28:07 -08:00
Kevin Sawicki
73aab4f49a Move gists stylesheet to themes 2013-01-25 10:10:19 -08:00
Kevin Sawicki
4a89f4580b Make Gists a deferred package 2013-01-25 10:08:00 -08:00
Kevin Sawicki
bdc85bec76 Add octicon to Gist notification 2013-01-25 09:26:54 -08:00
Kevin Sawicki
cffb73bc8d Show notification that Gist was created 2013-01-25 09:26:53 -08:00
Kevin Sawicki & Nathan Sobo
d1c6caabd6 Add package to create a Gist from the editor 2013-01-25 09:26:53 -08:00
Kevin Sawicki
0f314f573b Add match and file count to command panel preview 2013-01-25 09:23:18 -08:00
Kevin Sawicki
63b9a4b179 Kill wrap-around in command panel preview list
Jumping from top to bottom can be still done using
meta-up and meta-down.
2013-01-25 08:51:16 -08:00
Justin Palmer
55830f50f7 Merge branch 'master' of https://github.com/github/atom into dev 2013-01-25 08:05:36 -08:00
Kevin Sawicki
19a7c04b8f Shadow require name in class name 2013-01-24 17:41:06 -08:00
Kevin Sawicki
5b541ccc2b Move snippet body parsing to web worker 2013-01-24 17:22:51 -08:00
Kevin Sawicki
5d10d6fb44 Load grammars from web worker 2013-01-24 17:22:51 -08:00
Nathan Sobo
0d63d6459d Make TextMate snippets loading immune to hidden files & invalid plist
closes #143
2013-01-24 17:22:51 -08:00
Nathan Sobo
59ac9de8c3 💄 2013-01-24 17:22:50 -08:00
Nathan Sobo
ea65c63862 Translate TextMate snippets in the worker thread
Might as well do as much work there as possible.
2013-01-24 17:22:50 -08:00
Nathan Sobo
0726987896 Give Task an RPC-style interaction with its Worker
This commit makes all interactions between Task and Worker look
like method calls. The worker now has a global `callTaskMethod`
function that it can use to call methods on the Task object. And the
Task can use `callWorkerMethod` to call methods on a global `handler`
object in the worker. The worker's initial `handler` actually contains
the `start` method, which the Task initially calls to kick things off.
Then the global `handler` gets replaced with whatever `handlerPath`
is specified by the Task. The worker then calls `workerStarted` on its
parent Task object.

This commit also gets rid of the `onProgress` method with the reply
semantics, favoring a more explicit interaction. When `snippetsLoaded`
finishes adding the snippet data, we call `loadNextPackageSnippets`
explicitly rather than returning a reply message.
2013-01-24 17:22:50 -08:00
Corey Johnson & Kevin Sawicki
c628a88409 Lower case Task in require 2013-01-24 17:22:50 -08:00
Kevin Sawicki
69c9ed3feb Use self instead of hacky eval 2013-01-24 17:22:50 -08:00
Kevin Sawicki
3dd11c6c0f Set type to log for console.log forwarding 2013-01-24 17:22:50 -08:00
Kevin Sawicki
8c4a21ee5d Remove unused requires 2013-01-24 17:22:50 -08:00
Kevin Sawicki
2393bd0e9e Create task shell that bootstraps worker 2013-01-24 17:22:50 -08:00
Kevin Sawicki
9ab730b3d0 Load snippets in a web worker
A single web worker is now used to load
snippets one bundle at a time.
2013-01-24 17:22:50 -08:00
Corey Johnson & Nathan Sobo
cab281c6db Inject all native extensions into web worker contexts 2013-01-24 17:22:50 -08:00
Nathan Sobo
f22fedebcf Inject new instances of native objects into every JS context
This prevents concurrent access to the same state from different
worker threads. We needed to treat windowState specially because we
explicitly want it to last beyond the life-span of a single context.
So we store it as a static variable in `native.mm` and synchronize
access with a static `NSLock`. Good enough for now.
2013-01-24 17:22:50 -08:00
Corey Johnson & Nathan Sobo
9bff6f63df Delete lines that never should have been there 2013-01-24 17:22:50 -08:00
Corey Johnson & Nathan Sobo
1b228c75bc Convert Tags to context binding 2013-01-24 17:22:50 -08:00
Corey Johnson & Nathan Sobo
d4b5c8beac Don't make OnigScanner and OnigRegExp be window globals 2013-01-24 17:22:49 -08:00