Nathan Sobo
211a1c75e2
Return a disposable from ThemeManager::requireStylesheet
2014-09-30 14:02:04 -06:00
Nathan Sobo
fd3cb1a232
💄 theme-manager-spec
2014-09-30 14:01:41 -06:00
Nathan Sobo
f205fe81ce
Actually update first-mate. Previous ( 51475fe231) updated atom-keymap.
...
Both were needed to introduce disposables, but I mixed up the commit
message in the previous commit.
2014-09-30 13:58:01 -06:00
Ben Ogle
c74b1b971d
Use isPlainObject()
2014-09-30 12:44:44 -07:00
Ben Ogle
54af7eced1
Handle empty config files + reset settings before applying user config
...
Closes #3664
2014-09-30 12:39:07 -07:00
Nathan Sobo
10f7a671c8
Merge pull request #3667 from atom/ns-deserializer-manager-disposables
...
Return disposables from DeserializerManager::add
2014-09-30 13:10:35 -06:00
Nathan Sobo
51475fe231
Upgrade first-mate to return Disposable from GrammarRegistry::addGrammar
2014-09-30 13:09:40 -06:00
Nathan Sobo
33a5ca30dc
Use DeserializerManager::add disposable instead of ::remove in specs
2014-09-30 12:58:10 -06:00
Nathan Sobo
df1ae64f62
Deprecate DeserializerManager::remove
2014-09-30 12:58:10 -06:00
Nathan Sobo
83710ed254
📝 Rename classes param to deserializers and update docs
2014-09-30 12:58:10 -06:00
Nathan Sobo
8cb8f09803
Return a Disposable instance from DeserializerManager::add
2014-09-30 12:58:10 -06:00
Kevin Sawicki
ff0a7be48a
Upgrade to settings-view@0.148
2014-09-30 11:18:50 -07:00
Nathan Sobo
b2cc28fb5b
Rename commandOptions to commandDetail on context menu items
2014-09-30 12:15:56 -06:00
Nathan Sobo
f6938183cc
Add pane splitting context menu items for all panes
...
The same menu items remain for `.overlayer` to force them to be ordered
before package context menu items.
2014-09-30 12:06:27 -06:00
Nathan Sobo
4a0c5aaa70
Prevent adjacent menu separators
2014-09-30 12:06:27 -06:00
Nathan Sobo
eb929cb7a2
Honor item specificity while still preserving addition order
...
Rather than using order to specify item precedence, we now construct
a set of menu items for each element traversing upward from the target.
When merging items for a given element, we pass the specificity to the
merge function, which uses it to decide whether or not to clobber
existing items. When assembling the overall menu, we don’t ever clobber
to ensure that items added for elements closer to the target always win
over items matching further up the tree.
2014-09-30 12:06:27 -06:00
Nathan Sobo
cf80b92f9a
Remove logging
2014-09-30 12:06:27 -06:00
Nathan Sobo
1187b50d90
Put platform items back on .overlayer so they sort before package items
2014-09-30 12:06:27 -06:00
Nathan Sobo
36d5359ef4
Restore original context menu ordering
...
Previously I used CSS specificity to order the most specific / recently
added menu items for a given element *first* when building up the
context menu. When a duplicate label was found for a given menu I would
refrain from inserting it. Now instead I order things the opposite way.
The most specific / recently added items come later and items with the
same label are clobbered by later items.
2014-09-30 12:06:26 -06:00
Nathan Sobo
915cfe15f5
Clear context menus between specs
2014-09-30 12:06:26 -06:00
Nathan Sobo
f082f93ead
Update specs for new ContextMenuManager API/behavior
...
When selectors have the same specificity, menu items added *later*
appear higher in the list.
2014-09-30 12:06:26 -06:00
Nathan Sobo
f9bf42db64
Remove commented line
2014-09-30 12:06:26 -06:00
Nathan Sobo
ff76e36f7d
Only display ‘Inspect Element’ item in dev mode
2014-09-30 12:06:26 -06:00
Nathan Sobo
740778e129
Auto-detect context menu items in the old format
2014-09-30 12:06:26 -06:00
Nathan Sobo
483e746439
Use new format for platform menus
2014-09-30 12:06:26 -06:00
Nathan Sobo
aec6df828e
fixup! Call context menu item ::created hooks with the click event
2014-09-30 12:06:09 -06:00
Nathan Sobo
703197bcca
Deprecate old style calls to ContextMenuManager::add
2014-09-30 12:06:09 -06:00
Nathan Sobo
2142c8e63e
:public: Document new ContextMenuManager::add API
2014-09-30 12:06:09 -06:00
Nathan Sobo
782f9c609e
Add shouldDisplay hook for context menu items
...
If present, if a falsy value is returned from this function for a given
context menu invocation, the item will not be displayed.
2014-09-30 12:06:09 -06:00
Nathan Sobo
3a567b3c5b
Call context menu item ::created hooks with the click event
2014-09-30 12:06:08 -06:00
Nathan Sobo
c5b395579b
Add devMode flag to individual items
2014-09-30 12:06:08 -06:00
Nathan Sobo
f8225a6441
Make arguments atom.contextMenu.add consistent with atom.menu.add
2014-09-30 12:06:08 -06:00
Nathan Sobo
504c4c7af6
Extract MenuHelpers from MenuManager for reuse by ContextMenuManager
2014-09-30 12:06:08 -06:00
Nathan Sobo
5e6e3c8d72
Merge pull request #3655 from atom/ns-menu-disposables
...
Return disposables from MenuManager::add and add specs
2014-09-30 12:05:11 -06:00
Nathan Sobo
dfc502b9a0
Merge pull request #3663 from atom/bo-subscribe-editor-commands
...
Subscribe to commands in TextEditorComponent so they are unsubscribed!
2014-09-30 10:56:05 -06:00
Ben Ogle
a8d93f9cf4
Spec for unsubscribing from commands
2014-09-30 09:45:55 -07:00
Ben Ogle
50cf5f3e95
Subscribe to editor commands
...
We need to unsubscribe when the editor is removed!
Closes #3651
2014-09-30 09:33:50 -07:00
Kevin Sawicki
5a9b34b31a
! -> ~
2014-09-30 09:32:03 -07:00
Kevin Sawicki
3efaeff669
🍎 Install via move instead of copy
...
This fixes the issue with the icon not showing up on OS X Mavericks
when building.
It seems that copying it to /Application file by file causes the icon to not
show up while moving it atomically there does.
2014-09-30 09:15:55 -07:00
Ben Ogle
443df29236
Upgrade find and replace to have cmd-d undo and skip
2014-09-29 17:26:51 -07:00
Ben Ogle
05b3f16eb2
Merge pull request #3613 from atom/bo-config-types
...
Support JSON Schema in Config
2014-09-29 17:23:54 -07:00
Ben Ogle
b54deccfae
String type must be strict.
...
It makes sense to coerce from more general -> more specific data types.
eg. string -> int, etc. But coercing the other way is problematic
in the case of chaining because the more general type will swallow the
specific type. eg. Setting `false` on type: [‘string’, ‘boolean’] will
coerce the boolean to a string, and will never allow the value to be
a boolean.
2014-09-29 16:09:49 -07:00
Ben Ogle
9808264b7f
Fix onDidChange usage
2014-09-29 16:09:49 -07:00
Ben Ogle
f3ed3dc357
Fix doc to match implementation
2014-09-29 16:09:49 -07:00
Ben Ogle
33b25c7312
Use new config callback arguments
2014-09-29 16:09:49 -07:00
Ben Ogle
454f9c4c65
Rename config-defaults -> config-schema
2014-09-29 16:09:49 -07:00
Ben Ogle
1b506673bb
📝 update
2014-09-29 16:09:49 -07:00
Ben Ogle
5651ebbb48
always set, only emit when values differ
2014-09-29 16:09:49 -07:00
Ben Ogle
a7185a894f
Fix specs
2014-09-29 16:09:49 -07:00
Ben Ogle
16c7fd3d70
Add spec for update event on load
2014-09-29 16:09:49 -07:00
