Per the discussion with @kevinsawicki in #3168, I have added a config
option `editor.confirmCheckoutHead` that defaults to `true`. When the
`editor:checkout-head-revision` command is executed, a confirmation
dialog now shows that states which file is to be reverted and asks the
user to "Revert" or "Cancel". If the config option is set to `false`,
the old behavior, simply reverting without prompting, is used.
I also added tests to ensure that the confirmation dialog is displayed
or not in the right configurations.
There have been a few reports of files mysteriously going back to the
last version in the tree. My theory is that it is because of people
fat-fingering the Undo command because the default keyboard mapping is
too similar. This will at least prevent most accidental data loss.
Check enabled names against the bundled names and ensure
one bundled UI and one bundled syntax theme are enabled,
defaulting to the dark themes when necessary.
Clarify the build steps. The most important is that initialy "Create ..." and "Install ..." could be interpreted as "(User should) create/install ..." while it should mean "(To) create/install ... (do)".
The motivation is for this is to allow `coffeelint` config to be shared by
`script/grunt coffeelint`, global `coffeelint` and inline linting via
`AtomLinter`.
Test Plan:
Made some deliberate lint errors then ran `script/grunt coffeelint` and
verified the output looked the same with and without this change.
Stops the project folder icon appearing in places that don't make sense
like settings and new files.
Test Plan:
* Opened settings and didn't see the project folder icon
* Closed all tabs and saw the project folder icon
As requested by @philipgiuliani
Test Plan:
Opened an existing file and made a modification. The icon fades at the same
time the tab close button changes to a circle. Undo makes the icon opaque
again.
Fixes#1891.
Test Plan:
* Opened Atom window in directory, verified directory icon shows up
* Opened a file and verified icon changed
* Right clicked icon, verified menu appears
* Drag file to terminal and it pastes the file path (yay)
* Opened a new Atom window and opened some files in that to make sure that
it didn't change the original window
I didn't add any specs for this - advice welcome here. I also haven't tested
on Windows or Linux but it looks like `setRepresentedFilename` is a noop on
those platforms.
