github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-10 22:55:09 -05:00
Code Issues Packages Projects Releases Wiki Activity
36,465 Commits 140 Branches 571 Tags
cdb5ac98caa511d7f157c7a91297d40eea40044f
Commit Graph

81 Commits

Author SHA1 Message Date
Jason Rudolph
f3f32c45cc Merge pull request #19176 from atom/respect-package-lock-on-ci 
Teach CI to use versions specified in package-lock.json
 2019-04-19 17:13:38 -04:00
Nathan Sobo
406e033323 Merge pull request #19183 from atom/ns/upload-windows-crashes-on-release-branches 
On Azure DevOps, upload Windows crash dumps to S3 on release branches
 2019-04-19 13:52:47 -06:00
Nathan Sobo
4bc43eb358 On Azure DevOps, upload Windows crash dumps to S3 on release branches 
On release branches, we can't upload crash dumps because they will leak
secret environment variables. So instead we will upload them to our S3
bucket with 'private' ACL. They can then be manually retrieved via the
AWS CLI with our private credentials.
 2019-04-18 17:04:49 -06:00
Nathan Sobo
7ef8f06cd2 Only upload Windows crash reports if the S3 key environment var is null 
This seems like a more robust test than the isRelease variable I was
testing previously. Our goal is to not leak secrets such as the S3 key,
so this is a more direct test of that.
 2019-04-18 15:15:31 -06:00
Nathan Sobo
b03d49973e On Azure DevOps, publish crash reports on non-release Windows branches 
Since we don't expose sensitive information on these branches, we can
use the regular artifact publishing mechanism
 2019-04-18 10:49:14 -06:00
Jason Rudolph
fce5a8974f Fix issue upgrading npm & use upgraded version 2019-04-18 10:59:33 -04:00
Jason Rudolph
cb3f24fc5c Use env var to specify path to npm binary 2019-04-18 09:53:40 -04:00
Jason Rudolph
680e48485a Set PATH so that Azure DevOps macOS builds use correct npm 
Before we run script/bootstrap on the macOS build, the preceding build
step installs npm 6.2.0 as the global npm version. It installs npm at
`/usr/local/bin/npm`. However, a _different_ version of npm appears
earlier in the PATH. The PATH looks like this:

```
/Users/vsts/hostedtoolcache/node/8.9.3/x64/bin:
/usr/local/lib/ruby/gems/2.6.0/bin:
/usr/local/opt/ruby/bin:
/usr/local/opt/curl/bin:
/usr/local/bin:
/usr/local/sbin:
/Users/vsts/bin:
/Users/vsts/.yarn/bin:
/usr/local/go/bin:
/Users/vsts/Library/Android/sdk/tools:
/Users/vsts/Library/Android/sdk/platform-tools:
/Users/vsts/Library/Android/sdk/ndk-bundle:
/Library/Frameworks/Mono.framework/Versions/Current/Commands:
/usr/bin:
/bin:
/usr/sbin:
/sbin:
/Users/vsts/.azcopy
```

There's an npm executable at
/Users/vsts/hostedtoolcache/node/8.9.3/x64/bin/npm.

To get the build to use the global version of npm, this commit puts
/usr/local/bin at the beginning of the PATH.
 2019-04-17 17:27:32 -04:00
Jason Rudolph
ce94241bde Configure Azure DevOps bootstrapping step to run with CI env vars 2019-04-17 12:23:05 -04:00
Jason Rudolph
9e03795c20 Provide the BUILD_ARCH env var for bootstrapping Windows env on VSTS 
`script/vsts/windows-run.js` checks the BUILD_ARCH env var, so let's 
make sure it's populated.
 2019-04-03 13:11:24 -04:00
Jason Rudolph
166658f588 Add back bootstrapping to script/build on Windows 
Hopefully this will resolve the error we're seeing here:

https://github.visualstudio.com/Atom/_build/results?buildId=37021&view=logs&jobId=97a617bf-bcbd-5dfa-bba2-cfba2747b693&taskId=1e1369e9-1c56-59b0-830c-f1606a680c8a&lineStart=13&lineEnd=19&colStart=1&colEnd=1

🤞
 2019-04-02 19:43:45 -04:00
Jason Rudolph
5f52a8e0b0 Lint earlier in the build process 2019-04-02 19:43:44 -04:00
Rafael Oleza
874016b785 Add GITHUB_TOKEN env var to the npm install step (take 2) 
This will prevent issues when installing the `vscode-ripgrep` package
 2019-03-20 14:41:22 +01:00
David Wilson
ce4180e9f1 Upload Windows delta nupkg artifacts in release builds 2019-02-17 15:12:07 -08:00
Ash Wilson
402fa903fd Merge pull request #18802 from atom/aw/jasmine-junit-xml 
Report test result metadata to Azure DevOps
 2019-02-16 11:02:20 -05:00
Ash Wilson
06a1a38d25 Oh. Right. That's interpreted as a .bat file 2019-02-15 14:56:39 -05:00
Ash Wilson
60aaca8ecc Er, maybe no separator at all? 2019-02-15 13:02:25 -05:00
Ash Wilson
a645a8e638 Windows path separator maybe 2019-02-15 11:16:33 -05:00
Ash Wilson
536c582e2b Respect Atom.SkipTests 2019-02-15 11:16:19 -05:00
Ash Wilson
57ff580d66 Invoke the postprocessing script from CI 2019-02-15 10:09:36 -05:00
Ash Wilson
4d090b8f1e Set test run titles in PublishTestResults tasks 2019-02-12 11:59:38 -05:00
Ash Wilson
e1be511851 Unconditionally dump results 2019-02-11 13:33:35 -05:00
Ash Wilson
3b7ac36bec Azure doesn't like trailing whitespace 2019-02-11 13:31:59 -05:00
Ash Wilson
6e69bc0d7d Upload crash reports on macOS 2019-02-11 10:44:51 -05:00
Ash Wilson
da891bd120 Use spaces in TEST_JUNIT_XML_RUN 2019-02-11 10:13:31 -05:00
Ash Wilson
65661ba8a3 Report test suites individually 2019-02-07 08:49:42 -05:00
Ash Wilson
4f575e0340 Does that expect a forward slash? 2019-02-06 21:14:40 -05:00
Ash Wilson
7361720363 Quoting is a thing 2019-02-06 20:20:13 -05:00
Ash Wilson
c11442df5e Explicit test-results.xml glob 2019-02-06 19:45:41 -05:00
Ash Wilson
f42de37cbc Set ROOT instead of PATH 2019-02-06 14:23:54 -05:00
Ash Wilson
b118b91075 Use a subdirectory 2019-02-06 13:16:34 -05:00
Ash Wilson
d3eb451e55 Fail less on empty or missing result directories 2019-02-06 10:40:33 -05:00
Ash Wilson
bef6edb343 Respect Atom.SkipTests 2019-02-06 10:39:59 -05:00
Ash Wilson
ccc95917cd Use Common.TestResultsDirectory for test results 2019-02-06 10:39:26 -05:00
Ash Wilson
69df3439f9 Use find instead of ls 2019-02-06 10:14:00 -05:00
Ash Wilson
399a0b7363 I could swear you used to be able to shorten that 2019-02-05 20:15:39 -05:00
Ash Wilson
c6d0afb304 Dump the test-results folder 2019-02-05 20:12:37 -05:00
Ash Wilson
756f1196da Use backslashes on Windows in case something is being dumb 2019-02-05 20:12:25 -05:00
Ash Wilson
847f7aff4c Use searchFolder and mergeTestResults 2019-02-05 20:12:03 -05:00
Ash Wilson
fe5bdeed21 Let's see if it magically works 2019-02-05 14:28:35 -05:00
Ash Wilson
afd6576566 Set ATOM_JASMINE_REPORTER to "list" on our CI builds 2019-02-05 10:29:09 -05:00
David Wilson
aef6ba315b Merge pull request #18049 from atom/dw-fix-linux-build 
Use a custom Ubuntu 18.04 container for VSTS Linux builds
 2018-09-14 13:34:08 -07:00
David Wilson
69932be7d8 Use a custom Ubuntu 18.04 container for VSTS Linux builds 2018-09-14 11:39:27 -07:00
David Wilson
7961bd5124 Upload x86 Windows build artifacts 2018-09-13 17:16:09 -07:00
David Wilson
861a2155b8 Enable Windows x64 builds on VSTS 2018-09-13 16:10:55 -07:00
David Wilson
a4a94c2361 Fix bad condition on artifact upload task in linux.yml 2018-09-06 10:46:30 -07:00
David Wilson
6ff5ea5250 Don't upload build artifacts in PR builds 2018-09-06 08:08:25 -07:00
Chris Patterson
3a71011388 fixing vmImage name 2018-08-31 15:58:42 -04:00
Chris Patterson
27690cb71b Rolling back to vs2015 image 
For some reason the vs2017 image can't build with python 2.7 and gyp properly.
 2018-08-31 15:50:00 -04:00
Chris Patterson
bc14ba5e04 Added explicit python version 
Updated  Windows job to specify python version
 2018-08-31 15:34:20 -04:00