Antonio Scandurra
cfb30c795d
Use an updated version of LineTopIndex
2015-12-14 15:04:54 +01:00
Antonio Scandurra
c578f221bf
✅ Test ::invalidateBlockDecorationDimensions
2015-12-04 15:42:49 +01:00
Antonio Scandurra
b77c45859c
Merge branch 'master' into as-block-decorations
...
# Conflicts:
# spec/text-editor-presenter-spec.coffee
2015-12-04 14:44:19 +01:00
Antonio Scandurra
7554f71f74
Make sure screen row is set correctly on <content>
2015-12-04 14:21:23 +01:00
Antonio Scandurra
14d8ecefdd
💚 Fix LinesYardstick specs
2015-12-04 12:54:20 +01:00
Antonio Scandurra
16525047f1
💚 Fix component and presenter specs
2015-12-04 12:49:59 +01:00
Kevin Sawicki
1fac3cb4e2
Merge pull request #9620 from DouweM/window-title
...
Use em-dash in window title and exclude app name on OS X
2015-12-03 16:23:43 -08:00
Wliu
2b694bb4b1
Merge pull request #9921 from atom/wl-update-for-js-scope-changes
...
Update specs for language-javascript changes
2015-12-03 17:26:17 -05:00
Max Brunsfeld
fe5b1b70e8
Fix paragraph motions in the presence of CRLF line endings
2015-12-03 12:07:15 -08:00
Max Brunsfeld
76b6ca5043
Make CRLF word-movement tests pass
2015-12-03 11:52:45 -08:00
Max Brunsfeld
71d2761c1a
Merge pull request #9763 from dranzerashi/patch-1
2015-12-03 10:30:48 -08:00
Antonio Scandurra
f2a0221519
Make sure block decorations are always in the right spot
2015-12-03 18:16:10 +01:00
Antonio Scandurra
cc4344735e
💚 Fix specs
2015-12-03 17:11:38 +01:00
Antonio Scandurra
36103a024a
Make sure to add screen row to block decoration nodes
2015-12-03 16:26:15 +01:00
Antonio Scandurra
555d77afa6
Do not remove invisible decorations on ::mouseWheelScreenRow
2015-12-03 15:45:47 +01:00
Antonio Scandurra
e4655c62e4
💚 Fix false negative
2015-12-03 15:07:54 +01:00
Antonio Scandurra
5f6f99259e
Ensure custom gutters work properly
2015-12-03 15:05:14 +01:00
Antonio Scandurra
f22bd5d0ae
🐎 Use ids instead of classes
2015-12-03 11:52:10 +01:00
Antonio Scandurra
937116a280
Render only visible and yet-to-be-measured block decorations
2015-12-03 11:26:45 +01:00
Wliu
d85af0d3f4
💚 again
2015-12-02 21:39:12 -05:00
Wliu
ecd14f3390
💚 let and var are now storage.type.var.js
...
Refs atom/language-javascript#277
2015-12-02 20:47:27 -05:00
Antonio Scandurra
9ef3ecf378
Handle off-screen measurements properly
2015-12-02 18:34:57 +01:00
Antonio Scandurra
5228471bc5
Write failing spec for measuring invisible elements
2015-12-02 17:04:33 +01:00
Antonio Scandurra
e10fdc234b
🐛 Coordinate conversion is hard
2015-12-02 16:26:10 +01:00
Antonio Scandurra
5bcdcbeef6
🎨
2015-12-02 16:13:44 +01:00
Antonio Scandurra
f30e4ccc9d
Use the new LineTopIndex in TextEditorPresenter
2015-12-02 16:01:55 +01:00
Antonio Scandurra
1e07b8df05
Handle position between rows correctly
2015-12-02 09:13:06 +01:00
Antonio Scandurra
e0b1cabb21
Implement a linear structure for block decoration coordinates
...
We still cannot handle `::rowForTopPixelPosition` when the passed top position
is in the middle of two rows and there's also a block decoration. We'll get
there eventually.
Also, the specs in this commit should serve as a good test suite for the future
logarithmic data structure.
2015-12-01 19:33:37 +01:00
Antonio Scandurra
d24290357a
Implement block decorations in the components land
2015-12-01 13:36:23 +01:00
Antonio Scandurra
47b16c513c
Make sure cursors are updated with respect to block decorations
2015-12-01 09:48:11 +01:00
Max Brunsfeld
3827b19da4
Merge pull request #9687 from atom/mb-deprecate-load-time-package-code
...
Provide package.json fields so we can defer requiring packages' main modules
2015-11-30 15:53:37 -08:00
Nathan Sobo
f139992585
Avoid infinite recursion in Error.prepareStackTrace
...
Previously, prepareStackTraceWithStackAssignment could end up calling
itself when third-party code assigned Error.prepareStackTrace back
to its original value. Now, we short-circuit this process if the
rawStack property has already been assigned.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-11-30 10:51:21 -08:00
Max Brunsfeld
a36fc301f9
Merge branch 'master' into mb-deprecate-load-time-package-code
2015-11-30 10:51:14 -08:00
Max Brunsfeld
228e67838c
Suppress false coffeelint error
2015-11-30 10:51:03 -08:00
Max Brunsfeld
d058814957
Merge remote-tracking branch 'origin/master' into mb-deprecate-load-time-package-code
...
Conflicts:
package.json
2015-11-30 10:20:31 -08:00
Antonio Scandurra
526a97562e
Include block decorations as a separate object on presenter's state
2015-11-30 15:05:15 +01:00
Antonio Scandurra
8a54a2c15b
Use a boolean in each line state object
2015-11-30 14:44:58 +01:00
Antonio Scandurra
539a5b0ae7
🐎 Do as little pixel conversion as possible
...
We desperately need a tree-based data structure. 😢
2015-11-30 14:34:16 +01:00
Antonio Scandurra
b998e7f2d9
🐎 Incremental updates for block decorations
2015-11-30 14:03:45 +01:00
Antonio Scandurra
0159d5c31e
🎨
2015-11-27 16:58:08 +01:00
Antonio Scandurra
6ad21307cc
Provide blockDecorationsHeight for each line number
2015-11-27 16:27:01 +01:00
Antonio Scandurra
6365c86992
Include blockDecorations inside each line's state
2015-11-27 14:32:01 +01:00
Antonio Scandurra
e1e06580c1
Move position conversion in LinesYardstick
2015-11-27 12:47:47 +01:00
Antonio Scandurra
0b5638f749
Make sure tile positions are computed correctly
2015-11-27 10:47:25 +01:00
Antonio Scandurra
a9cb1bda8d
Use ::positionForRow in ::updateTilesState
...
The algorithm is still super sloooow 🐌 , but we'll fix that in a later
commit.
2015-11-27 10:16:38 +01:00
Antonio Scandurra
02651b7a58
🎨 Rename to ::setBlockDecorationDimensions
2015-11-26 16:10:08 +01:00
Antonio Scandurra
96863eef1c
Ensure content scrollHeight takes block decorations into account
...
Seems like all these properties in the presenter's state share a common
contract, which we should probably extract. It could also mean there's an
underlying design problem, because we are testing two dimensions of the same
behavior in a single spec.
2015-11-26 15:44:59 +01:00
Antonio Scandurra
30da4bdb0c
Ensure gutter scroll height takes block decorations into account
2015-11-26 15:43:34 +01:00
Antonio Scandurra
89d9a2ce83
🎨 Create block decorations in TextEditor
...
This is just an experiment, although I like that we can hide some information
(irrelevant to the user) behind a clean API.
2015-11-26 15:40:08 +01:00
Antonio Scandurra
c8254566ef
Change verticalScrollbar's height according to block decorations
2015-11-26 15:34:45 +01:00
