Commit Graph

15508 Commits

Author SHA1 Message Date
Michelle Tilley
cff71e4806 Path normalization 2017-05-17 20:56:30 +02:00
Michelle Tilley
ff354ec3a7 Another logging 2017-05-17 20:56:24 +02:00
Michelle Tilley
86d45a5b9b Add temporary build debugging 2017-05-17 20:39:16 +02:00
Michelle Tilley
ddfd30bc22 Unregister custom package transpilation config after transpilation 2017-05-17 20:23:59 +02:00
Lee Dohm
3bc6b48d76 Merge pull request #14417 from atom/version-pinned-packages
Add config schema for version pinned packages
2017-05-15 13:45:08 -07:00
Lee Dohm
6740952c1c Add config schema for version pinned packages 2017-05-15 11:18:22 -07:00
Antonio Scandurra
2e363c3d58 Merge pull request #14403 from atom/fb-mdt-pane-steals-focus
Pane shouldn't steal focus from its children
2017-05-15 16:15:21 +02:00
Lee Dohm
1559c8a047 Merge pull request #12946 from jamsinclair/11848-fix-moving-line-without-line-ending
Fixes #11848 Moving line up without line ending
2017-05-13 15:00:46 -07:00
Matthew Dapena-Tretter
0aa4c1a976 Pane shouldn't steal focus from its children
This was removed in #14175 in order to solve #14173 (editors not being
focused when clicking tabs). However, it means that the pane steals
focus from its children. The solution is to add the guard back and to
solve #14173 in another way: by delaying the activation of the item
(see atom/tabs#439).
2017-05-12 13:50:19 -07:00
Antonio Scandurra
186bcd70a5 Fix running packages preloading tests in interactive mode
This change also makes the test more useful, as it verifies that reading
metadata from package.json's `packagesCache` works correctly.
2017-05-12 10:11:58 +02:00
Max Brunsfeld
07c2a8e8d6 Merge pull request #14339 from atom/mb-dont-change-focus-when-hiding-unfocused-dock
Don't change focus when hiding an unfocused dock
2017-05-11 16:28:27 -07:00
Nathan Sobo
b61e978a80 Merge pull request #14387 from atom/ns-mb-close-and-save-center
Act on active center items only when saving and closing
2017-05-11 14:29:39 -06:00
Antonio Scandurra
b1466742d4 Don't use snapshots in Task
They are not providing much value, as we are not already loading
anything from the snapshot require cache.
2017-05-11 16:52:02 +02:00
Antonio Scandurra
9346ff9e63 Speed up parsing the snapshot source map
When calling remote functions or emitting deprecation warnings
respectively Electron and Grim create a fake `Error` object to retrieve
the stack trace of the current call site.

When doing this for the first time, if the call site was located inside
a snapshotted file, previously we would parse the source map for the
snapshot and translate the position of each call in the stack trace.
However, since the snapshot source map is quite big, we were observing
major slowdowns when parsing it for the first time.

With this commit we will parse the snapshot source map while generating
the snapshot, which will allow to not pay for it during runtime.

Signed-off-by: Michelle Tilley <binarymuse@github.com>
2017-05-11 14:21:45 +02:00
Nathan Sobo
66609a1414 Act on active center items only when saving and closing
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2017-05-10 13:21:50 -06:00
Michelle Tilley
8a252dc903 Merge remote-tracking branch 'origin/master' into zhu-li-do-the-thing 2017-05-10 19:58:54 +02:00
Bryant Ung
f464bb3579 Merge pull request #13947 from anatoli26/master
Make an option to always restore the last session
2017-05-08 09:33:23 -07:00
Michelle Tilley
839c3ee905 Include github package in snapshot generation 2017-05-08 08:07:14 +02:00
Antonio Scandurra
ce81ac6201 Disable zoom only after the window has finished loading 2017-05-04 13:50:17 +02:00
Max Brunsfeld
2f336a64d3 Check dock focus using the DOM, not the active pane container state 2017-05-02 13:30:36 -07:00
Max Brunsfeld
a61accf175 Don't change focus when hiding an unfocused dock 2017-05-02 10:34:14 -07:00
Michelle Tilley
107e830508 Merge pull request #14309 from atom/mkt-allow-tooltips-to-recalculate-their-positions
Recalculate Tooltip positions when their contents change
2017-04-30 08:38:58 -07:00
hansonw
b5eca7c429 Call PackageManager.initialize from URL handler 2017-04-28 13:22:23 -04:00
Michelle Tilley
63920c2a78 🎨 2017-04-26 19:27:23 -07:00
Michelle Tilley
ca9054a4f8 👕 Fix linting errors 2017-04-26 16:01:43 -07:00
Michelle Tilley
dc6988c945 Reposition Tooltips when they mutate 2017-04-26 15:49:01 -07:00
Michelle Tilley
d56c1e292e Add Tooltip#recalculatePosition which resets the tooltip's position 2017-04-26 15:48:22 -07:00
Max Brunsfeld
fb42ad36f0 Fix bundled package path check to use path, not name 2017-04-21 09:41:35 -07:00
Damien Guard
601aa59e7b Do not treat packages in unusual locations as bundled despite name 2017-04-20 14:44:49 -07:00
Max Brunsfeld
643ba6e086 📝 Add types in Pane.destroyItem docs 2017-04-18 09:51:48 -07:00
Max Brunsfeld
52195e79ff Merge branch 'master' into fb-mdt-no-cmd-w-on-permanent-dock-items 2017-04-17 13:39:16 -07:00
Max Brunsfeld
0015e026a2 Add Workspace.paneContainerForItem method 2017-04-17 11:34:45 -07:00
Matthew Dapena-Tretter
a4c06c039d Add a way to force a pane to destroy its item
When cleaning up after a package that provides a permanent dock item,
you want to be able to destroy it easily. This provides API for doing
so.
2017-04-15 13:28:30 -07:00
Matthew Dapena-Tretter
a9d0618e88 Don't close permanent dock items 2017-04-15 13:09:08 -07:00
Matthew Dapena-Tretter
d40a14be29 Add tests for dock sizing behavior 2017-04-15 11:50:41 -07:00
Matthew Dapena-Tretter
f6b20cd31c Reduce dock initial size lookups
Previously, we would get the initial size every time we didn't have an
explicit one. With this commit, we only get the initial size when we
deserialize and when we go from 0 -> 1 pane items.

Also, if the dock doesn't already have an explicit size, we'll use the
preferred size of the item being dragged when peaking the dock. That
way, dropping it won't cause it to change size.
2017-04-15 11:50:19 -07:00
Matthew Dapena-Tretter
abd8f2c0b7 🐛 Fix URI resolution in openSync()
@Alhadis noticed I missed this in 53ec839.
2017-04-13 23:44:47 -07:00
Matthew Dapena-Tretter
915931dddd 🐛 Make sure docks affordance can always be revealed 2017-04-13 15:52:05 -07:00
Michelle Tilley
56e6048bfc Merge pull request #14146 from atom/mkt-as-improve-snapshotting
Improve snapshotting
2017-04-13 10:12:59 -07:00
Antonio Scandurra
b8e6689abf Merge pull request #14178 from atom/fb-mdt-resize-handle-shouldnt-cover-center
Prevent the resize handle from covering the center
2017-04-13 18:17:09 +02:00
Antonio Scandurra
fb6834d68b Require TextEditorElement eagerly
With snapshots, all the forbidden modules are required lazily. In the
case of `TextEditorElement` this can be problematic because users might
create editors via `document.createElement('atom-text-editor')`.

With this commit we will eagerly require
`src/text-editor-element.coffee`, thus forcing `TextEditorElement` to
register the HTML custom element and fixing the issue.
2017-04-13 11:03:35 +02:00
Max Brunsfeld
f4fceb0e20 Merge pull request #14177 from atom/fb-mdt-fix-docks-event-cleanup
Remove event listeners from correct element
2017-04-12 14:20:58 -07:00
Max Brunsfeld
a676246081 Merge pull request #14164 from atom/fb-mdt-when-shell-environment-loaded
Add `atom.whenShellEnvironmentLoaded()`
2017-04-12 11:53:50 -07:00
Matthew Dapena-Tretter
2ee851a218 Don't show resize handle at all for collapsed docks
They no longer have any functionality. Themes can add extra affordances
if they want.
2017-04-12 11:24:47 -07:00
Max Brunsfeld
9202160ca9 Merge pull request #14188 from atom/mb-ns-avoid-opening-duplicate-items
Always search a pane container w/ the given URI in workspace.open
2017-04-12 10:59:33 -07:00
Max Brunsfeld
82a7a6c78a Always search a pane container w/ the given URI in workspace.open 2017-04-12 10:23:49 -07:00
Nathan Sobo
8b8218bf81 Properly restore focus to center when hiding dock via toggle 2017-04-12 09:46:18 -06:00
Matthew Dapena-Tretter
2a2d657d98 Prevent the resize handle from covering the center
Currently, the absolutely positioned element is the only thing with a
size. That means that it'll cover the center. With this change, we give
a size to the (relatively-positioned) atom-dock element so that closed
docks take up canvas space instead.

I think @simurai mentioned this problem before but I wasn't following
and then forgot about it. 😖
2017-04-11 22:38:09 -07:00
Matthew Dapena-Tretter
8951ee7dd1 Remove event listeners from correct element 2017-04-11 22:14:18 -07:00
Nathan Sobo
e0309883bb Merge pull request #14137 from atom/ns-mb-document-workspace-item-interface
Document pane item interface on Workspace
2017-04-11 20:20:00 -06:00