Commit Graph

401 Commits

Author SHA1 Message Date
Nathan Sobo
cffadcf4a8 Remove CompositeCursor and Selection. Move their remaining methods into Editor 2012-06-11 10:11:33 -06:00
Nathan Sobo
31135afd9a Remove more references to CompositeSelection 2012-06-11 09:28:25 -06:00
Nathan Sobo
e549864219 Switch indent/outdentSelectedRows to activeEditSession 2012-06-11 09:20:46 -06:00
Nathan Sobo
8c52fedd0d Remove last of the extraneous CursorView methods 2012-06-10 21:53:54 -06:00
Nathan Sobo
e0aa49cb53 More CompositeCursor 💄. Preparing to axe it 2012-06-10 21:43:24 -06:00
Nathan Sobo
80cd63227a Remove methods from CompositeCursor + more 💄 2012-06-08 19:08:44 -06:00
Nathan Sobo
f8369d2ea1 More SelectionView 💄 2012-06-08 18:49:30 -06:00
Nathan Sobo
b0d1dd217b Cursor *model* clears selection when cursor moves, not the view. 2012-06-08 18:49:18 -06:00
Nathan Sobo
2161336c78 Move logic out of CompositeSelection into EditSession 2012-06-08 17:46:14 -06:00
Nathan Sobo
873c80eaf2 Move most remaining logical methods from selection view into model 2012-06-08 15:26:54 -06:00
Nathan Sobo
31bd38dfcc Move merging of intersecting selections into EditSession and the Selection model 2012-06-08 13:26:54 -06:00
Nathan Sobo
7eb01272ed Move text insertion and auto indent/outdent code from the selection view to the model 2012-06-08 12:31:29 -06:00
Nathan Sobo
f3144fe0d8 Base the screen range of the selection view on the selection model 2012-06-08 11:22:12 -06:00
Nathan Sobo
5a37a39b9b Tie creation of SelectionViews to adding Selection models to the EditSession 2012-06-07 18:20:00 -06:00
Nathan Sobo
7cdd4d684f Rename Selection to SelectionView in preparation for adding a Selection model 2012-06-07 17:05:14 -06:00
Nathan Sobo
608c4f48bf Remove more logic from cursor view 2012-06-07 16:58:45 -06:00
Nathan Sobo
f406786a3a Editor subscribes to EditSession for screen line changes. Remove more movement logic from cursor view. 2012-06-07 16:31:40 -06:00
Nathan Sobo
58c8117e4e 💄 2012-06-07 15:42:21 -06:00
Nathan Sobo
624cf3cbd3 EditSession informs cursor models of buffer changes (instead of Editor informing cursor views) 2012-06-07 15:41:35 -06:00
Nathan Sobo
d5d5caf764 Merge branch 'master' of github.com:github/atom into edit-session-refactor 2012-06-07 15:33:16 -06:00
Nathan Sobo
d872d12e04 Transfer word movement methods into cursor model 2012-06-07 15:33:01 -06:00
Corey Johnson
01d819abc8 💄 2012-06-07 10:54:42 -07:00
Nathan Sobo
d50c8f2d0e Merge branch 'master' of github.com:github/atom into edit-session-refactor 2012-06-07 11:40:01 -06:00
Nathan Sobo
21ae28657c Move moveTo(Beginning/FirstCharacter/End)OfLine methods to cursor model
Also, implement move to end of line by adding a clip option to setBufferPosition and passing [row, Infinity]
2012-06-07 11:28:40 -06:00
Corey Johnson
481ec16485 meta-w closes edit sessions until there are none left, then it closes the editor 2012-06-07 10:21:16 -07:00
Nathan Sobo
fccc88acaf Move moveLeft/Right/ToTop/ToBottom methods into cursor model 2012-06-07 10:57:21 -06:00
Nathan Sobo
ddf29e89ec Slave CursorView's screen position to its cursor model. Move moveUp and moveDown methods into cursor model. 2012-06-07 10:47:30 -06:00
Nathan Sobo
7387c553c3 Start introducing Cursor model in EditSession
The old cursor view still does most of the work, but to add a new cursor view we now must add a cursor model to the edit session at the correct position. The editor watches the 'add-cursor' event on edit session and add a corresponding CursorView to the CompositeCursor whenever a model is added. Next step: have the cursor view observe the cursor model and shadow its changes in position.
2012-06-06 21:52:19 -06:00
Nathan Sobo
e167afd794 Rename Cursor to CursorView in preparation for a Cursor model in EditSession 2012-06-06 18:01:08 -06:00
Nathan Sobo
c6fa2313ca 💄 2012-06-06 17:47:29 -06:00
Nathan Sobo
00b9c6db81 Active edit session 💄 2012-06-06 17:46:00 -06:00
Nathan Sobo
ff52993c9e Fix bugs when switching between EditSessions 2012-06-06 17:00:02 -06:00
Nathan Sobo
024618b69a Build Renderer in EditSession and assign it when switching to that EditSession 2012-06-06 12:42:53 -06:00
Nathan Sobo
4885af4fa8 Merge branch 'master' of github.com:github/atom 2012-06-06 12:11:00 -06:00
Nathan Sobo
5a28656259 Introduce EditSession class, which replaces edit session hashes 2012-06-06 12:10:49 -06:00
Corey Johnson
3792d24c9f Mini editor's don't toggle active-editor-path-change event 2012-06-05 13:43:03 -07:00
Nathan Sobo
e6af7a9515 Adjust the width of rendered lines to account for the longest line 2012-06-05 14:26:06 -06:00
Nathan Sobo
3a776347ff Avoid leaking window resize subscriptions in editor spec 2012-06-05 14:25:08 -06:00
Nathan Sobo
e7ffaa1757 Merge branch 'master' of github.com:github/atom 2012-06-05 12:48:16 -06:00
Nathan Sobo
911a417cb8 Rename maxLineLength to softWrapColumn 2012-06-05 12:47:39 -06:00
Corey Johnson
4f364e8cd8 Add newline-below event 2012-06-05 11:30:29 -07:00
Corey Johnson
afab19938e Use wasReversed instead of isReversed to show the local variable stores some temporal state. 2012-06-05 11:30:29 -07:00
Nathan Sobo
4dc41dcc21 💄 2012-06-05 11:09:40 -06:00
Nathan Sobo
e8705b7807 Merge branch 'master' of github.com:github/atom 2012-06-05 10:59:41 -06:00
Nathan Sobo
c24b8a90b2 If lines are removed after a renderer change, update padding appropriately 2012-06-05 10:59:11 -06:00
Corey Johnson
ce25b33c25 Inserting a newline before a top-level c-style statement (starting with a '{') no longer auto-indents it. 2012-06-05 09:09:20 -07:00
Nathan Sobo
9cfbce826d WIP: Don't allow impossibly high scroll top values.
It fixes the move to bottom issues, but breaks some other tests. Not sure why yet...
2012-06-04 21:57:10 -06:00
Nathan Sobo
4eb4c95a86 Constrain the end of the old screen range to the lastRenderedScreenRow, not maxScreenRow
Constraining the end of the new range max screen row instead of the last rendered row is what allows the buffer to get longer when the last rendered screen row is smaller than the last visible screen row. But constraining the end of the old range to this was causing artifacts. The old range should always be constrained to what is rendered on screen now, not what "could be". What "could be" is the domain of the new range.
2012-06-04 20:48:29 -06:00
Nathan Sobo
8f9d066d99 Restore reverted rename. clearLines -> clearRenderedLines 2012-06-04 20:32:50 -06:00
Nathan Sobo
c3a157a544 Revert "Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines."
This reverts commit 419d7b1dec.

Conflicts:

	spec/app/editor-spec.coffee
2012-06-04 20:29:40 -06:00