Commit Graph

18 Commits

Author SHA1 Message Date
Max Brunsfeld
799a792f7f Remove public docs for DirectorySearch and DefaultDirectorySearcher 2015-11-18 13:05:27 -08:00
Ben Ogle
591db01067 Spy on Task::terminate instead of passing an obj through 2015-07-29 11:48:49 -07:00
Ben Ogle
a4076dcfa5 Terminate the task after finishing 2015-07-28 17:34:45 -07:00
Ben Ogle
b518075070 Use globalExclusions option for the ignoredNames 2015-07-27 17:10:53 -07:00
Michael Bolin
3c44bc06f4 Revert "Revert "Introduce atom.directory-searcher service v0.1.0.""
This reverts commit 262d41c306.
2015-06-10 23:30:25 +01:00
Max Brunsfeld
262d41c306 Revert "Introduce atom.directory-searcher service v0.1.0." 2015-06-09 11:51:30 -07:00
Michael Bolin
1a6c542b45 Update comment. 2015-06-09 15:34:10 +01:00
Michael Bolin
0630bce95c Two things:
* Removed the `Directory` argument to `didSearchPaths`.
Now each searcher gets its own instance of `didSearchPaths` that is parameterized by provider.
* Simplified `DefaultDirectorySearcher.search()` so it creates one `DirectorySearch`
rather than one per `Directory` passed to `search()`.
2015-06-09 15:34:10 +01:00
Michael Bolin
7dc3d07f8a Changed the contract of DefaultDirectorySearcher in two significant ways:
* `search()` takes an array of `Directory` objects rather than an individual object.
* `options.didSearchPaths` now takes the `Directory` in addition to the `count` as an argument.
2015-06-09 15:34:09 +01:00
Michael Bolin
36123faf5d Changed DefaultDirectorySearcher to take multiple directories.
Still need to update `workspace.coffee` to make better use of this.
2015-06-09 15:34:09 +01:00
Michael Bolin
318498464a Responded to all of @maxbrunsfeld's comments except for:
* The effect of a failed search.
* Letting `DirectorySearcher::search` take multiple directories.

I'm working on those now.
2015-06-09 15:34:09 +01:00
Michael Bolin
f7e822d41f Make delegate method names more delegate-like. 2015-06-09 15:34:09 +01:00
Michael Bolin
4eb30f3925 Switch to the delegate pattern,
eliminating a nasty race condition and deleting a lot of code.
2015-06-09 15:34:09 +01:00
Michael Bolin
fa3fd9c50c Remove empty param lists as per the linter. 2015-06-09 15:34:08 +01:00
Michael Bolin
735bdcca08 Two things:
1. Update documentation for `default-directory-search.coffee`.
2. Ensure that multiple `DirectorySearch` searches are run in series rather than in parallel to conserve resources.
2015-06-09 15:34:08 +01:00
Michael Bolin
fd670a4dd4 Remove myResolve local variable that I was using for debugging. 2015-06-09 15:34:08 +01:00
Michael Bolin
7294e0cda4 Change DirectorySearcher to return a DirectorySearch. 2015-06-09 15:34:08 +01:00
Michael Bolin
7781e34ba2 Introduce atom.directory-searcher service v0.1.0.
The contract for a provider for the `atom.directory-searcher` service
is defined by the spec of the `DefaultDirectorySearcher`.

This modifies `Workspace::scan()` to use the appropriate `DirectorySearcher`
for each member of `atom.project.getDirectories()` when scanning the workspace
for files that match the specified regex.
2015-06-09 15:34:08 +01:00