Antonio Scandurra
1f20ab5170
Use LinearLineTopIndex in BlockDecorationsPresenter
2015-12-02 14:49:36 +01:00
Antonio Scandurra
60b1d20667
🔥 Remove old code
2015-12-02 09:55:47 +01:00
Antonio Scandurra
1e07b8df05
Handle position between rows correctly
2015-12-02 09:13:06 +01:00
joshaber
36604141b9
Let's use a separate method for side-effecting.
2015-12-01 17:41:51 -05:00
joshaber
5019cc31ab
These can be const too.
2015-12-01 14:16:50 -05:00
joshaber
4e64af9155
ES6 some more.
2015-12-01 13:53:57 -05:00
Antonio Scandurra
e0b1cabb21
Implement a linear structure for block decoration coordinates
...
We still cannot handle `::rowForTopPixelPosition` when the passed top position
is in the middle of two rows and there's also a block decoration. We'll get
there eventually.
Also, the specs in this commit should serve as a good test suite for the future
logarithmic data structure.
2015-12-01 19:33:37 +01:00
joshaber
64d4716003
Use modern imports.
2015-12-01 12:47:11 -05:00
joshaber
c76d0f0438
Update the current branch as well.
2015-12-01 12:22:25 -05:00
joshaber
ee3b655067
git-repository will refresh us on window focus.
2015-12-01 12:19:51 -05:00
joshaber
9765cb55ea
Merge branch 'master' into dh-async-repo
2015-12-01 10:16:48 -05:00
Antonio Scandurra
d24290357a
Implement block decorations in the components land
2015-12-01 13:36:23 +01:00
Douwe Maan
2f78a274a1
Only add explicitly opened files/folders as recent documents
2015-12-01 11:07:10 +01:00
Douwe Maan
948aaa0652
Add opened files and folders to recent documents menu
2015-12-01 11:07:10 +01:00
Antonio Scandurra
47b16c513c
Make sure cursors are updated with respect to block decorations
2015-12-01 09:48:11 +01:00
Kevin Sawicki
838f6fb7b1
Merge pull request #9606 from DouweM/dock-menu
...
Add OS X dock menu with 'New Window' option
2015-11-30 17:15:32 -08:00
Kevin Sawicki
c5a8a81da7
Merge pull request #9802 from ssorallen/config-docs
...
Correct config.coffee doc references to `scope`
2015-11-30 17:06:51 -08:00
Max Brunsfeld
3827b19da4
Merge pull request #9687 from atom/mb-deprecate-load-time-package-code
...
Provide package.json fields so we can defer requiring packages' main modules
2015-11-30 15:53:37 -08:00
Nathan Sobo
f139992585
Avoid infinite recursion in Error.prepareStackTrace
...
Previously, prepareStackTraceWithStackAssignment could end up calling
itself when third-party code assigned Error.prepareStackTrace back
to its original value. Now, we short-circuit this process if the
rawStack property has already been assigned.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-11-30 10:51:21 -08:00
Max Brunsfeld
d058814957
Merge remote-tracking branch 'origin/master' into mb-deprecate-load-time-package-code
...
Conflicts:
package.json
2015-11-30 10:20:31 -08:00
joshaber
e1aa23b92d
Const and comparison fixes.
...
h/t @YuriSolovyov
2015-11-30 11:47:06 -05:00
joshaber
3a06953820
Merge branch 'master' into dh-async-repo
2015-11-30 11:44:20 -05:00
Antonio Scandurra
da1fd69a1f
Start implementing BlockDecorationsComponent
2015-11-30 15:48:09 +01:00
Antonio Scandurra
526a97562e
Include block decorations as a separate object on presenter's state
2015-11-30 15:05:15 +01:00
Antonio Scandurra
8a54a2c15b
Use a boolean in each line state object
2015-11-30 14:44:58 +01:00
Antonio Scandurra
539a5b0ae7
🐎 Do as little pixel conversion as possible
...
We desperately need a tree-based data structure. 😢
2015-11-30 14:34:16 +01:00
Antonio Scandurra
b998e7f2d9
🐎 Incremental updates for block decorations
2015-11-30 14:03:45 +01:00
Antonio Scandurra
0419fb16a0
🎨 Improve names a bit
2015-11-30 10:19:53 +01:00
Antonio Scandurra
ef851a822c
🎨 Move block decoration related stuff into its own presenter
2015-11-30 10:12:44 +01:00
Wliu
8e6c8b02bb
Switch back to ipc-main in atom-portable.coffee
2015-11-27 13:20:22 -05:00
Antonio Scandurra
0159d5c31e
🎨
2015-11-27 16:58:08 +01:00
Antonio Scandurra
6ad21307cc
Provide blockDecorationsHeight for each line number
2015-11-27 16:27:01 +01:00
Antonio Scandurra
6365c86992
Include blockDecorations inside each line's state
2015-11-27 14:32:01 +01:00
Antonio Scandurra
6611cf8353
Force cursor to be tall as ::lineHeight
2015-11-27 14:05:05 +01:00
Antonio Scandurra
587f862612
Use LinesYardstick consistently
2015-11-27 12:55:09 +01:00
Antonio Scandurra
e1e06580c1
Move position conversion in LinesYardstick
2015-11-27 12:47:47 +01:00
Antonio Scandurra
1a8d7b486d
Remove caching by screen rows
...
Because we cannot use them as a cache key, because markers' position can change
at any time. Performance-wise this is slow with many markers, as we need to do a
lot of buffer-to-screen conversions.
2015-11-27 12:29:14 +01:00
Antonio Scandurra
0b5638f749
Make sure tile positions are computed correctly
2015-11-27 10:47:25 +01:00
Antonio Scandurra
6e2587bc8c
🐎 Cache screen row height
...
I am trying to defer the usage of fancy algorithms as much as possible. The
current one is linear and should probably be changed, but it performs quite
decently for the time being. Maybe with some more caching we could even avoid to
implement a tree data structure?
2015-11-27 10:30:44 +01:00
Antonio Scandurra
a9cb1bda8d
Use ::positionForRow in ::updateTilesState
...
The algorithm is still super sloooow 🐌 , but we'll fix that in a later
commit.
2015-11-27 10:16:38 +01:00
Antonio Scandurra
1b5fd18630
Use ::rowForPosition and ::positionForRow instead of simple math
2015-11-27 09:54:14 +01:00
Antonio Scandurra
02651b7a58
🎨 Rename to ::setBlockDecorationDimensions
2015-11-26 16:10:08 +01:00
Antonio Scandurra
5ac7ffcf48
🎨 Rename to ::blockDecorationsDimensionsById
2015-11-26 16:09:21 +01:00
Antonio Scandurra
89d9a2ce83
🎨 Create block decorations in TextEditor
...
This is just an experiment, although I like that we can hide some information
(irrelevant to the user) behind a clean API.
2015-11-26 15:40:08 +01:00
Antonio Scandurra
c8254566ef
Change verticalScrollbar's height according to block decorations
2015-11-26 15:34:45 +01:00
Antonio Scandurra
5dfd765bcf
Do not override user-defined keymaps when reloading packages
2015-11-26 10:39:47 +01:00
Wliu
71574d785c
Merge remote-tracking branch 'master' into wl-electron-35
...
# Conflicts:
# package.json
# src/application-delegate.coffee
2015-11-25 18:44:40 -05:00
Ross Allen
aac52b7020
Correct config.coffee doc references to scope
...
The scope selector is referred to with the key `scope` on the options
object, not `scopeDescriptor` as the current docs claim. Reference
`scope` correctly.
Mark `options` as optional for `::observe` because the arguments
collection is checked for length, and a length of 2 assumes the second
argument is `callback`. `options` is actually optional.
2015-11-25 09:44:20 -08:00
Max Brunsfeld
aecc2598f9
Restore private activateConfig method to fix settings-view
2015-11-24 15:14:39 -08:00
Nathan Sobo
8978691831
Merge pull request #9773 from atom/mb-ns-prepare-stack-trace-fixes
...
Allow Error.prepareStackTrace to be temporarily reassigned
2015-11-24 11:59:53 -07:00
