Commit Graph

7444 Commits

Author SHA1 Message Date
Nathan Sobo
0410ac9e8f Fix uncaught exceptions in ThemeManager specs 2017-01-18 10:19:25 -07:00
Nathan Sobo
4ef2924f55 Fix exceptions activating invalid packages in tests 2017-01-18 10:19:25 -07:00
Nathan Sobo
a433a84ab5 Fix describe block indentation 2017-01-18 10:19:25 -07:00
Max Brunsfeld
a57b627a58 Re-throw package activation exceptions in test mode 2017-01-18 10:19:25 -07:00
Damien Guard
623caaf85d Merge pull request #13605 from atom/dg-correct-portable-path-windows
Correct the portable path location on Windows
2017-01-14 09:35:27 -08:00
Damien Guard
090bbf9e77 Fix spec for path 2017-01-14 09:04:49 -08:00
Nathan Sobo
76d84a7890 Handle multiple selections intersecting a line in duplicateLines 2017-01-12 13:38:19 -07:00
Christopher Chedeau
ef7ce7cd3a Always reserve two digits on the line number gutter
We are working on a feature that changes the content of the editor when you mouse over some things and it makes the UI jump when going from 1 line to > 10. This makes the UI feel really bad.

I've looked at Sublime and the 1-9 state is the same as 1-99, only when you reach 100 lines then it jumps. I think that it is a better behavior as you want to minimize jumps as much as possible and it is extremely likely that you are going to hit the 9-10 lines threshold.

![](http://g.recordit.co/ABIlZf5eTx.gif)

While this is being reviewed and until the new version shipped, we are going to monkeypatch Atom in order to get this feature.

```js
var presenter = atom.textEditors.editors.entries().next().value[0].presenter.__proto__;
var old_updateLineNumberGutterState = presenter.updateLineNumberGutterState;
presenter.updateLineNumberGutterState = function() {
  var res = old_updateLineNumberGutterState.apply(this, arguments);
  this.lineNumberGutter.maxLineNumberDigits = Math.max(2, this.lineNumberGutter.maxLineNumberDigits);
  return res;
};
```

Released under CC0
2017-01-10 18:14:50 -08:00
Max Brunsfeld
d6bddb4ce6 Avoid assertions about application.json in main process test
We can test the user-facing behavior by launching a second instance
of AtomApplication.

Refs #13564
2017-01-09 11:31:25 -08:00
Vladimir Timofeev
a7dda0e6f6 Refactor test code 2017-01-08 00:03:36 +03:00
Vladimir Timofeev
be57e4cd48 Additional check that storage/application.json exists 2017-01-07 23:58:28 +03:00
Vladimir Timofeev
4d5312fec5 Restore test behaviour to check content of storage/application.json 2017-01-07 23:52:29 +03:00
=
1fb066ad68 Really fix tests on windows
Path names with backslashes was not quoted.
2017-01-07 23:11:31 +03:00
Vladimir Timofeev
94f28a3877 Another try to fix tests on Windows.
Wait for ipc.
2017-01-07 14:10:24 +03:00
Vladimir Timofeev
4ba6919d4d Try fix tests on Windows.
Only count AtomApplication#saveState calls, not saved content.
2017-01-07 13:04:05 +03:00
Vladimir Timofeev
bc77a79e86 Add test to ensure the state saved when project folders changed. 2017-01-07 10:59:22 +03:00
Ian Olsen
d35a63aa6a Basic test for user keymap loaded event 2017-01-05 17:12:02 -08:00
Max Brunsfeld
126f5380ba Emit editor destroyed event after releasing the editor's buffer 2017-01-03 15:18:01 -08:00
Max Brunsfeld
6f13159549 Don't throw exceptions when using editor APIs after destroying the editor
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-01-03 14:00:50 -08:00
Max Brunsfeld
79e68b462d Avoid using torn-down properties in specs 2017-01-02 11:55:41 -08:00
Max Brunsfeld
f4371efb74 Fix usages of destroyed buffers in specs 2017-01-02 11:32:02 -08:00
Lee Dohm
640497081e 👕 2016-12-22 16:39:40 -08:00
Christopher Chedeau
a33ab44966 Add atom.tooltips.findTooltips(target)
Right now, it is not possible to hide a tooltip programatically. This is useful when we know better than the tooltip implementation that we did an action that should hide it.

After discussing with @lee-dohm, he suggested the findTooltips API that mimicks the KeyMapManager API.

Released under CC0
2016-12-23 00:01:42 +00:00
Michelle Tilley
96b7f7f8e6 Fix title bar tests on non-macOS systems 2016-12-19 19:43:15 -08:00
Michelle Tilley
c8865c2c05 Add failing test for incorrect title bar behavior 2016-12-19 19:32:33 -08:00
Max Brunsfeld
2095015e82 Merge pull request #13453 from atom/mb-ns-integrate-new-display-layer
Use new text-buffer version with a more efficient DisplayLayer
2016-12-16 10:25:10 -08:00
Nathan Sobo
f9dfabfdff Merge pull request #13194 from farnabaz/master
fix text selection and cursor position in lines with rtl text
2016-12-15 15:37:54 -07:00
Nathan Sobo
b087ab2734 Disable measurement tests for RTL text on Windows
@damieng This is unlike the other tests in this file in that none of the
assertions pass. Maybe you could take a look at some point to enable at
least some coverage on Windows for this?
2016-12-15 03:16:21 -07:00
Max Brunsfeld
a06d77710c Adjust LinesYardstick assertion to reflect removal of redundant leading whitespace span 2016-12-14 14:54:56 -08:00
Nathan Sobo
feb60ca0d3 Merge branch 'master' into farnabaz-master 2016-12-14 13:34:21 -07:00
Nathan Sobo
4e7d13b227 Clean up tests 2016-12-14 13:30:34 -07:00
Max Brunsfeld
d7b86d9187 Merge remote-tracking branch 'origin/master' into mb-ns-integrate-new-display-layer 2016-12-14 12:16:50 -08:00
Max Brunsfeld
8afeae46b4 Adjust assertion now that paired characters aren't wrapped in spans
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-12-13 17:29:36 -08:00
Max Brunsfeld
4f7b9e03c8 Expect a single leading whitespace token w/ atomic soft tabs & indent guides disabled
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-12-13 17:28:54 -08:00
Damien Guard
ad77c319ad Merge pull request #13431 from atom/dg-use-npm-chromedriver
Switch to npm provided chromedriver instead of manually downloaded
2016-12-13 13:12:03 -08:00
Damien Guard
438168e62c Do not use the chromedriver wrapper as it spews to stdout 2016-12-13 12:13:47 -08:00
Nathan Sobo
8b181063ca Adjust spec now that tab length does not affect leading space tokens 2016-12-13 00:09:09 -07:00
Max Brunsfeld
65edebda73 Update test to reflect new soft wrap indent clipping behavior
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-12-12 17:05:18 -08:00
Damien Guard
f25a718c02 Switch electron-chromedriver from GitHub download to npm install 2016-12-12 16:31:38 -08:00
Ian Olsen
f9c96818e6 Merge pull request #13272 from atom/fb-vjeux-fix-gutter-prepend
Fix prepending multiple gutters at once
2016-12-12 15:55:46 -08:00
Damien Guard
b83bb95b56 Merge pull request #13426 from atom/dg-portable-enhancement
Portable mode enhancements
2016-12-12 15:55:17 -08:00
Nathan Sobo
953e8eec0e Merge branch 'master' into MikeInnes-overlay-scroll 2016-12-12 08:38:38 -07:00
Damien Guard
5a446ff467 Clean up portable mode, try local .atom before ATOM_HOME 2016-12-11 15:59:24 -08:00
Max Brunsfeld
efd20774de Make each atom-text-editor keep a consistent hidden input node for its lifetime
Signed-off-by: Damien Guard <damieng@github.com>
2016-12-08 16:05:45 -08:00
Damien Guard
9d553d2cfa Remove errant debugger call in spec 2016-12-06 22:30:01 -08:00
Damien Guard
60fc36a969 Improve array path matching in history 2016-12-06 14:29:14 -08:00
Antonio Scandurra
7f4b43085b Merge pull request #13372 from atom/as-fix-package-activation-hook
Activate packages immediately if hook had already been triggered
2016-12-05 15:53:53 +01:00
TiagoDanin
c5c3f5cb01 Replace "osx" to "macOS" 2016-12-04 15:28:43 -03:00
Damien Guard
c2a0735607 Bypass checkoutHeadForEditor/displays a confirmation dialog by default spec on Windows for reliability 2016-12-02 15:01:06 -08:00
Antonio Scandurra
e943f7a19d Add precondition test 2016-12-02 13:30:24 +01:00