Commit Graph

16347 Commits

Author SHA1 Message Date
Max Brunsfeld
9a95372613 Merge pull request #15977 from atom/mb-use-language-modes
Move `toggleLineComments` method from TokenizedBuffer to TextEditor
2017-10-24 16:03:21 -07:00
Jason Rudolph
622589f4f7 Merge pull request #15958 from atom/decaf-view-registry
 Decaffeinate `ViewRegistry`
2017-10-24 08:41:32 -04:00
Nathan Sobo
84f6f3e525 Merge pull request #15976 from atom/paste-without-reformatting
Add command to paste without reformatting
2017-10-23 20:21:38 -06:00
Max Brunsfeld
cfe5cfce76 Move .toggleLineComments method from TokenizedBuffer to TextEditor 2017-10-23 17:44:45 -07:00
Max Brunsfeld
311567ecec Simplify .toggleLineComments method to avoid using oniguruma 2017-10-23 16:45:12 -07:00
Nathan Sobo
fd85c1bb5a Add Paste without reformatting command
It is bound to cmd-shift-V on macOS and ctrl-shift-V on Windows and
Linux. It is also available in the edit menu.
2017-10-23 17:14:41 -06:00
leroix
c2662761f0 Merge pull request #15954 from atom/faster-overlay-resizing
Only update overlay instead of text editor when resize occurs
2017-10-23 17:05:57 -06:00
Nathan Sobo
6701644bbd Respect format-preserving options in TextEditor.pasteText 2017-10-23 17:02:41 -06:00
Nathan Sobo
bbbf09ecf2 Add preserveTrailingLineIndentation option to Selection.insertText
We can use this to support a new command that preserves all formatting
when pasting.
2017-10-23 16:46:38 -06:00
Max Brunsfeld
49a2d0eeeb Merge pull request #15974 from atom/mb-fix-fold-current-row-error
Fix exception when trying to fold non-foldable row
2017-10-23 11:12:52 -07:00
Max Brunsfeld
8d532e7780 Fix exception when trying to fold non-foldable row 2017-10-23 10:20:45 -07:00
Jason Rudolph
89bf89c93d Merge pull request #15938 from atom/decaf-window-event-handler
Decaffeinate `src/window-event-handler.coffee`
2017-10-23 08:38:51 -04:00
Indrek Ardel
0511c0ae4a Remove unused argument 2017-10-23 04:11:23 +03:00
Jason Rudolph
dfd1332a01 👔 Fix "A constructor name should not start with a lowercase letter" 2017-10-20 21:17:41 -04:00
Jason Rudolph
a67272e6ff 👔 Fix "Expected a conditional expression & instead saw an assignment" 2017-10-20 21:17:15 -04:00
Jason Rudolph
cdf3be846b Decaffeinate src/view-registry.coffee 2017-10-20 21:17:15 -04:00
Justin Ratner
089717cbd3 fix failing test 2017-10-20 15:46:27 -06:00
Justin Ratner
d0bdbb861b update overlay itself instead of text editor when resize occurs 2017-10-20 11:30:50 -06:00
Indrek Ardel
0f89211d55 Prioritize first line matches over bundled/non bundled cirteria 2017-10-20 13:34:15 +03:00
Jason Rudolph
2289e2b828 Decaffeinate src/window-event-handler.coffee 2017-10-19 08:59:46 -04:00
Antonio Scandurra
280253fdfa Merge pull request #15916 from atom/as-jr-stop-dragging-when-interacting-with-keyboard
Stop dragging only when user interacts with keyboard
2017-10-18 11:38:52 +02:00
Michelle Tilley
d6a3a60469 Merge pull request #11399 from atom/mkt-url-based-command-dispatch
Package URL handlers - mapping atom:// URIs to package functions
2017-10-17 16:29:27 -07:00
Michelle Tilley
5bbf0b6ade 🎨 package activation 2017-10-17 15:37:49 -07:00
Michelle Tilley
8b989ffc4e More url -> URI 2017-10-17 15:29:27 -07:00
Michelle Tilley
9b5f95a14d openWithAtomUrl -> openPackageUriHandler 2017-10-17 15:26:29 -07:00
Michelle Tilley
5e43084cd3 url -> URI 2017-10-17 15:23:10 -07:00
Michelle Tilley
e02337265a Reset history when destroying UrlHandlerRegistry 2017-10-17 14:42:11 -07:00
Michelle Tilley
2504118d8b ⌨️ fix typo 2017-10-17 14:42:00 -07:00
Michelle Tilley
2b70f57405 🎨 return undefined 2017-10-17 14:41:50 -07:00
Michelle Tilley
7aa79bc3a1 Unregister package URL handlers when deactivating 2017-10-17 12:59:21 -07:00
anon
894f5471e6 textChange(CoreSettings): remove redundancy 2017-10-18 22:09:11 +02:00
Michelle Tilley
5e96429c9e Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch 2017-10-17 11:18:02 -07:00
Antonio Scandurra
65af9e953b Stop dragging only when user interacts with keyboard
Previously, we used to prevent the user from dragging the selection
further when the buffer was about to change. This was problematic
because any change in the buffer, even one that was performed
"automatically" by a package, would cancel the dragging action and
result in a confusing experience for the user.

On the other hand, we want to prevent users from accidentally selecting
text when they perform an edit (see #15217, #15405).

This commit addresses both concerns by canceling the dragging as soon as
the user interacts with the keyboard, instead of canceling the dragging
when the buffer is about to change.

One downside of this approach is that it changes the behavior of
pressing a keystroke that does not result in a buffer change, e.g.
Shift, Arrow Keys, etc.

Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
2017-10-17 18:50:20 +02:00
Jason Rudolph
274b809b12 Merge pull request #15898 from atom/decaf-project
Decaffeinate `src/project.coffee`
2017-10-16 21:23:14 -04:00
Jason Rudolph
a4ea46c57e Rename local variable
/xref: https://github.com/atom/atom/pull/15898#discussion_r144850427
2017-10-16 11:04:56 -04:00
Jason Rudolph
5ec9d0f134 🐛 Fix bug disposing watchers in Project::addPath
`this.rootDirectories` is an Array of Directory objects. `path` is a
String. Therefore, `this.rootDirectories.includes(path)` will always
evaluate to `false`. We instead need to look for an entry in
`this.rootDirectories` where the Directory object's path is equal to the
given path.
2017-10-15 10:00:14 -04:00
Jason Rudolph
5937b95b49 Fix loop contructs that got borked by decaffeinate 2017-10-15 10:00:02 -04:00
Jason Rudolph
790e202549 🎨 2017-10-15 10:00:02 -04:00
Jason Rudolph
8df4cfbe58 🎨 2017-10-15 10:00:02 -04:00
Jason Rudolph
48625584e4 🎨 Use shorter variations of null checks 2017-10-15 10:00:02 -04:00
Jason Rudolph
b2571e8976 Avoid inline assignments 2017-10-15 10:00:02 -04:00
Jason Rudolph
99aaafed1b DS103: Rewrite code to no longer use __guard__ 2017-10-15 10:00:02 -04:00
Jason Rudolph
94a552149d Remove unnecessary use of Array.from 2017-10-15 10:00:01 -04:00
Jason Rudolph
c1b0afe969 Remove unnecessary code created because of implicit returns 2017-10-15 10:00:01 -04:00
Justin Ratner
0c35c26805 fix infinite overlay resizing loop 2017-10-14 19:05:54 -06:00
Jason Rudolph
8f40af16a9 🎨 2017-10-14 17:07:09 -04:00
Jason Rudolph
dd6359b507 Remove Babel/TypeScript constructor workaround 2017-10-14 12:47:19 -04:00
Jason Rudolph
cab8824aae 👔 Fix linter violations 2017-10-14 12:47:00 -04:00
Jason Rudolph
25b7ddb328 ☠️ Decaffeinate src/project.coffee
Apply results of running:

```
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes'

$ standard --fix src/project.js
```
2017-10-14 11:58:47 -04:00
Justin Ratner
ae65b49b9b fix lint errors 2017-10-12 23:46:53 -06:00