Corey Johnson
d7ee81418d
Remove editor class form ReactEditorView, it is on EditorComponent
...
I couldn’t recreate the problem with activation events mentioned
fa66689c07
2014-06-05 14:13:41 -07:00
Nathan Sobo
2ee2efeb84
Add ReactEditorView::isFocused shim
2014-06-05 12:07:52 +09:00
Nathan Sobo
367e429162
Add ReactEditorView::setText
2014-06-05 12:03:56 +09:00
Nathan Sobo
8417dfd10e
Add the ReactEditorView::updateDisplay shim
2014-06-05 12:01:09 +09:00
Nathan Sobo
15d1c5f992
Add ReactEditorView::setWidthInChars shim
2014-06-05 11:59:02 +09:00
Nathan Sobo
e0b1a0cfa7
Add ReactEditorView::getFontSize
2014-06-05 11:58:48 +09:00
Nathan Sobo
cfd9baa0d6
Use Editor::getVisibleRowRange instead of the rendered row range
...
The rendered row range is larger than the visible row range to force the
DOM to break up repaints. This is a more accurate method to us.
2014-06-05 11:54:28 +09:00
probablycorey
1d80c35708
Add active property
2014-06-04 17:33:49 -07:00
probablycorey
ad88ace448
Add getFirstVisibleScreenRow and getFirstVisibleScreenRow
2014-06-04 17:18:00 -07:00
probablycorey
a6d870bf4c
Add underlayer an overlayer classes to the correct elements
2014-06-04 16:32:50 -07:00
Nathan Sobo
fa66689c07
Add .editor class to react wrapper for package activation events
2014-06-04 21:07:13 +09:00
Nathan Sobo
905b28975e
Add split methods
2014-06-04 21:06:41 +09:00
Nathan Sobo
7e5f667b31
Don't assume ::component is defined
2014-06-04 21:06:27 +09:00
Nathan Sobo
f103e72c01
Remove exceptions related to unassigned lineHeight
...
These exceptions break specs when simulateDomAttachment is used. They
were only present to ensure correct sequencing during development of the
react editor, so it's safe to remove them for now.
2014-06-04 21:05:29 +09:00
Nathan Sobo
eeb44407e3
Add ReactEditorView::getModel
2014-06-04 19:15:56 +09:00
Corey Johnson
087b52c9b4
Remove unnecessary append method.
2014-06-03 17:13:23 -07:00
Corey Johnson
18f7297968
Use actual property for overlayer
2014-06-03 17:12:56 -07:00
Corey Johnson
3cd34e0b4d
Add gutter.getLineNumberElement shim
2014-06-03 15:25:26 -07:00
Corey Johnson
25e3e46166
Make overlayer a property
2014-06-03 14:57:46 -07:00
Corey Johnson
2c84d69ff2
Add overlayer shim
2014-06-03 14:40:30 -07:00
Corey Johnson
3fb28803b5
Add append shim
2014-06-03 14:40:17 -07:00
Corey Johnson
8e095d7b5b
Merge pull request #2164 from steffengy/fix-indent
...
Fix indenting of HTML tags for instance. Fix #1294
2014-06-03 12:01:44 -07:00
Corey Johnson
dac792a243
Remove .editor class from ReactEditorView
...
ReactEditorView and EditorComponent were using the editor class. This
caused context menus that used `.editor` as the selector to display
twice.
2014-06-03 11:36:55 -07:00
Kevin Sawicki
31b3d8f967
Add missing require
2014-06-03 11:06:02 -07:00
Corey Johnson
ce527aea10
Pull out menu item building into seperate method
2014-06-03 10:51:46 -07:00
Kevin Sawicki
a7a9301f25
Quote all arguments to cmd.exe
...
This is required since the command or arguments may have spaces that will
be interpreted as separate arguments unless quotes surround it.
Closes #2231
Closes atom/symbols-view#37
2014-06-03 10:50:00 -07:00
Corey Johnson
950338ed22
Fix linter errors
2014-06-03 10:17:53 -07:00
Corey Johnson
8ed3b7a250
Merge pull request #2134 from erikhakansson/AdvancedContextMenu
...
Advanced context menu
2014-06-03 10:13:37 -07:00
Nathan Sobo
749dba1ac7
Prevent LinesComponent from updating on simple cursor movement
2014-06-03 19:23:19 +09:00
Nathan Sobo
a28566a559
Add ScrollbarCornerComponent::shouldComponentUpdate
2014-06-03 19:18:14 +09:00
Nathan Sobo
b47f6265c7
Move gutter width measurement into EditorComponent
2014-06-03 18:30:24 +09:00
Nathan Sobo
9511c952af
💄
2014-06-03 18:19:11 +09:00
Nathan Sobo
be0877327e
Kill comment
2014-06-03 18:18:53 +09:00
Nathan Sobo
3134bfda95
Update selections when the font size or font family change
2014-06-03 17:43:57 +09:00
Nathan Sobo
3aefa53b33
Batch together line and character width measurement after font changes
...
This ensures we only perform a single update with the most up-to-date
information about line height, default character width, and specific
character widths. If this update causes more lines to be drawn we may
measure again, but not necessarily.
2014-06-03 17:43:56 +09:00
Nathan Sobo
4fd07a4cf3
Subscribe to scroll view DOM events in ::listenForDOMEvents
2014-06-03 17:43:56 +09:00
Nathan Sobo
03463da729
Allow Editor::batchUpdates calls to be nested
2014-06-03 17:43:56 +09:00
Nathan Sobo
1cc5ef3479
Update selections when the line height changes
2014-06-03 17:43:56 +09:00
Nathan Sobo
77f78d0a11
Update cursors component if the defaultCharWidth changes
2014-06-03 17:43:56 +09:00
Nathan Sobo
8f98f2368b
Base gutter updates on defaultCharWidth instead of fontSize/Family
2014-06-03 17:43:56 +09:00
Nathan Sobo
f467e3eed4
Move decision to measure lineHeight/charWidths to EditorComponent
...
This prevents the double-update of the lines component when changing
the font-size, line-height and font-family. We detect the update of
these values in the root component and trigger a measurement. If the
measurement determines that the pixel values have changed, *then* we
update the lines.
2014-06-03 17:43:56 +09:00
Nathan Sobo
3052fe3f3b
Update cursors when the line height in pixels changes
2014-06-03 17:43:56 +09:00
Nathan Sobo
1bce626324
Compute ranges of cursors & selections in EditorComponent and pass down
...
Previously, SelectionsComponenet::shouldComponentUpdate was storing the
ranges for selections as a side effect. We also were passing boolean
values (cursorMoved and selectionUpdated) to determine if these
components should update.
Now, we compute a simple hash of screen ranges for selections and
cursors in the root component and pass them down. This simplifies
shouldComponentUpdate for selections and allows us to implement one
for cursors.
2014-06-03 17:43:55 +09:00
Nathan Sobo
e222998f82
Only compare screenRow to mouseWheelScreen row when it is defined
...
Fixes #2482
2014-06-03 17:43:35 +09:00
Kevin Sawicki
0245ec28eb
Always handle resolving absolute URIs
2014-06-02 15:45:47 -07:00
Kevin Sawicki
94f86cb461
Don't resolve uris when project has not path
2014-06-02 15:41:05 -07:00
Kevin Sawicki
918c86476c
Check for href attribute on currentTarget
...
This makes clicking on images wrapped in anchor tags open correctly.
2014-06-02 13:35:18 -07:00
Kevin Sawicki
4d65a220e2
Add support for a ATOM_DEV_RESOURCE_PATH env var
...
This is helpful on windows to set a default dev resource path that
isn't ~/github/atom since on Windows it is common to clone Atom to C:\atom
2014-06-02 12:38:33 -07:00
Kevin Sawicki
4c2931f6b5
Use forward slash on all platforms
...
Paths are normalized by git-utils to use / on all platforms
2014-06-02 10:17:13 -07:00
Corey Johnson
3f549bbada
Merge pull request #2477 from atom/ns-react-remove-scroll-view-component
...
Merge EditorScrollViewComponent into EditorComponent
2014-06-02 08:02:49 -07:00
