Commit Graph

35358 Commits

Author SHA1 Message Date
Ash Wilson
ea91723b36 Only deal with watcher stopping in the onDidChangeFiles spec 2017-08-04 10:37:41 -04:00
Ash Wilson
ffb3b0b462 Missed the logfile reporting 2017-08-04 10:37:01 -04:00
Ash Wilson
3b57d2a259 Let's see if we're still green without diagnostics! 2017-08-03 20:29:01 -04:00
Jason Rudolph
577dfe8deb Merge pull request #15154 from atom/jr-fix-15122
Fix flaky test re: blinking cursor
2017-08-03 20:19:07 -04:00
Ash Wilson
08a7fab4f9 Grrr 2017-08-03 19:49:50 -04:00
Ash Wilson
dc9cb76fa4 tfw your diagnostic tests don't even run because of a linter error 2017-08-03 19:07:52 -04:00
Ash Wilson
7b61d4f62f Log a few more things 2017-08-03 18:21:24 -04:00
Ash Wilson
a84694fac1 Stop watchers in an afterEach block 2017-08-03 18:21:11 -04:00
Ash Wilson
095f6da379 Default to the appveyor home dir 2017-08-03 18:15:39 -04:00
Jason Rudolph
15a055b6cd Revert some of the changes from 29810c6cd1
xref: https://github.com/atom/atom/pull/15154#discussion_r131270263
2017-08-03 17:57:13 -04:00
Ash Wilson
418fe48bad Emulate a "filesystem watcher" by subscribing to Atom events 2017-08-03 15:32:40 -04:00
Ash Wilson
83f022b618 Add a fileSystemWatcher config key to use as a feature flag 2017-08-03 15:32:40 -04:00
Ash Wilson
94c91c57b1 Explicitly put the logfile in ${HOME} 2017-08-03 15:32:18 -04:00
Nathan Sobo
f8f3252962 Merge pull request #15148 from atom/ns-disable-electron-logging-by-default
Don't enable electron logging by default
2017-08-03 13:27:43 -06:00
Ash Wilson
bb91bb58e5 Okay fine let's do this the dumb way 2017-08-03 14:30:40 -04:00
Ash Wilson
263adde377 Use async cleanup to avoid ENOTEMPTY on Windows 2017-08-03 14:22:54 -04:00
Ash Wilson
654cb26819 Only run render process tests on Windows for the moment 2017-08-03 14:20:24 -04:00
Nathan Sobo
18c5a31fbc Unset ELECTRON_ENABLE_LOGGING on Windows unless explicitly requested 2017-08-03 11:53:36 -06:00
Ash Wilson
dedf5193cd Does stderr work there... ? 2017-08-03 13:11:09 -04:00
Jason Rudolph
29810c6cd1 Attempt to fix flaky test re: blinking cursor
As shown in #15122, this test sometimes fails in CI with the following
error:

  TextEditorComponent
    rendering
      it blinks cursors when the editor is focused and the cursors are not moving
        Expected '0' to be '1'.
          at it (C:\projects\atom\spec\text-editor-component-spec.js:414:49)
        Expected '0' to be '1'.
          at it (C:\projects\atom\spec\text-editor-component-spec.js:415:49)

I *think* this might be a case of overspecification in the test's
assertions. Prior to this commit, the test expected the blinking cursor
to *start* in the visible state, and then transition to the invisible
state. When we see the failure above, I suspect that the cursor has
already transitioned from the visible state to the invisible state by
the time the assertion runs.

Since the test aims to verify that the cursor blinks, it seems like we
should focus on the blinking, and not worry about the *initial* state of
the cursor. This commit removes the assertions that verify the initial
state of the cursor, and instead asserts that the cursor toggles between
the visible and the invisible state.
2017-08-03 12:25:01 -04:00
Ash Wilson
3deb26b6a0 console.log debugging 2017-08-03 11:52:15 -04:00
Ash Wilson
3e3ab73748 Use distinct names for spec directories 2017-08-03 07:48:22 -07:00
Jason Rudolph
7d6bd2a6b1 Merge pull request #15147 from atom/ns-jr-fix-gutter-decoration-dimensions
Ensure custom gutter decoration elements fill their container
2017-08-03 10:11:04 -04:00
Ash Wilson
b6a3c5c6d2 Consistently split paths in test cases 2017-08-03 08:51:44 -04:00
Ash Wilson
4cf519f2d7 Merge branch 'master' into aw-filewatcher 2017-08-03 08:37:40 -04:00
Ash Wilson
fc53b21857 Merge pull request #15124 from smashwilson/aw-spec-reporters
Use spec reporters in CI
2017-08-03 06:54:54 -04:00
Nathan Sobo
55748bd2c4 Document enable-electron-logging option 2017-08-02 21:12:02 -06:00
Nathan Sobo
b5bdf4acb9 Don't enable electron logging by default 2017-08-02 21:03:29 -06:00
Nathan Sobo
1584189962 Ensure custom decoration elements fill their container 2017-08-02 20:34:18 -06:00
Ash Wilson
e5139874d0 🔥 dumping the test environment 2017-08-02 20:08:20 -04:00
Ash Wilson
e90441303d 🔥 console.logs 2017-08-02 19:34:44 -04:00
Jason Rudolph
03b631a1da Merge pull request #15145 from atom/jr-tree-view-0-217-6
⬆️ Upgrade tree-view to 0.217.6 to fix intermittent CI failures
2017-08-02 18:30:44 -04:00
Wliu
977b337b4c ⬆️ language-php@0.41.0 2017-08-02 16:45:46 -04:00
Ash Wilson
219eabfa50 Use jasmine-reporters 1.x 2017-08-02 16:29:36 -04:00
Jason Rudolph
88c4d383fb ⬆️ Upgrade tree-view to 0.217.6 2017-08-02 15:36:02 -04:00
Ash Wilson
1e739aa891 Prepend a drive root to lookup paths on Windows 2017-08-02 14:55:12 -04:00
Ash Wilson
b9080bcec5 Don't use "path" as a variable name 2017-08-02 12:59:38 -04:00
Wliu
03742f6343 Merge pull request #15138 from alanyee/patch-1
Update README.md
2017-08-02 12:57:48 -04:00
Alan Yee
9b6eff2d81 Update README.md
Removing Homebrew install instructions
2017-08-02 09:36:22 -07:00
Ash Wilson
931b4e7055 👕 lint lint lint 2017-08-02 12:33:06 -04:00
Ash Wilson
1f56713702 Un-exclude nsfw 2017-08-02 11:50:07 -04:00
Alan Yee
d57346f23a Update README.md
Fix grammar error
2017-08-02 08:35:15 -07:00
Ash Wilson
318708bb42 wip 2017-08-02 09:50:57 -04:00
Ash Wilson
320664a359 Remove an export I missed 2017-08-02 09:04:33 -04:00
Ash Wilson
05a4f1f6fb 👕 standard.js in script/test 2017-08-02 08:29:10 -04:00
Ash Wilson
f8f6ecb5c1 Merge remote-tracking branch 'upstream/master' into aw-filewatcher 2017-08-02 08:25:39 -04:00
Ash Wilson
7244fb9670 Format script/test with standard 2017-08-02 08:18:25 -04:00
simurai
ad7e206a78 ⬆️ one-dark/light-ui@v1.10.6 2017-08-02 12:39:46 +09:00
Ash Wilson
c7a47a9e89 Use module.exports to not break Joanna horribly 2017-08-01 16:40:54 -04:00
Ash Wilson
00346614a0 Spec for onDidChangeFiles 2017-08-01 15:58:38 -04:00