Commit Graph

8194 Commits

Author SHA1 Message Date
Jason Rudolph
db960763cf Merge pull request #15947 from atom/decaf-window-event-handler-spec
️ Decaffeinate `spec/window-event-handler-spec.coffee`
2017-10-23 08:39:31 -04:00
Wliu
1975e37e31 Merge pull request #13597 from Ingramz/rework-grammar-scores
Prioritize first line matches over bundled/non bundled cirteria in grammar scoring
2017-10-20 22:30:51 +02:00
Jason Rudolph
d23510fce9 ️ Decaffeinate spec/window-event-handler-spec.coffee 2017-10-20 08:36:20 -04:00
Indrek Ardel
0f89211d55 Prioritize first line matches over bundled/non bundled cirteria 2017-10-20 13:34:15 +03:00
Jason Rudolph
4db60e34b8 👔 Fix linter error: "Arrow function should not return assignment." 2017-10-18 20:13:55 -04:00
Jason Rudolph
49655a97c8 🎨 2017-10-18 20:10:24 -04:00
Jason Rudolph
6e78281a73 🎨 Prefer fat arrow function syntax 2017-10-18 19:54:51 -04:00
Jason Rudolph
498d7c90eb Rewrite code to no longer use __guard__ 2017-10-18 19:54:51 -04:00
Jason Rudolph
db115d3ab8 Remove unnecessary code created because of implicit returns 2017-10-18 19:54:51 -04:00
Jason Rudolph
61b228d8a0 Remove unnecessary use of Array.from 2017-10-18 19:54:51 -04:00
Jason Rudolph
c632e6ca58 Decaffeinate spec/project-spec.coffee
Apply results of running:

```
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes spec/project-spec.js

$ standard --fix spec/project-spec.js
```
2017-10-18 19:54:51 -04:00
Antonio Scandurra
280253fdfa Merge pull request #15916 from atom/as-jr-stop-dragging-when-interacting-with-keyboard
Stop dragging only when user interacts with keyboard
2017-10-18 11:38:52 +02:00
Michelle Tilley
5e43084cd3 url -> URI 2017-10-17 15:23:10 -07:00
Michelle Tilley
5e96429c9e Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch 2017-10-17 11:18:02 -07:00
Antonio Scandurra
65af9e953b Stop dragging only when user interacts with keyboard
Previously, we used to prevent the user from dragging the selection
further when the buffer was about to change. This was problematic
because any change in the buffer, even one that was performed
"automatically" by a package, would cancel the dragging action and
result in a confusing experience for the user.

On the other hand, we want to prevent users from accidentally selecting
text when they perform an edit (see #15217, #15405).

This commit addresses both concerns by canceling the dragging as soon as
the user interacts with the keyboard, instead of canceling the dragging
when the buffer is about to change.

One downside of this approach is that it changes the behavior of
pressing a keystroke that does not result in a buffer change, e.g.
Shift, Arrow Keys, etc.

Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
2017-10-17 18:50:20 +02:00
Antonio Scandurra
7853e3cd8c Don't throw when destroying block decorations inside marker change event 2017-10-11 09:42:53 +02:00
Jason Rudolph
7463925e94 Merge pull request #15834 from atom/jr-decaf-gutter-container
Decaffeinate `GutterContainer`
2017-10-07 15:12:38 -04:00
Jason Rudolph
f79708a74a Merge pull request #15823 from atom/jr-decaf-gutter
Decaffeinate `Gutter`
2017-10-06 09:35:11 -04:00
Jason Rudolph
d546037863 Decaffeinate spec/gutter-container-spec.coffee 2017-10-06 09:33:43 -04:00
Antonio Scandurra
d83304cbdd Exercise more features in the randomized test
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-10-05 19:41:28 +02:00
Jason Rudolph
51df9a308a Decaffeinate spec/gutter-spec.coffee 2017-10-05 11:06:42 -04:00
Antonio Scandurra
ec14125ecb 🎨 2017-10-05 13:51:26 +02:00
Antonio Scandurra
ae57cd268e Delete unnecessary test code 2017-10-05 13:51:26 +02:00
Antonio Scandurra
1ca49d8f17 Move random-seed into script/package.json
...so that it doesn't get included in the final application bundle.
2017-10-05 13:51:26 +02:00
Antonio Scandurra
6e3b8cb9f8 Introduce randomized test for TextEditorComponent 2017-10-05 13:05:52 +02:00
Michelle Tilley
eb4357ce87 Add tests for packages with URI handlers 2017-10-03 13:20:48 -07:00
Michelle Tilley
4b67353f85 Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch 2017-10-03 13:16:02 -07:00
Max Brunsfeld
c46140946e Merge pull request #15798 from atom/mb-prompt-to-save-in-conflict
Prompt to save when unloading if editor is in conflict
2017-10-03 12:36:43 -07:00
Nathan Sobo
f317a458ea Merge pull request #15800 from atom/ns-fix-soft-wrap-rendering-bug
Fix rendering bug when folds cause the vertical scrollbar to disappear with soft wrapping enabled
2017-10-03 13:22:15 -06:00
Max Brunsfeld
4d057a16d6 Prompt to save when unloading if editor is in conflict 2017-10-03 11:09:33 -07:00
Max Brunsfeld
44d6868855 Preserve indentation when toggling comments on whitespace-only lines 2017-10-03 10:14:45 -07:00
Nathan Sobo
293b52d797 Fix rendering bug when folds hide the vertical scrollbar w/ soft wrap on 2017-10-03 11:09:44 -06:00
Max Brunsfeld
a778d5e09c 🎨 2017-09-28 17:09:55 -07:00
Max Brunsfeld
1d0dfe2213 Use async/await in package-manager-spec 2017-09-28 17:04:46 -07:00
Max Brunsfeld
a7db6ce7b1 Convert package-manager-spec to JS 2017-09-28 16:25:34 -07:00
Max Brunsfeld
969cb7a0f5 Merge pull request #15692 from UziTech/pane-onDidChangePath
Pane on did change path
2017-09-28 11:51:12 -07:00
Max Brunsfeld
6a86a1c7bf Wait for repo to refresh in test 2017-09-27 14:19:05 -07:00
Michelle Tilley
67df9d5eff Add history to UrlHandlerRegistry 2017-09-27 13:00:42 -07:00
Michelle Tilley
ce85537674 Fix spec 2017-09-27 12:41:03 -07:00
Max Brunsfeld
c12a5b23b4 Convert git-repository-provider-spec to JS 2017-09-27 12:18:17 -07:00
Max Brunsfeld
345e236d86 Fix toggleLineCommentsForBufferRows 2017-09-25 09:52:15 -07:00
Max Brunsfeld
090b753d84 Move toggleLineCommentsForBufferRows to TokenizedBuffer 2017-09-24 10:34:34 -07:00
Max Brunsfeld
cd1a265dd3 Move .suggestedIndentForBufferRow tests to tokenized-buffer-spec 2017-09-24 09:54:06 -07:00
Max Brunsfeld
274a699272 Remove unused method TokenizedBuffer.indentLevelForRow 2017-09-22 16:20:10 -07:00
Max Brunsfeld
62e94f7b96 Rename language-mode-spec.js to text-editor-spec.js
This gets the ball rolling toward converting the text editor specs to JS
2017-09-22 14:40:34 -07:00
Max Brunsfeld
0884546d3c Move everything but auto-indent out of LanguageMode 2017-09-22 14:33:02 -07:00
Max Brunsfeld
6c1356cae3 Move folding logic from LanguageMode to TokenizedBuffer
* Restate the folding logic to not *use* the TextEditor, but instead to
*return* ranges which can be folded by the editor.
* Convert the LanguageMode spec to JS
2017-09-22 12:04:51 -07:00
Max Brunsfeld
b1a3460ad9 Fix scope name in TokenizedBuffer test 2017-09-21 15:52:07 -07:00
Michelle Tilley
eecd524788 Differenter 2017-09-21 14:57:33 -07:00
Michelle Tilley
c52d517d13 Limit argument parsing when --url-handler is set 2017-09-21 14:50:41 -07:00