Nathan Sobo
7387c553c3
Start introducing Cursor model in EditSession
...
The old cursor view still does most of the work, but to add a new cursor view we now must add a cursor model to the edit session at the correct position. The editor watches the 'add-cursor' event on edit session and add a corresponding CursorView to the CompositeCursor whenever a model is added. Next step: have the cursor view observe the cursor model and shadow its changes in position.
2012-06-06 21:52:19 -06:00
Nathan Sobo
ff52993c9e
Fix bugs when switching between EditSessions
2012-06-06 17:00:02 -06:00
Nathan Sobo
1344d42061
Add spec to ensure we unsubscribe from every buffer when we remove editor
2012-06-06 12:48:45 -06:00
Nathan Sobo
e6af7a9515
Adjust the width of rendered lines to account for the longest line
2012-06-05 14:26:06 -06:00
Nathan Sobo
e433d106b8
Remove unnecessary construction of new editor
2012-06-05 14:25:32 -06:00
Nathan Sobo
3a776347ff
Avoid leaking window resize subscriptions in editor spec
2012-06-05 14:25:08 -06:00
Nathan Sobo
e7ffaa1757
Merge branch 'master' of github.com:github/atom
2012-06-05 12:48:16 -06:00
Nathan Sobo
911a417cb8
Rename maxLineLength to softWrapColumn
2012-06-05 12:47:39 -06:00
Corey Johnson
4f364e8cd8
Add newline-below event
2012-06-05 11:30:29 -07:00
Nathan Sobo
4dc41dcc21
💄
2012-06-05 11:09:40 -06:00
Nathan Sobo
c24b8a90b2
If lines are removed after a renderer change, update padding appropriately
2012-06-05 10:59:11 -06:00
Nathan Sobo
9cfbce826d
WIP: Don't allow impossibly high scroll top values.
...
It fixes the move to bottom issues, but breaks some other tests. Not sure why yet...
2012-06-04 21:57:10 -06:00
Nathan Sobo
3c2facc7be
Add a disabled failing spec for text rendering when moving to the end of the file
2012-06-04 21:11:32 -06:00
Nathan Sobo
de1086639d
Add failing spec for folding more than a screen of text to less than a screen
2012-06-04 20:45:28 -06:00
Nathan Sobo
c3a157a544
Revert "Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines."
...
This reverts commit 419d7b1dec
2012-06-04 20:29:40 -06:00
Corey Johnson
0cfb2e9ef4
Rename Editor.visibleLines to Editor.renderedLines
2012-06-04 17:53:58 -07:00
Corey Johnson
419d7b1dec
Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines.
...
Fix specs that had wrong assumptions,
2012-06-04 17:48:11 -07:00
Nathan Sobo
ded6281e0f
Merge branch 'master' into toggle-comments
2012-06-04 12:07:54 -06:00
Nathan Sobo
d2a1da7ba6
Window spec no longer nukes the jasmine stylesheet
2012-06-04 12:07:37 -06:00
Nathan Sobo
a033d13c1a
Merge branch 'master' of github.com:github/atom into toggle-comments
2012-06-04 11:55:15 -06:00
Nathan Sobo
b667ba4262
If selection is empty when toggling a line comment, keep it empty
2012-06-04 11:50:48 -06:00
Corey Johnson
2f6dd085ee
Editor toggle-fold event toggles the largest fold at the cursor position
2012-06-04 09:44:20 -07:00
Corey Johnson & Nathan Sobo
fd152ef2a9
When a fold is created inside an existing fold, don't trigger change events or update line map.
2012-06-02 09:21:06 -07:00
Corey Johnson & Nathan Sobo
2f435e08f3
Add regression test for "can't create multiple folds over same region".
...
Am I using the term regression test correctly?
2012-06-02 08:56:02 -07:00
Nathan Sobo
14e399fdf0
Meta-/ comments out selected lines
2012-06-01 19:38:33 -06:00
Corey Johnson
ca4371d9ce
The solution to all build problems
2012-06-01 15:35:38 -07:00
Nathan Sobo
2c35a1f12d
LineCommenter.proto.toggleLineCommentsInRange comments / uncomments lines in a selection
2012-06-01 14:28:40 -06:00
Nathan Sobo
d8b324e14f
WIP: Starting on toggling comments.
2012-06-01 14:03:48 -06:00
Nathan Sobo
58c082445b
Merge branch 'master' of github.com:github/atom
2012-06-01 14:01:44 -06:00
Nathan Sobo
74bd510e75
💄 rename ScreenLineFragment to ScreenLine
...
These objects always span an entire screen line now that we do line-wise folding
2012-06-01 14:01:33 -06:00
Corey Johnson
30d07fd1a0
Rename Buffer.numLines to Buffer.getLineCount
2012-06-01 11:25:58 -07:00
Nathan Sobo
37d423fb60
Fix broken build :-/
2012-06-01 12:22:54 -06:00
Nathan Sobo
5b20bfd994
Method name 💄 for Highlighter
2012-06-01 12:15:26 -06:00
Corey Johnson
5a0eb5814d
We are using scrollTop instead of -wekbit-transform, update specs to reflect this.
2012-06-01 11:06:14 -07:00
Corey Johnson
6952e09646
Moved font-size back to 'px' and fixed specs
2012-06-01 11:06:13 -07:00
Corey Johnson
2623724fd4
Add fold-all event to editor
2012-06-01 11:06:13 -07:00
Nathan Sobo
9cb067f162
Enable auto-indent for 1 more spec + 💄
2012-05-31 18:22:54 -06:00
Nathan Sobo
502208dcf4
Enable auto-indent for spec
2012-05-31 18:17:39 -06:00
Nathan Sobo
9f5a7ceefe
Merge branch 'master' into structural-folding
2012-05-31 18:05:13 -06:00
Nathan Sobo
645f57bb40
Merge branch 'master' of github.com:github/atom
2012-05-31 17:49:31 -06:00
Nathan Sobo
acb01bba37
Correctly render lines when destroying a fold forces an autoscroll
2012-05-31 17:48:50 -06:00
Corey Johnson
4f5a03ee4d
Merge branch 'master' into structural-folding
2012-05-31 16:24:01 -07:00
Corey Johnson
1a9566d954
Merge branch 'master' into binding-viewer
2012-05-31 15:55:23 -07:00
Corey Johnson
b03230cc6c
Move auto indent/outdent to selection spec
2012-05-31 13:57:04 -07:00
Corey Johnson
516de1ede1
Merge branch 'master' into structural-folding
2012-05-31 11:46:23 -07:00
Corey Johnson
2df7c26353
Folding works with coffeescript
2012-05-31 11:30:06 -07:00
Nathan Sobo
fdb8ba8a2b
Remove redundant gutter spec. Corey's is in a better spot.
2012-05-31 12:13:36 -06:00
Nathan Sobo
06fffe6c4b
Merge branch 'master' of github.com:github/atom
...
Conflicts:
src/app/editor.coffee
2012-05-31 12:11:07 -06:00
Nathan Sobo
c901417a19
When lines are added, remove any that get pushed down to exceed the max allowed row
...
This fixes issues where unfolding or pasting caused rendering artifacts below the last visible row.
2012-05-31 12:06:00 -06:00
Corey Johnson
17c0526bc3
Add test for gutter rendering of fold lines
2012-05-31 10:26:34 -07:00
