Antonio Scandurra
e10fdc234b
🐛 Coordinate conversion is hard
2015-12-02 16:26:10 +01:00
Antonio Scandurra
5bcdcbeef6
🎨
2015-12-02 16:13:44 +01:00
Antonio Scandurra
f30e4ccc9d
Use the new LineTopIndex in TextEditorPresenter
2015-12-02 16:01:55 +01:00
Antonio Scandurra
1e07b8df05
Handle position between rows correctly
2015-12-02 09:13:06 +01:00
Antonio Scandurra
e0b1cabb21
Implement a linear structure for block decoration coordinates
...
We still cannot handle `::rowForTopPixelPosition` when the passed top position
is in the middle of two rows and there's also a block decoration. We'll get
there eventually.
Also, the specs in this commit should serve as a good test suite for the future
logarithmic data structure.
2015-12-01 19:33:37 +01:00
Antonio Scandurra
d24290357a
Implement block decorations in the components land
2015-12-01 13:36:23 +01:00
Antonio Scandurra
47b16c513c
Make sure cursors are updated with respect to block decorations
2015-12-01 09:48:11 +01:00
Antonio Scandurra
526a97562e
Include block decorations as a separate object on presenter's state
2015-11-30 15:05:15 +01:00
Antonio Scandurra
8a54a2c15b
Use a boolean in each line state object
2015-11-30 14:44:58 +01:00
Antonio Scandurra
539a5b0ae7
🐎 Do as little pixel conversion as possible
...
We desperately need a tree-based data structure. 😢
2015-11-30 14:34:16 +01:00
Antonio Scandurra
b998e7f2d9
🐎 Incremental updates for block decorations
2015-11-30 14:03:45 +01:00
Antonio Scandurra
0159d5c31e
🎨
2015-11-27 16:58:08 +01:00
Antonio Scandurra
6ad21307cc
Provide blockDecorationsHeight for each line number
2015-11-27 16:27:01 +01:00
Antonio Scandurra
6365c86992
Include blockDecorations inside each line's state
2015-11-27 14:32:01 +01:00
Antonio Scandurra
e1e06580c1
Move position conversion in LinesYardstick
2015-11-27 12:47:47 +01:00
Antonio Scandurra
0b5638f749
Make sure tile positions are computed correctly
2015-11-27 10:47:25 +01:00
Antonio Scandurra
a9cb1bda8d
Use ::positionForRow in ::updateTilesState
...
The algorithm is still super sloooow 🐌 , but we'll fix that in a later
commit.
2015-11-27 10:16:38 +01:00
Antonio Scandurra
02651b7a58
🎨 Rename to ::setBlockDecorationDimensions
2015-11-26 16:10:08 +01:00
Antonio Scandurra
96863eef1c
Ensure content scrollHeight takes block decorations into account
...
Seems like all these properties in the presenter's state share a common
contract, which we should probably extract. It could also mean there's an
underlying design problem, because we are testing two dimensions of the same
behavior in a single spec.
2015-11-26 15:44:59 +01:00
Antonio Scandurra
30da4bdb0c
Ensure gutter scroll height takes block decorations into account
2015-11-26 15:43:34 +01:00
Antonio Scandurra
89d9a2ce83
🎨 Create block decorations in TextEditor
...
This is just an experiment, although I like that we can hide some information
(irrelevant to the user) behind a clean API.
2015-11-26 15:40:08 +01:00
Antonio Scandurra
c8254566ef
Change verticalScrollbar's height according to block decorations
2015-11-26 15:34:45 +01:00
Nathan Sobo
8978691831
Merge pull request #9773 from atom/mb-ns-prepare-stack-trace-fixes
...
Allow Error.prepareStackTrace to be temporarily reassigned
2015-11-24 11:59:53 -07:00
Antonio Scandurra
c061b27076
✅
2015-11-24 17:36:44 +01:00
Antonio Scandurra
9376738918
Make spec async because of Promise-based API
2015-11-24 12:28:31 +01:00
Max Brunsfeld
4bc46db355
Still assign error's raw stack when prepareStackTrace is overridden
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 15:30:11 -08:00
Max Brunsfeld
4616b426b0
Allow Error.prepareStackTrace to be temporarily reassigned
...
Fixes https://github.com/atom/atom/issues/9660
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 15:22:15 -08:00
Max Brunsfeld
30b3cb249e
Merge pull request #9636 from DouweM/unique-title
...
Use unique text editor title in window and tab titles
2015-11-20 16:55:38 -08:00
Nathan Sobo
3e22d9f7a2
Merge PR #9607 with a small change
2015-11-20 10:41:22 -07:00
Nathan Sobo
704da43800
Prevent spec from closing window
2015-11-20 10:34:05 -07:00
Antonio Scandurra
a546005c65
Merge pull request #9709 from atom/as-fix-longest-screen-row-issue
...
Compute content width when the longest row is the first one
2015-11-20 09:24:33 -08:00
Antonio Scandurra
93481c8a0d
Move ::isTextEditor down into Workspace
2015-11-19 17:56:53 -08:00
Antonio Scandurra
85ee586e2e
✅ More specs
2015-11-19 17:30:33 -08:00
Antonio Scandurra
d427091b49
✅ Write specs for ::isTextEditor
2015-11-19 17:04:18 -08:00
Antonio Scandurra
0218431c62
🐛 Compute content width when the longest row is the first one
2015-11-19 16:38:20 -08:00
Antonio Scandurra
ff08642d3b
Return early in FakeLinesYardstick for unrendered rows
...
This allows us to have a more consistent behavior with the real LinesYardstick.
2015-11-19 16:32:39 -08:00
Nathan Sobo
b04c26ba30
Discard highlights that end above the visible row range
...
Fixes #9628
2015-11-18 21:32:05 -08:00
Douwe Maan
5c701ed5df
Use long title in tests
2015-11-18 20:31:42 +01:00
Nathan Sobo
9537007a2a
Merge branch 'beta'
2015-11-17 16:57:33 -08:00
Nathan Sobo
e475065b45
Merge branch 'stable' into beta
2015-11-17 16:57:19 -08:00
Nathan Sobo
3b2c6afdaf
Fix removeListener calls
2015-11-17 16:23:38 -08:00
Douwe Maan
a9bf2a73a5
Improve TextEditor::getLongTitle
2015-11-17 23:34:31 +01:00
Nathan Sobo
8da44c4dfc
Discard highlights that end above the visible row range
...
Fixes #9628
2015-11-17 11:45:51 -08:00
Wliu
3a34a95947
✅ Update TokenizedBuffer specs
2015-11-17 12:47:14 -05:00
Nathan Sobo
6862610e70
Merge branch 'beta'
2015-11-17 08:53:27 -08:00
Nathan Sobo
192e804c8f
Fix specs. Duh.
2015-11-17 08:53:13 -08:00
Douwe Maan
f93565708b
Close empty active window when Close command is given
2015-11-16 17:54:06 +01:00
Nathan Sobo
fa66048d71
Guard against focusing a destroyed pane
2015-11-12 17:34:48 -07:00
Nathan Sobo
df0671cf5f
Merge pull request #9513 from Ingramz/grammar-scores
...
Prioritize file type matching over first line matching in grammar scoring system
2015-11-12 16:12:26 -07:00
Nathan Sobo
67c42282a6
Merge pull request #9527 from atom/lierdakil-defer-act-hooks
...
Lierdakil: Defer Activation Hooks
2015-11-12 16:06:41 -07:00
