Antonio Scandurra
e236b8c3be
Avoid storing properties in selection markers
...
Previously we were storing a {type: ‘selection’} property, probably
leftover from the “pre-marker-layer” world. We were also storing
`Selection`’s `goalScreenRange` on the marker, which is now just an
instance variable.
2016-04-06 20:00:08 +02:00
Antonio Scandurra
c2396396a5
📝 Update documentation for mark*Position
2016-04-06 19:20:05 +02:00
Antonio Scandurra
4f28f9f3f8
🔥 Remove defensive assertion
...
We're not throwing this exception anywhere else, so we might as well delete it
from here.
/cc: @nathansobo
2016-04-06 15:48:44 +02:00
Antonio Scandurra
ffd3b1829d
Provide deprecation warnings for clipScreenPosition parameters
...
Based on a cursory search, there’s only one package using that API. Even though
we could submit a PR, we’re introducing deprecations to ensure we're not missing
any other package.
2016-04-06 15:42:53 +02:00
Antonio Scandurra
25b71b804d
Un-document passing clip options to setCursorBufferPosition
...
…the marker’s screen position will be clipped automatically when
translating coordinates.
2016-04-06 14:44:26 +02:00
Antonio Scandurra
00f03fd614
📝 Document {clipDirection: 'closest'}
2016-04-06 14:21:06 +02:00
Nathan Sobo
af28fa0752
When copying, create selections marker layer on the *new* display layer
...
Previously, we were copying the selections marker layer into the current
editor’s display layer. This would work fine until the spatial mapping
drifted in the copied editor, and would then have counterintuitive
results.
2016-04-05 18:47:11 -06:00
Nathan Sobo
b922262871
Avoid internal deprecation warning on getHeight
2016-04-05 17:18:24 -06:00
Nathan Sobo
a790ae2158
Avoid deprecation warnings for methods that are now on TextEditor
2016-04-05 12:12:14 -06:00
Nathan Sobo
117a3fb1b5
Provide deprecated TextEditor.prototype.displayBuffer shim
...
Even though it was a private field, we used it in some of our packages
and it is widespread enough to warrant some effort to smooth the
transition.
Also, we added a couple methods that were formerly implemented on
DisplayBuffer to TextEditor itself because they were used in packages.
2016-04-05 12:11:55 -06:00
Antonio Scandurra
ebd9e71b0b
Make serialization format backwards/forwards compatible
...
Also, introduce a serialization version so we can drop the compatibility
fallbacks in the future.
2016-04-05 11:27:15 -06:00
Antonio Scandurra
bef7539e34
Refactor DisplayBuffer to DecorationManager
...
This commit moves all the remaining concerns not related to decorations
out of `DisplayBuffer` and into `TextEditor`. This means the
`DisplayBuffer` is now free to be renamed to `DecorationManager`.
2016-04-05 18:43:08 +02:00
Nathan Sobo
bbef4c67c3
Get the TextEditorComponent specs green
2016-04-04 11:21:41 -06:00
Antonio Scandurra
fd960e9a37
Merge branch 'master' into ns-use-display-layers
2016-04-04 15:25:50 +02:00
Machisté N. Quintana
3068631d19
Don't open a transaction if there's a selection at the start / end of line
2016-03-30 12:48:11 -07:00
Machiste Quintana
3b222dbee8
Don't merge selections if at start or end of line
2016-03-28 23:26:28 -07:00
Machiste Quintana
e932e3db05
Merge branch 'master' into mq-move-selected-columns
2016-03-28 22:16:31 -07:00
Antonio Scandurra
f9fb93f214
🎨
2016-03-25 16:37:01 +01:00
Antonio Scandurra
e6cb5c8e89
🐛 Guard against unexisting screen rows
2016-03-24 15:57:24 +01:00
Antonio Scandurra
21831a4e43
🐛 Fix inaccurate logic in moveLineDown
...
Instead of deleting and then inserting, it’s better to do the opposite
so that we don’t have to translate points at all.
2016-03-23 16:16:51 +01:00
Antonio Scandurra
326f2c6a9e
Add TextEditor.prototype.tokensForScreenRow for testing purposes
2016-03-22 14:49:42 +01:00
Antonio Scandurra
b1e07c0cfe
Use the new lineText property
2016-03-22 14:36:28 +01:00
Antonio Scandurra
4e23748660
Fix moveLineUp and moveLineDown to work with free-form folds
2016-03-22 14:02:13 +01:00
Antonio Scandurra
227670a407
Merge branch 'master' into ns-use-display-layers
2016-03-22 12:01:07 +01:00
Antonio Scandurra
3c70ff92f4
💚 Add TextEditor.prototype.screenLineForScreenRow
...
This is going to supplant our internal usage of
TextEditor.prototype.tokenizedLineForScreenRow().
2016-03-18 14:26:29 +01:00
Antonio Scandurra
d1306ae944
Remove invisibles handling from TokenizedBuffer
2016-03-18 14:09:52 +01:00
Antonio Scandurra
5fc699f791
Use intersecting folds when duplicating lines
2016-03-18 11:44:23 +01:00
Antonio Scandurra
d86309e46b
Use DisplayLayer.prototype.foldBufferRange in Selection.prototype.fold
2016-03-18 11:33:29 +01:00
Antonio Scandurra
83da3ca440
Fix moveLineUp and moveLineDown
2016-03-18 11:24:22 +01:00
Antonio Scandurra
1d1bdf5872
Improve folds behavior when duplicating lines
...
Now we will select the entire screen line (which could contain some
free-form fold), and we duplicate its contents preserving the structure
of the existing folds.
2016-03-18 11:04:30 +01:00
Antonio Scandurra
5efb969a63
💚 Start fixing TextEditorComponent specs
2016-03-17 11:33:17 +01:00
Nathan Sobo
2ad2f161fa
Merge pull request #11078 from wvanlint/opt_in_registration
...
Add TextEditors to the registry only when opting in
2016-03-11 15:37:07 -07:00
Willem Van Lint
466e554ee1
Add TextEditors to the registry on opt-in only
2016-03-10 22:51:51 -08:00
Antonio Scandurra
dfed7c4537
Merge branch 'master' into ns-use-display-layers
...
# Conflicts:
# package.json
# src/display-buffer.coffee
# src/text-editor.coffee
# src/tokenized-buffer.coffee
2016-03-10 13:53:14 +01:00
Rodrigo Espinosa Curbelo
42a696cf28
🐛 Scroll to cursor when unfold all
...
Fixes #11066
2016-03-05 21:28:09 -03:00
joshaber
dba1fbd408
De-lint.
2016-03-03 10:15:13 -05:00
joshaber
928205a44a
s/grammarName/grammar
2016-03-03 10:09:18 -05:00
joshaber
98c8a08ac3
s/ignoreScrollPastEnd/scrollPastEnd
2016-03-03 10:06:15 -05:00
joshaber
db20cecfc0
s/ignoreInvisibles/showInvisibles
2016-03-03 09:59:45 -05:00
joshaber
367f6db7a4
Merge branch 'master' into atom-textarea
2016-02-29 23:02:52 -05:00
Nathan Sobo
04d2474594
Merge PR #9642 (Autoscroll after consolidating selections)
2016-02-29 18:38:33 -07:00
Willem Van Lint
26cf7f081f
Registry for editors
2016-02-29 17:30:04 -05:00
joshaber
707bdf3f39
Merge branch 'master' into atom-textarea
2016-02-29 16:41:01 -05:00
Michelle Tilley
b9d40be902
Merge pull request #10959 from atom/ku-move-pending-state-from-item-to-pane
...
(WIP) Refactor pending state to live in pane instead of items
2016-02-26 14:19:23 -08:00
Katrina Uychaco
7643fa04ed
Small 🐎 when editing a TextEditor that is no longer pending
2016-02-25 17:32:17 -08:00
Katrina Uychaco
1c65d0e5e4
Changed Pane and TextEditor specs to match new pending behavior
2016-02-25 16:48:16 -08:00
Katrina Uychaco
b637366a58
Workspace#setItemNotPending ➡️ Item#onDidTerminatePendingState
...
Signed-off-by: Michelle Tilley <binarymuse@github.com >
2016-02-25 16:09:40 -08:00
joshaber
dfd3e1b948
Take autoHeight as an argument.
2016-02-25 17:11:04 -05:00
joshaber
ff0b9e30a9
Add ignoreScrollPastEnd
2016-02-25 16:59:58 -05:00
joshaber
1b6325494d
Merge branch 'master' into atom-textarea
2016-02-25 16:05:59 -05:00
