Kevin Sawicki
02c47ba1ea
💄
2014-07-28 16:49:08 -07:00
Kevin Sawicki
f6cb59be47
Merge pull request #3062 from ehuss/win32-sourcemaps
...
Fix source maps for CoffeeScript on Windows.
2014-07-28 16:44:06 -07:00
Kevin Sawicki
431555195a
Merge branch 'master' into chrome35
...
Conflicts:
package.json
2014-07-28 14:40:14 -07:00
Nathan Sobo
7f882b00f5
Don't allow updates to be requested for unmounted components
...
In 444c18be34 , I stopped polling the DOM
when an update was pending to prevent delay of the next animation frame.
Unfortunately, we rely on synchronously polling the DOM when an editor
view is attached to perform the initial measurement of the default char
width, which is required to position the wrap guide.
In componentWillMount, observing the config was requesting an update,
causing us to skip this synchronous update at attachment time and
position the wrap guide wrong.
This prevents update requests that occur before mount from pausing the
polling that we perform on attachment, restoring correct function to the
wrap guide.
2014-07-28 14:42:35 -06:00
Nathan Sobo
3a9aa80914
Add ReactEditorView::lineElementForScreenRow shim
2014-07-28 11:36:40 -06:00
Kevin Sawicki
7e415ffdb7
Merge branch 'master' into chrome35
...
Conflicts:
package.json
2014-07-28 09:02:38 -07:00
Nathan Sobo
393552a4b6
Take cursors off the GPU and position them on the lines layer
...
The compositor overhead is not worth it.
2014-07-27 11:47:33 -06:00
Nathan Sobo
444c18be34
Stop polling when an update is pending
2014-07-27 11:46:22 -06:00
Nathan Sobo
dca096b8e3
Use requestAnimationFrame to batch updates in Chrome 35
...
In Chrome 31, setImmediate was yielding better behavior. But now Chrome
35 seems to behave more smoothly when we use requestAnimationFrame, and
the delay for keystrokes is non-existent.
2014-07-27 11:46:22 -06:00
Nathan Sobo
57a03e7884
Kill dummy highlight component now that Chrome 35 fixes render artifact
...
Previously, removing the last highlight caused rendering artifacts.
Chrome 35 no longer exhibits this problem so we can remove this
workaround.
2014-07-27 11:46:22 -06:00
Marc Bachmann
9ae007a6d7
Remove duplicate addUrlToOpen() in browser/main.coffee
...
I don't think that this was the desired behaviour.
I do not know if that caused a bug.
2014-07-26 10:54:15 +02:00
Kevin Sawicki
9dc59b9807
💄
2014-07-25 17:12:03 -07:00
Kevin Sawicki
15689ebfb5
📝
2014-07-25 17:11:33 -07:00
Kevin Sawicki
6250419fcb
containsNativeModule -> isNativeModule
2014-07-25 17:09:46 -07:00
Kevin Sawicki
70621afe62
📝
2014-07-25 17:08:10 -07:00
Kevin Sawicki
7b07d7116b
Store string in local storage
2014-07-25 16:06:35 -07:00
Kevin Sawicki
f175086865
Always return boolean from Package::isCompatible
2014-07-25 15:56:09 -07:00
Kevin Sawicki
c6071a9802
Don't throw incompatible error, log instead
2014-07-25 15:49:34 -07:00
Kevin Sawicki
ac138c1dc8
Throw error when activating incompatible package
2014-07-25 15:46:35 -07:00
Kevin Sawicki
85b7261d31
Don't store incompatible packages in custom object
...
The info is on the Package object itself to the loaded/activated
packages can just be iterated over.
2014-07-25 15:36:09 -07:00
Kevin Sawicki
d47348e8f9
Cache incompatible modules in local storage
2014-07-25 15:34:03 -07:00
Kevin Sawicki
1ea909d4db
Check installed packages for working native modules
...
Test require each native module in each installed package to make sure
it can be required successfully in Atom.
2014-07-25 15:19:16 -07:00
Ben Ogle
c748fc49bb
Fix split-selection-into-lines
...
Don’t create cursor on last row when selection on row is empty
Fixes #1704
Closes #3080
2014-07-25 11:29:40 -07:00
Nathan Sobo
a3d82e9414
Merge branch 'master' into chrome35
...
Conflicts:
package.json
2014-07-24 18:14:11 -07:00
Nathan Sobo
37165f3293
Invoke pollDOM after attach so character width is calculated
...
Now that we mount the react component in the constructor of the wrapper
view, it's never actually visible at the time of mount. By invoking
pollDOM manually after attaching and before emitting the attach event,
the character width is available for the wrap guide to calculate its
initial position.
2014-07-24 18:12:02 -07:00
Nathan Sobo
7515fd94ba
Merge branch 'master' into chrome35
...
Conflicts:
package.json
2014-07-24 17:40:37 -07:00
Nathan Sobo
85363f8eaa
Resample background colors whenever stylesheets change
...
This prevents a flicker that occurred on theme changes when we just
detected this via polling. I'm going to leave the polling as a catch-all
in case the editor is styled inline in some way.
2014-07-24 17:25:04 -07:00
Nathan Sobo
7738eeeacc
Give the line-numbers div an opaque background for better GPU perf
...
We sample both the background color of the editor and the gutter. If the
gutter has an actual background color, we use it. Otherwise we fall back
to the same background as the editor.
2014-07-24 17:23:04 -07:00
Nathan Sobo
c6116468e4
Apply background color of root editor node to lines as an inline style
...
This ensures lines have an opaque background that matches whatever the
editor is styled as, but avoids the need to apply the .editor-colors
class to the .lines div. That approach fell down when people were
setting the background color via means other than .editor-colors, such
as styling mini editors via the .editor.mini selector in the settings
view.
2014-07-24 16:54:01 -07:00
Kevin Sawicki
8ad8be2583
Merge branch 'master' into chrome35
2014-07-24 14:53:24 -07:00
Kevin Sawicki
b922f01257
Merge branch 'master' into chrome35
...
Conflicts:
package.json
2014-07-24 14:17:17 -07:00
Nathan Sobo
c8aea97f16
Use ReactEditorView in SelectListView when flag is enabled
2014-07-24 12:57:12 -07:00
Nathan Sobo
c9587a8638
Mount EditorComponent as soon as ReactEditorView is constructed
...
...instead of waiting for it to be attached. This makes it simpler to
get shim references when using ReactEditorView for mini editors.
2014-07-24 12:57:12 -07:00
Nathan Sobo
d3a46b6bc9
Don't try to update lines/line numbers until after initial measurement
...
Fixes #3047
2014-07-24 10:27:38 -07:00
Cheng Zhao
dcbf730129
Merge branch 'master' into chrome35
...
Conflicts:
apm/package.json
package.json
2014-07-24 17:17:35 +08:00
Cheng Zhao
39868a2330
Make atom.setSize synchronous.
2014-07-24 16:29:20 +08:00
Eric Huss
772726ca96
Fix source maps for CoffeeScript on Windows.
...
The sourceURL needs to be a URL, not a file path.
2014-07-23 16:49:53 -07:00
Ben Ogle
00275d95ec
Merge pull request #3044 from atom/bo-h-scrollbar
...
Horizontal scrollbar no longer covers the gutter
2014-07-23 16:35:02 -07:00
Ben Ogle
2a9c78ef92
Move horiz scrollbar into the scrollView
...
Also remove all the gutter width calculation. It was flawed anyway,
2014-07-23 16:20:48 -07:00
Kevin Sawicki
29970acaa9
📝 Document second argument of callback
2014-07-23 10:29:46 -07:00
Ben Ogle
ffb041a160
Only render an nbsp on empty lines when no eol character defined
...
Fixes #3053
2014-07-23 09:30:52 -07:00
Ben Ogle
48a5123202
💄 Move logic into measureGutterIfNeeded
2014-07-22 18:26:58 -07:00
Ben Ogle
0f1d155685
Move gutterWidth into state; add specs for scrollbar position
2014-07-22 18:26:58 -07:00
Ben Ogle
d3a6e79428
The horizontal scrollbar takes gutter width into account
2014-07-22 18:26:58 -07:00
Kevin Sawicki
5f7f5b5367
Merge branch 'master' into chrome35
2014-07-22 17:56:24 -07:00
Kevin Sawicki
8099c46c8e
Use OnigRegExp::testSync
2014-07-22 14:38:08 -07:00
probablycorey
911ca0d846
Remove Atom.isReleasedVersion
2014-07-22 14:10:29 -07:00
probablycorey
88d1ba2271
Remove Atom.getVersion()
2014-07-22 14:10:29 -07:00
Kevin Sawicki
bbfd9b8178
Use testSync instead of test
2014-07-22 14:08:40 -07:00
Kevin Sawicki
6d34de68ac
Add Sync suffix to oniguruma methods
2014-07-22 13:31:52 -07:00