Commit Graph

17139 Commits

Author SHA1 Message Date
Jason Rudolph
c9e6d04e8c Revert "Merge #18603 from atom/electron-3-0"
This reverts commit b92ae2ad04, reversing
changes made to d4fe5ccfeb.
2019-02-25 13:41:59 -05:00
Lee Dohm
d07d854986 Merge pull request #16558 from lgeiger/async-git
Add async implementation of GitRepositoryProvider.repositoryForDirectory
2019-02-21 09:29:53 -08:00
Ash Wilson
f0fb288849 Override console.(log|error) and process.std(out|err) when headless 2019-02-17 17:09:58 -05:00
David Wilson
bf3502c4db Fix "Open Folder" menu item on Windows 2019-02-15 09:54:44 -08:00
Nikolay Karev
5e3f12857f Shorter conditionals 2019-02-07 11:46:11 -08:00
Nikolay Karev
bed9c6966e File -> Open works without open windows 2019-02-07 11:46:11 -08:00
David Wilson
6e39fe3097 Merge pull request #18775 from atom/dw-fix-macos-update-restart
Fix restart behavior for "Restart and Install Update" on macOS
2019-02-04 09:54:34 -08:00
David Wilson
2a97673781 Fix restart behavior for "Restart and Install Update" on macOS 2019-02-01 15:51:02 -08:00
Ash Wilson
af64c82a7f Consolidate the "type" documentation to a single list 2019-02-01 13:52:21 -05:00
Ash Wilson
6dd7dcd83b Document the new parameter 2019-02-01 13:37:30 -05:00
Ash Wilson
f4e9b62261 Insert "position: after" decorations in increasing order 2019-02-01 13:18:34 -05:00
Ash Wilson
e8d304b8c7 Sort block decorations to render by order, then id 2019-02-01 13:14:39 -05:00
Ash Wilson
3345000273 Include id and order in Decoration parameters 2019-02-01 13:14:14 -05:00
David Wilson
b92ae2ad04 Merge pull request #18603 from atom/electron-3-0
Upgrade to Electron 3.0
2019-01-31 19:15:14 -08:00
David Wilson
7248737b94 Fix usage of deprecated Buffer APIs in render process 2019-01-25 16:10:56 -08:00
Ash Wilson
039aea4150 Restore missing return statement 2019-01-25 09:20:51 -05:00
Ash Wilson
f68a511a90 pathsToOpen and foldersToOpen may be undefined 2019-01-24 15:17:26 -05:00
Ash Wilson
88d7c6dbdd Include now-missing project folders in initial state key computation 2019-01-24 11:33:44 -05:00
Ash Wilson
07dc40362f Flip conditional for clarity 2019-01-24 11:32:39 -05:00
Ash Wilson
1ecff536c7 Pass persisted window sessions as foldersToOpen 2019-01-24 11:07:00 -05:00
Ash Wilson
02e1ae4b0f Notify about missing project folders 2019-01-24 10:39:50 -05:00
Ash Wilson
f6837d1f97 openLocations() flag to require a path to be an existing directory 2019-01-24 10:19:01 -05:00
David Wilson
7b7fd7b264 Remove listeners for specific events in Task class
This change is necessary for Electron 3 to a bug in Node.js 10.2.x which causes
the `removeAllListeners` method to no longer remove all listeners for any event
name when no argument is passed:

https://github.com/nodejs/node/pull/20924

This issue has been fixed in Node.js 10.3.0+ so we will have to remove this
workaround when we move to Electron 4.0 to avoid future event handler leaks.
2019-01-18 15:13:24 -08:00
David Wilson
f70be77e39 Remove cached-run-in-this-context and use Node's 'vm' script caching 2019-01-18 15:13:24 -08:00
David Wilson
1276f6f85d Use new attributeStyleMap for elements
More info here: https://developers.google.com/web/updates/2018/03/cssom
2019-01-18 15:13:24 -08:00
Ash Wilson
b9bd3713ee Open an untitled buffer when pathToOpen is null or undefined 2019-01-17 08:15:06 -05:00
Ash Wilson
0e8dde4c60 Merge branch 'pr-18394/jneuendorf/master' 2019-01-15 15:52:50 -05:00
Ash Wilson
b4fa03a4a0 It's event.action, not event.type 2019-01-15 15:52:08 -05:00
Ash Wilson
2ab0e8db24 --new-window locks shouldReopenPreviousWindows to false 2019-01-14 11:46:18 -05:00
Ash Wilson
cc0b982c5a Re-word help text 2019-01-14 10:49:21 -05:00
Ash Wilson
92785ac257 Merge branch 'master' into aw/single-file 2019-01-14 10:22:51 -05:00
Winston Liu
98c4876c76 Syntax highlight TooltipManager documentation
Only js is accepted, not javascript
2019-01-10 20:22:40 -05:00
David Wilson
be8097272f Merge pull request #18630 from atom/wl-mv-get-buffer-docs
Move getBuffer out of Event Subscription section
2019-01-08 14:07:23 -08:00
Ash Wilson
d3671f7055 Require --add to open locations in existing windows 2019-01-04 11:06:17 -05:00
Ash Wilson
d725f5e42b 👕 Now that I actually got my linter working 👀 2019-01-04 09:54:36 -05:00
Ash Wilson
f1de652bac ... Right. Joanna can't handle spread properties in objects 2019-01-04 09:06:19 -05:00
Ash Wilson
15594dd8c2 AtomApplication launch behavior shuffle 2019-01-03 16:41:17 -05:00
Ash Wilson
6d2e298de1 Extract a utility method on Project 2019-01-03 16:40:47 -05:00
Ash Wilson
e570f72d86 Remove path normalization responsibilities from AtomWindow 2019-01-03 16:40:35 -05:00
Ash Wilson
6938a31329 Never open the parent directory of a file path 2019-01-03 16:39:09 -05:00
Ash Wilson
e31a142a92 Remove unused initialPaths 2019-01-03 11:28:49 -05:00
Winston Liu
a55daa33b2 👕 2019-01-02 19:58:51 -05:00
Ash Wilson
883719a139 Merge pull request #18611 from atom/aw/electron-link-up
Update electron-link
2019-01-02 17:03:04 -05:00
Winston Liu
aa8d3d6ee8 Fix typo in atom.confirm documentation
[ci skip]
2018-12-28 21:04:18 -05:00
Winston Liu
9dee1d16a1 Move getBuffer out of Event Subscription section 2018-12-28 20:05:27 -05:00
Ash Wilson
8c8426c783 typeof setTimeout isn't enough to probe for snapshot generation 2018-12-21 08:41:09 -05:00
Ash Wilson
b64dac8ea3 👕 2018-12-20 20:51:56 -05:00
Ash Wilson
01bd45ef4c When only a file is specified, don't open the parent directory 2018-12-20 15:59:41 -05:00
Jordan Eldredge
878629dd0a Avoid sending async updates on config update
In
7a5d727e22
the 'set-user-settings' callback was changed so that it nolonger
returned the promise created by `ConfigFile.update()`. This meant that
the logic in
[`ApplicateDelegate.onDidChangeUserSetting()`](https://github.com/atom/atom/blob/5f0231b/src/application-delegate.js#L193-L206) which uses
`.pendingSettingUpdateCount` to avoid triggering in response to calls to
ApplicationDelegate.setUserSettings` was no longer effective.

I noticed this when updating settings via the setting view. If you type
at just the right (wrong?) cadence, you'll notice that your input can
get updated with stale values.

Something like this:

```
You type            "a"      "b"            "c"
config.set          "a"      "ab"           "ac"
config.observe                        "a"         "ab"    "ac"
Input value         "a"      "ab"     "a"   "ac"  "ab"    "ac"
```

It's possible that is the same as https://github.com/atom/settings-view/issues/1062

After this change typing in settings input seems to behave as expected.
2018-12-05 14:34:30 -08:00
Max Brunsfeld
be79ca031c Fix typo that messed up fold marker updates 2018-11-27 10:11:32 -08:00