I initially ripped out Atom::getLoadSettings in favor of a mutable
property because window spec was making an assumption that such a
property existed anyway. Since load settings need to be available from
class methods, the instance method just delegates to the class method.
But that means there's no ::loadSettings property to mutate in that
spec. I replaced the former approach with a spy which has the added
advantage of not polluting windowSettings for subsequent specs.
We assign a value into ::loadSettings anyway in a spec, so there's not
much point leaving it a method. Eventually I'd like to pass all these
settings in when constructing the Atom object and eliminate awareness
of the loadSettings altogether from the Atom global.
Previously, it would blindly read from disk on reload, and set the text
into the editor. This was problematic as it would mess with markers and
folds. No longer.
Fixes#1285 and fixesatom/bookmarks#3
Previously it was only cleared when changing the position explicitly
and not as a result of the underlying marker changing such as during a
text insertion.
Closes#1295
I added some features to telepath that make it easier to test model
objects.
- First, you can now call replicate on any telepath document/model
object. The entire underlying database will be replicated and you will
be handed the equivalent of that object in the replicated world. This
is easier than forcing you to attach the model to the window state
and then call replicate there. However, remember that the entire
window state is actually being replicated so any references the model
has will also be replicated.
- Second, you can also replicate orphaned objects. Most objects in these
specs we're converting are orphans because there's no reason to attach
them to the root document just to test them in isolation.
Serializing and deserializing closed pane items was turning into a pain
with the new telepath changes that are phasing out this kind of on the
fly serialization. Reopening by uri saves memory and simplifies panes
enormously. If we want non-uri reopening we can revisit it later when
telepath models are better integrated.
The spec suite has been overwriting my config directory in weird cases.
While investigating it I noticed that we mock writeFileSync directly in
these specs, but we actually use season to write the config cson. This
makes this spec a bit simpler because it doesn't have to parse the CSON
in the spec. Lower level assertions belong on the season package itself.
Previously only the scope name was checked which allowed cases
were rules without scope names to grow the stack infinitely without
advancing the position.
Closesatom/language-ruby-on-rails#1
