Commit Graph

13349 Commits

Author SHA1 Message Date
Max Brunsfeld
eafffd9733 Merge pull request #9444 from atom/mb-synchronous-scroll-position
Allow synchronous control of scroll position through TextEditor model
2015-11-11 09:58:05 -08:00
Max Brunsfeld
4c3d355298 👕 Add missing space after comma 2015-11-11 08:44:36 -08:00
Antonio Scandurra
7e1a1bc8b0 Merge branch 'master' into as-faster-settings-load
# Conflicts:
#	src/package-manager.coffee
2015-11-11 09:09:47 +01:00
Kevin Sawicki
64d272050d Handle ENOTDIR errors on open
Closes #7864
2015-11-10 16:35:34 -08:00
Kevin Sawicki
e95ce5d1d0 Handle EAGAIN errors when saving pane items
Closes #8202
2015-11-10 16:30:12 -08:00
Max Brunsfeld
0c72500b9e Set firstVisibleScreenRow property before emitting event 2015-11-10 16:29:39 -08:00
Max Brunsfeld
9a35e4c9ec 🎨 Extract methods for setting scroll position based on model 2015-11-10 16:28:31 -08:00
Max Brunsfeld
fefb387d3c Merge branch 'master' into mb-synchronous-scroll-position
Conflicts:
	src/text-editor-presenter.coffee
	src/text-editor.coffee
2015-11-10 16:23:39 -08:00
Kevin Sawicki
cfd5b7b354 Handle EMFILE errors on open
Closes #8429
2015-11-10 16:20:58 -08:00
Kevin Sawicki
24511fef92 Add custom notification for ELOOP save errors
Closes #9242
2015-11-10 15:55:23 -08:00
Kevin Sawicki
95f56aa41e Merge pull request #9514 from atom/ks-disabled-keymaps-for-uninstalled-packages
Guard against not loaded packages when updating disabled keymaps
2015-11-10 15:06:42 -08:00
Nathan Sobo
91bece4336 Merge pull request #9490 from aki77/fix/activatePackages
Fix activatePackages
2015-11-10 15:00:06 -07:00
Kevin Sawicki
4692ca9702 Guard against package not being loaded 2015-11-10 13:54:42 -08:00
Antonio Scandurra
d4a67a7db5 🎨 Call it ::beginTransaction 2015-11-10 11:42:39 +01:00
Antonio Scandurra
e437234c58 Transact on both async and sync package activation 2015-11-10 11:05:31 +01:00
Nathan Sobo
581d736184 Merge pull request #9426 from atom/ns-editor-marker-layers
Optimize markers via new layers API and treap-based index
2015-11-09 23:02:26 -07:00
Nathan Sobo
d4818244f3 Merge pull request #9476 from atom/ns-fix-dev-mode
Always set devMode to true for spec windows
2015-11-09 14:57:17 -07:00
Nathan Sobo
c97ecf9da2 Don’t disable render backgrounding. Doesn’t seem to make a difference. 2015-11-09 14:56:42 -07:00
Kevin Sawicki
589d489eb9 Retain role field from menu items config 2015-11-09 12:30:29 -08:00
Max Brunsfeld
1304648361 Make getLastVisibleScreenRow a model API again 2015-11-09 11:00:38 -08:00
Max Brunsfeld
48cc5e713e Make presenter respond to external changes to model's first visible screen row 2015-11-09 10:13:09 -08:00
Nathan Sobo
fc5788c43b Disable renderer backgrounding 2015-11-09 00:35:34 -07:00
Nathan Sobo
213e7d0b35 Schedule marker updates with nextTick instead of setImmediate
From what I understand, nextTick callbacks actually happen at the end
of the current event loop cycle rather than the next one. The naming is
confusing.
2015-11-09 00:35:33 -07:00
Nathan Sobo
1aa4b7e06a Clear nextUpdatePromise immediately when an animation frame fires 2015-11-09 00:35:33 -07:00
Nathan Sobo
54a9012796 Clear next update promise when resetting ViewRegistry 2015-11-09 00:35:33 -07:00
Nathan Sobo
fe88611e79 Tear down timers when destroying TextEditorPresenter 2015-11-09 00:35:33 -07:00
Nathan Sobo
b9528dcb39 Cancel ViewRegistry animation frames between specs 2015-11-09 00:35:33 -07:00
Nathan Sobo
e9dfc080a3 Convert text-editor-component-spec to Babel for async/await
It's much easier to reason about async/await than Jasmine's
built-in queuing system, and using them made it easier to
debug flaky async tests.
2015-11-09 00:35:32 -07:00
Nathan Sobo
51a7c9ea68 Always set devMode to true for spec windows 2015-11-09 00:35:32 -07:00
Nathan Sobo
3a4199a0cd Allow (start/end)(Buffer/Screen)Position in findMarker queries on layers 2015-11-09 00:35:32 -07:00
Nathan Sobo
533146bc6a Document new APIs 2015-11-09 00:35:32 -07:00
Nathan Sobo
9714f2e729 Emit decoration events synchronously in legacy spec environment
This is needed to keep a bunch of package tests passing that expect
synchronous decoration updates.
2015-11-09 00:35:31 -07:00
Nathan Sobo
9ee3d53975 Destroy the selections marker layer when editors are destroyed 2015-11-09 00:35:31 -07:00
Nathan Sobo
2f81e5faac Store folds in their own marker layer 2015-11-09 00:35:31 -07:00
Nathan Sobo
29bb1bb31b Add TextEditor-level marker layers and use them for selections 2015-11-09 00:35:31 -07:00
Nathan Sobo
1ee6384332 Add TextEditorMarkerLayer 2015-11-09 00:35:31 -07:00
Nathan Sobo
b1a5b58fa2 Rename Marker to TextEditorMarker to resolve ambiguity w/ TextBuffer API
We expose both kinds of markers in Atom, and the docs were actually
wrong when we refer to Markers from TextBuffer because it linked to the
TextEditor layer’s Marker implementation. This will clarify the
difference.
2015-11-09 00:35:30 -07:00
Nathan Sobo
78513f4528 Remove duplicated method definition 2015-11-09 00:35:28 -07:00
Nathan Sobo
a3ff0ad75a 🎨 Rename method 2015-11-09 00:35:28 -07:00
Nathan Sobo
75d0a0820c Allow properties to be overridden for a single marker in LayerDecoration 2015-11-09 00:35:28 -07:00
Nathan Sobo
acf142863c Add TextEditor::decorateMarkerLayer 2015-11-09 00:35:27 -07:00
Nathan Sobo
3a25fe4975 Remove id from decoration properties
It doesn’t make sense to include this when we’ll reuse the same
properties for multiple decoration instances when decorating marker
layers.
2015-11-09 00:35:27 -07:00
Nathan Sobo
d7b0ab9179 Simplify updating of custom gutter decoration state 2015-11-09 00:35:27 -07:00
Nathan Sobo
92ed7c8b15 Don’t return Decoration objects from model to view
Preparation for LayerDecorations, in which individual decoration objects
won’t exist for every marker.
2015-11-09 00:35:27 -07:00
Nathan Sobo
d46091d7e5 Remove dead code 2015-11-09 00:35:27 -07:00
Nathan Sobo
800440d5ca Remove logging 2015-11-09 00:35:27 -07:00
Nathan Sobo
4b5e4d02eb Use real clock in text-editor-component-spec
This will make it much easier to test asynchronous update logic.
2015-11-09 00:35:18 -07:00
Nathan Sobo
1aefb22789 Add ViewRegistry.prototype.getNextUpdatePromise
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-11-09 00:35:18 -07:00
Max Brunsfeld
cdaac9dfcc wip 2015-11-09 00:35:18 -07:00
aki
396e8a42a4 Fix activatePackages 2015-11-08 23:14:13 +09:00