Commit Graph

553 Commits

Author SHA1 Message Date
joshaber
9fa669b293 Set the initial path after saving in Project. 2016-04-25 17:02:51 -04:00
joshaber
5cf532ebe8 Move checkoutHeadRevision to Workspace. 2016-04-25 17:02:36 -04:00
joshaber
8d7f1b8fba Don't need to pass view registry through anymore. 2016-04-25 16:26:28 -04:00
joshaber
3a63f90ab2 We just say getElement now. 2016-04-25 16:24:27 -04:00
joshaber
2266f1e3b6 Revert "Just use the already existing change grammar event."
This reverts commit 9014634b3a.
2016-04-25 15:15:31 -04:00
joshaber
9014634b3a Just use the already existing change grammar event. 2016-04-25 15:09:03 -04:00
joshaber
e8a4f38c69 Don't need to pass the package manager through anymore. 2016-04-25 14:50:14 -04:00
joshaber
6b309be6da Propagate a did-use-grammar event out of the tokenized buffer. 2016-04-25 14:49:43 -04:00
joshaber
8bf34d45d7 Don't require notification manager in TextEditor
Instead expose getCursorScope and let users outside the text editor
show the notification.
2016-04-25 14:12:07 -04:00
Antonio Scandurra
7f77c67761 🔥 preserveFolds from marker's properties 2016-04-15 15:40:22 +02:00
Antonio Scandurra
bbef0b4551 💚 2016-04-14 11:19:45 +02:00
Antonio Scandurra
6b2bfd5656 Merge branch 'master' into ns-switch-to-display-layers 2016-04-11 13:15:00 +02:00
Cole R Lawrence
7decbf0d06 📝 Fix linking the decorateMarker
Error happens at this place in the docs
https://atom.io/docs/api/v1.6.2/TextEditor#instance-decorateMarkerLayer
2016-04-09 14:07:37 -05:00
Antonio Scandurra
ab0d69ce90 Make selectionsMarkerLayer also persistent 2016-04-09 09:50:12 +02:00
Nathan Sobo
effe882a8d Make atomic leading whitespace optional (defaults to enabled)
Closes #3174
2016-04-08 15:31:01 -06:00
Nathan Sobo
5e5cea9600 Drop “experimental” warnings from marker layer APIs 2016-04-08 10:25:25 -06:00
Nathan Sobo
37bfbe8538 Document return value correctly 2016-04-08 10:23:01 -06:00
Nathan Sobo
e587a67f3b Document persistent option in TextEditor::addMarkerLayer 2016-04-08 10:22:50 -06:00
Antonio Scandurra
c23ef9a168 Stop using tokenizedLineForScreenRow in random-editor-spec.coffee 2016-04-07 13:54:29 +02:00
Antonio Scandurra
e236b8c3be Avoid storing properties in selection markers
Previously we were storing a {type: ‘selection’} property, probably
leftover from the “pre-marker-layer” world. We were also storing
`Selection`’s `goalScreenRange` on the marker, which is now just an 
instance variable.
2016-04-06 20:00:08 +02:00
Antonio Scandurra
c2396396a5 📝 Update documentation for mark*Position 2016-04-06 19:20:05 +02:00
Antonio Scandurra
4f28f9f3f8 🔥 Remove defensive assertion
We're not throwing this exception anywhere else, so we might as well delete it 
from here.

/cc: @nathansobo
2016-04-06 15:48:44 +02:00
Antonio Scandurra
ffd3b1829d Provide deprecation warnings for clipScreenPosition parameters
Based on a cursory search, there’s only one package using that API. Even though 
we could submit a PR, we’re introducing deprecations to ensure we're not missing 
any other package.
2016-04-06 15:42:53 +02:00
Antonio Scandurra
25b71b804d Un-document passing clip options to setCursorBufferPosition
…the marker’s screen position will be clipped automatically when
translating coordinates.
2016-04-06 14:44:26 +02:00
Antonio Scandurra
00f03fd614 📝 Document {clipDirection: 'closest'} 2016-04-06 14:21:06 +02:00
Nathan Sobo
af28fa0752 When copying, create selections marker layer on the *new* display layer
Previously, we were copying the selections marker layer into the current
editor’s display layer. This would work fine until the spatial mapping
drifted in the copied editor, and would then have counterintuitive
results.
2016-04-05 18:47:11 -06:00
Nathan Sobo
b922262871 Avoid internal deprecation warning on getHeight 2016-04-05 17:18:24 -06:00
Nathan Sobo
a790ae2158 Avoid deprecation warnings for methods that are now on TextEditor 2016-04-05 12:12:14 -06:00
Nathan Sobo
117a3fb1b5 Provide deprecated TextEditor.prototype.displayBuffer shim
Even though it was a private field, we used it in some of our packages
and it is widespread enough to warrant some effort to smooth the
transition.

Also, we added a couple methods that were formerly implemented on
DisplayBuffer to TextEditor itself because they were used in packages.
2016-04-05 12:11:55 -06:00
Antonio Scandurra
ebd9e71b0b Make serialization format backwards/forwards compatible
Also, introduce a serialization version so we can drop the compatibility
fallbacks in the future.
2016-04-05 11:27:15 -06:00
Antonio Scandurra
bef7539e34 Refactor DisplayBuffer to DecorationManager
This commit moves all the remaining concerns not related to decorations
out of `DisplayBuffer` and into `TextEditor`. This means the
`DisplayBuffer` is now free to be renamed to `DecorationManager`.
2016-04-05 18:43:08 +02:00
Nathan Sobo
bbef4c67c3 Get the TextEditorComponent specs green 2016-04-04 11:21:41 -06:00
Antonio Scandurra
fd960e9a37 Merge branch 'master' into ns-use-display-layers 2016-04-04 15:25:50 +02:00
Machisté N. Quintana
3068631d19 Don't open a transaction if there's a selection at the start / end of line 2016-03-30 12:48:11 -07:00
Machiste Quintana
3b222dbee8 Don't merge selections if at start or end of line 2016-03-28 23:26:28 -07:00
Machiste Quintana
e932e3db05 Merge branch 'master' into mq-move-selected-columns 2016-03-28 22:16:31 -07:00
Antonio Scandurra
f9fb93f214 🎨 2016-03-25 16:37:01 +01:00
Antonio Scandurra
e6cb5c8e89 🐛 Guard against unexisting screen rows 2016-03-24 15:57:24 +01:00
Antonio Scandurra
21831a4e43 🐛 Fix inaccurate logic in moveLineDown
Instead of deleting and then inserting, it’s better to do the opposite
so that we don’t have to translate points at all.
2016-03-23 16:16:51 +01:00
Antonio Scandurra
326f2c6a9e Add TextEditor.prototype.tokensForScreenRow for testing purposes 2016-03-22 14:49:42 +01:00
Antonio Scandurra
b1e07c0cfe Use the new lineText property 2016-03-22 14:36:28 +01:00
Antonio Scandurra
4e23748660 Fix moveLineUp and moveLineDown to work with free-form folds 2016-03-22 14:02:13 +01:00
Antonio Scandurra
227670a407 Merge branch 'master' into ns-use-display-layers 2016-03-22 12:01:07 +01:00
Antonio Scandurra
3c70ff92f4 💚 Add TextEditor.prototype.screenLineForScreenRow
This is going to supplant our internal usage of
TextEditor.prototype.tokenizedLineForScreenRow().
2016-03-18 14:26:29 +01:00
Antonio Scandurra
d1306ae944 Remove invisibles handling from TokenizedBuffer 2016-03-18 14:09:52 +01:00
Antonio Scandurra
5fc699f791 Use intersecting folds when duplicating lines 2016-03-18 11:44:23 +01:00
Antonio Scandurra
d86309e46b Use DisplayLayer.prototype.foldBufferRange in Selection.prototype.fold 2016-03-18 11:33:29 +01:00
Antonio Scandurra
83da3ca440 Fix moveLineUp and moveLineDown 2016-03-18 11:24:22 +01:00
Antonio Scandurra
1d1bdf5872 Improve folds behavior when duplicating lines
Now we will select the entire screen line (which could contain some
free-form fold), and we duplicate its contents preserving the structure
of the existing folds.
2016-03-18 11:04:30 +01:00
Antonio Scandurra
5efb969a63 💚 Start fixing TextEditorComponent specs 2016-03-17 11:33:17 +01:00