Jason Rudolph
efa440f705
Merge pull request #14460 from atom/jr-activate-next-or-previous-pane-in-dock
...
Fix ability to activate next/previous pane in a dock
2017-05-22 10:03:26 -04:00
Jason Rudolph
3020a61e34
Test activating next/previous pane at the workspace level
2017-05-19 10:49:51 -04:00
Jason Rudolph
8079b51839
Remove unnecessary test setup
...
H/T @nathansobo
2017-05-19 09:33:06 -04:00
Antonio Scandurra
d158e44374
Merge branch 'master' into tj-upgrade-electron
2017-05-19 11:05:15 +02:00
Max Brunsfeld
e99545ee41
Fix exception when starting to drag text
2017-05-18 10:13:48 -07:00
Jason Rudolph
d599b52d36
✅ Add failing tests for #14442
2017-05-17 15:26:42 -04:00
Antonio Scandurra
d44876f3bc
Merge branch 'master' into tj-upgrade-electron
2017-05-16 14:39:47 +02:00
Antonio Scandurra
3b3505d969
Always allow to destroy free-form folds from the gutter
2017-05-16 14:36:50 +02:00
Antonio Scandurra
ad6202cadb
Show foldable icon on the last screen row belonging to a buffer row
2017-05-16 14:26:57 +02:00
Antonio Scandurra
4c5127ca2f
Update foldable icon when a row's foldability changes
2017-05-16 14:05:11 +02:00
Lee Dohm
1559c8a047
Merge pull request #12946 from jamsinclair/11848-fix-moving-line-without-line-ending
...
Fixes #11848 Moving line up without line ending
2017-05-13 15:00:46 -07:00
Antonio Scandurra
96533998e2
Fix editor element tests on Windows
2017-05-12 16:51:05 +02:00
Antonio Scandurra
0d4e2b3556
Fix editor component tests on Windows
2017-05-12 13:04:03 +02:00
Antonio Scandurra
186bcd70a5
Fix running packages preloading tests in interactive mode
...
This change also makes the test more useful, as it verifies that reading
metadata from package.json's `packagesCache` works correctly.
2017-05-12 10:11:58 +02:00
Nathan Sobo
e62d1b91b7
Unspy Date.now when jasmine.useRealClock is called
2017-05-11 21:33:50 -06:00
Nathan Sobo
ffd154ec34
Fix lint errors
2017-05-11 21:29:36 -06:00
Nathan Sobo
5a9582ed64
Silence error output in test
2017-05-11 21:10:20 -06:00
Nathan Sobo
b7218e5aa4
Fix atom.setSize spec when window is full screen
2017-05-11 21:06:15 -06:00
Nathan Sobo
6c6d38a3f0
Destroy environment to silence leaked editor warning
2017-05-11 21:02:28 -06:00
Nathan Sobo
8743298c4c
Avoid polluting test with click events on the test runner
...
We now pass an isolated document into the AtomEnvironment instance under
test to avoid accidentally handling clicks on the test runner itself.
2017-05-11 17:59:40 -06:00
Nathan Sobo
2e2b35c32c
Avoid problems related to calling startEditorWindow in tests
2017-05-11 17:44:16 -06:00
Max Brunsfeld
07c2a8e8d6
Merge pull request #14339 from atom/mb-dont-change-focus-when-hiding-unfocused-dock
...
Don't change focus when hiding an unfocused dock
2017-05-11 16:28:27 -07:00
Nathan Sobo
d584bd6adb
Eliminate reliance on local storage in HistoryManager
...
It's causing test failures locally and enough time has passed that most
user data should be transitioned to indexed DB by now.
2017-05-11 16:58:54 -06:00
Nathan Sobo
f8ecf929a8
Disable github package in smoke test – it takes too long to compile
2017-05-11 16:46:02 -06:00
Nathan Sobo
80f033114c
Mock Date.now in spec helper in addition to _.now
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2017-05-11 15:20:53 -06:00
Antonio Scandurra
729ae0ea51
Merge branch 'master' into tj-upgrade-electron
...
# Conflicts:
# script/package.json
# src/task.coffee
2017-05-11 18:05:12 +02:00
Antonio Scandurra
32f03c8a22
Delete unused code
2017-05-11 11:07:21 +02:00
Antonio Scandurra
39a5705e39
Re-enable a test that was previously failing
2017-05-11 11:06:35 +02:00
Nathan Sobo
048a548462
Fix specs
2017-05-10 14:18:15 -06:00
Antonio Scandurra
e89552ea75
Ignore mismatched tags between lines in TokenizedBufferIterator
...
Previously the DisplayLayer would have issues when closing tags that had
not been previously opened, requiring us to guard against mismatched
scopes at the frontier of asynchronous tokenization (see 5cfe9716nathan@github.com >
2017-05-10 17:54:14 +02:00
Nathan Sobo
4eecf8d1a6
Don't change number of tiles based on block decorations
...
This means we may render more tiles than necessary when we have block
decorations, but it prevents changing the number of rendered tiles
during scrolling with certain combinations of line height and editor
height. If it ever becomes a problem we can get smarter about
subtracting the height of the visible block decorations from the editor
height, but for now this gives us more reliable performance for the
common case.
2017-05-09 15:09:14 -06:00
Antonio Scandurra
be2aaa0b22
Use explicit state to recycle tiles instead of modulo scheme
...
This avoids updating tiles unnecessarily when changing the number of
rendered tiles.
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-09 17:46:29 +02:00
Max Brunsfeld
1c8847cb4f
🐎 Ensure rendered tile count is stable when scrolling
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-08 15:50:16 -07:00
Nathan Sobo
f76e850aa5
Fix rendering artifacts when resizing with soft wraps
...
Previously, we were accidentally depending on the state of the display
layer when forcing it to update its index. This caused us to not index
enough content to cover the visibile area, which meant we weren't
querying enough lines to fill the screen in some situations.
2017-05-08 10:58:33 -06:00
Bryant Ung
f464bb3579
Merge pull request #13947 from anatoli26/master
...
Make an option to always restore the last session
2017-05-08 09:33:23 -07:00
Antonio Scandurra
df4116d4aa
Fix clicking past the content height
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-05 19:55:14 +02:00
Antonio Scandurra
15f25a745a
Update width of content when approximate longest screen row changes
2017-05-05 11:29:57 -06:00
Antonio Scandurra
2855e01289
Don't create empty nodes when a text decoration ends next to a text tag
...
This was causing problems in measurements because in that code path we
assume that text nodes are never empty. This commit also adds a test
verifying this invariant when a text decoration ending right after a
text tag is added.
2017-05-05 11:22:01 +02:00
Antonio Scandurra
f7b79b477a
Update class list even when the editor is not attached
2017-05-05 09:30:08 +02:00
Antonio Scandurra
c541d3941c
Fix remaining test failures in core
2017-05-05 09:30:08 +02:00
Nathan Sobo
bc34344d90
Maintain the scroll position when changing font size
2017-05-05 09:30:08 +02:00
Nathan Sobo
c5c48094ba
Avoid requesting horizontal measurement when auto-scrolling vertically
...
This was leaving a measurement request in the map that was getting
picked up on the next frame. In some cases, the requested measurement
row was not present, causing an exception.
2017-05-05 09:30:08 +02:00
Nathan Sobo
1b1973db15
Rename method to match old implementation
2017-05-05 09:30:08 +02:00
Nathan Sobo
c00ad62a0e
Pass mini attribute when creating new TextEditor from TextEditorElement
...
This avoids content being shifted over due to rendering and measuring
the gutter on element creation and then subsequently hiding it.
2017-05-05 09:30:08 +02:00
Nathan Sobo
42bb02c8a8
Account for vertical scrollbar width when soft-wrapping lines
2017-05-05 09:30:08 +02:00
Nathan Sobo
fe13279531
Update DOM in screenPositionForPixelPosition if needed
...
Some packages are interacting with this method assuming this behavior,
so this commit eliminates `screenPositionForPixelPositionSync` and
instead just performs the DOM update in `screenPositionForPixelPosition`
if it is needed.
2017-05-05 09:30:08 +02:00
Antonio Scandurra
001fef4a05
Don't activate scrollPastEnd for autoHeight editors
2017-05-05 09:30:08 +02:00
Antonio Scandurra
c2b854123b
Never create empty spans at the beginning of a row
...
This was happening when a text decoration overlapped a row, but the next
boundary was located exactly at the beginning of it.
2017-05-05 09:29:30 +02:00
Nathan Sobo
ac8a908385
Implement text decorations in rendering layer
2017-05-05 09:29:30 +02:00
Antonio Scandurra
f17baf4790
Use scope ids instead of tags
2017-05-05 09:29:30 +02:00
