Antonio Scandurra
d44876f3bc
Merge branch 'master' into tj-upgrade-electron
2017-05-16 14:39:47 +02:00
Lee Dohm
1559c8a047
Merge pull request #12946 from jamsinclair/11848-fix-moving-line-without-line-ending
...
Fixes #11848 Moving line up without line ending
2017-05-13 15:00:46 -07:00
Antonio Scandurra
39a5705e39
Re-enable a test that was previously failing
2017-05-11 11:06:35 +02:00
Antonio Scandurra
c541d3941c
Fix remaining test failures in core
2017-05-05 09:30:08 +02:00
Antonio Scandurra
001fef4a05
Don't activate scrollPastEnd for autoHeight editors
2017-05-05 09:30:08 +02:00
Nathan Sobo
24e03ee4e6
Fix pageUp/Down tests by using a real element
2017-05-05 09:29:29 +02:00
Nathan Sobo
f2070ef880
Restore editor scroll position across reloads
...
This commit introduces the concept of a scrollTopRow and
scrollLeftColumn which is used to query and update the logical scroll
position.
2017-05-05 09:29:29 +02:00
Nathan Sobo
e232a868c5
Drop tests for set/getFirstVisibleScreenRow
...
These are now tested in text-editor-component-spec
2017-05-05 09:29:29 +02:00
Antonio Scandurra
1d01d499a9
Fix spec/text-editor-spec.coffee
2017-05-05 09:29:29 +02:00
Lee Dohm
6a76ef5dd6
Merge pull request #13764 from atom/wl-dont-soft-wrap-minis
...
Disable soft wrap on mini editors
2017-03-29 14:38:47 -07:00
Amy Troschinetz
ac7bb27e22
Select the replaced text post replacement.
2017-03-08 20:24:31 -06:00
Max Brunsfeld
c1d1bbcb18
Provide a fresh environment when deserializing in specs
2017-03-02 11:54:00 -08:00
Wliu
29c956e66f
Spec!
2017-02-06 22:59:47 -05:00
Antonio Scandurra
e49ac783f8
Fix infinite recursion when calling getLastSelection from onDidAddCursor
2017-01-24 12:18:09 +01:00
Andres Suarez
1ee9d7b0f9
Add showCursorOnSelection config
2017-01-20 08:53:28 -05:00
Nathan Sobo
76d84a7890
Handle multiple selections intersecting a line in duplicateLines
2017-01-12 13:38:19 -07:00
Max Brunsfeld
126f5380ba
Emit editor destroyed event after releasing the editor's buffer
2017-01-03 15:18:01 -08:00
Max Brunsfeld
6f13159549
Don't throw exceptions when using editor APIs after destroying the editor
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-01-03 14:00:50 -08:00
Max Brunsfeld
f4371efb74
Fix usages of destroyed buffers in specs
2017-01-02 11:32:02 -08:00
Nathan Sobo
8b181063ca
Adjust spec now that tab length does not affect leading space tokens
2016-12-13 00:09:09 -07:00
Max Brunsfeld
65edebda73
Update test to reflect new soft wrap indent clipping behavior
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-12-12 17:05:18 -08:00
bene
0411509b43
Fix toggleLineCommentsInSelection for empty lines
2016-10-29 14:04:30 +02:00
Ian Olsen
f726dcc81b
Merge pull request #12922 from stereobooster/10474-prompt-to-save-unsaved-buffer
...
Fix for #10474
2016-10-26 16:35:43 -07:00
Antonio Scandurra
4df74beba7
Merge branch 'master' into as-deprecate-shadow-dom
2016-10-17 12:06:00 +02:00
jamsinclair
aabf472e95
✅ Add test for moving lines up without last line ending
2016-10-12 10:22:25 +13:00
stereobooster
63b9c8eb4b
Add test coverage for save before close
2016-10-11 01:19:55 +03:00
Antonio Scandurra
3d2e18747f
Prefer using new TextEditor to Workspace.prototype.buildTextEditor
2016-10-10 09:28:36 +02:00
Antonio Scandurra
18ddcf902b
Statically assign a clipboard instance to the TextEditor class
2016-10-07 18:21:09 +02:00
Antonio Scandurra
901b0b17a3
Fix failing tests
2016-10-07 13:41:00 +02:00
Max Brunsfeld
d79690e2d5
Merge pull request #12823 from atom/mb-as-guard-tab-length
...
Guard against null tab length value
2016-09-29 14:21:54 -07:00
Max Brunsfeld
556d79b544
Guard against null tab length value
...
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-09-29 12:01:39 -07:00
Indrek Ardel
55f3311c01
Remove unused variables
2016-09-26 20:52:13 +03:00
Antonio Scandurra
de6b836da4
Add test coverage for copying auto{Width,Height}
2016-08-19 14:10:59 +02:00
Antonio Scandurra
1f4cd6e00d
Merge branch 'master' into ns-fix-editor-auto-height
...
# Conflicts:
# src/text-editor.coffee
2016-08-19 13:27:26 +02:00
Max Brunsfeld
26c9e5ee78
Set editor's tokenized buffer's tab length on its display layer when deserializing
2016-08-18 17:06:26 -07:00
Nathan Sobo
dd82902bf2
Disable autoHeight on text editor pane items
2016-08-18 14:03:44 -06:00
Max Brunsfeld
90b699f5cc
Remove some text editor ivars that are redundant w/ display layer properties
2016-08-18 10:41:11 -07:00
Nathan Sobo
13c00995d4
Return default value of true from TextEditor.getAutoHeight
...
When we need to check for unassigned in the deprecated code path, we
can just read the instance variable directly to avoid getting the
deafult.
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-17 15:52:51 -06:00
Nathan Sobo
106621e161
Deprecate automatic assignment of autoHeight for text editors
...
Previously, we attempted to automatically determine whether the editor’s
height should be based on the editor’s content or the height of its
container. Unfortunately, DOM APIs are insufficient to make this
determination in a complete way, leading to unpredictable behavior.
This PR deprecates the automatic determination of this behavior. By
default, editors base their height on their content. If an editor has
an explicit height assigned via its style or is positioned absolute with
an explicit top and bottom, we disable the content-based autoHeight and
log a deprecation warning telling the user to assign autoHeight
explicitly.
This paves the way to add an autoWidth setting, which will default to
false.
2016-08-17 15:52:51 -06:00
Antonio Scandurra
683bf37907
Add autoWidth to TextEditor
2016-08-17 16:14:36 +02:00
Max Brunsfeld
4b0183d074
Remove extraneous TextEditor setter methods
2016-08-15 16:45:10 -07:00
Max Brunsfeld
0d099d2fd5
Serialize all TextEditor parameters needed for the DisplayLayer
2016-08-15 15:51:22 -07:00
Max Brunsfeld
a11a235ef1
Don't reset display layer twice in TextEditor constructor
2016-08-12 13:36:50 -07:00
Max Brunsfeld
0a1834079f
Rename getSoftWrapIndentLength -> getSoftWrapHangingIndentLength
2016-08-11 16:38:34 -07:00
Max Brunsfeld
684952458f
Remove new TextEditor setters; just use update
2016-08-11 15:34:54 -07:00
Max Brunsfeld
11463ef00b
Merge remote-tracking branch 'origin/as-introduce-editor-update' into ns-mb-detangle-editor
2016-08-11 11:36:48 -07:00
Max Brunsfeld
6346d05505
Remove last use of atom.config in text editor spec
2016-08-09 10:20:49 -07:00
Max Brunsfeld
eb9d89f8c8
Observe grammar changes on editors in maintainConfig
2016-08-08 12:10:56 -07:00
Max Brunsfeld
ee2e18737e
Fix maintenance of grammars for copied editors
2016-08-08 11:17:30 -07:00
Max Brunsfeld
ddfb124cb8
Merge branch 'master' into ns-mb-detangle-editor
2016-08-05 09:39:43 -07:00
